flake8
-
reviewboard/admin/tests.py (Diff revision 1)
Review Request #9824 — Created March 22, 2018 and submitted
The search settings form was assuming that the
search_backend_id
field
would be available inclean
, but the value is only present if the
backend passes validation. We now check for its existence instead of
assuming that it does exist and carry on with validation accordingly.
Description | From | Last Updated |
---|---|---|
I also want to see test cases for a correct backend, and info in Testing Done that you've tested all … |
chipx86 | |
E501 line too long (84 > 79 characters) |
reviewbot | |
This should be two tests: One for a backend that doesn't exist, another for the validate() check. |
chipx86 | |
This line is too long. |
chipx86 | |
Ordering is all over the place. Can you fix this? |
chipx86 | |
Rather than the reset() above, can you use this pattern: register try: ... finally: unregister |
chipx86 | |
The "plain" version of a test should always go above the other ones. This should be first. |
chipx86 | |
F841 local variable 'form' is assigned to but never used |
reviewbot | |
E251 unexpected spaces around keyword / parameter equals |
reviewbot | |
E251 unexpected spaces around keyword / parameter equals |
reviewbot | |
E251 unexpected spaces around keyword / parameter equals |
reviewbot | |
E251 unexpected spaces around keyword / parameter equals |
reviewbot | |
Ordering is still off here. |
chipx86 |
Bugs: |
|
||||
---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 2 (+43 -4) |
reviewboard/admin/tests.py (Diff revision 2) |
---|
This should be two tests: One for a backend that doesn't exist, another for the
validate()
check.
Testing Done: |
|
|||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
|||||||||||||||||||||
Diff: |
Revision 3 (+64 -4) |
reviewboard/admin/tests.py (Diff revision 3) |
---|
F841 local variable 'form' is assigned to but never used
reviewboard/admin/tests.py (Diff revision 3) |
---|
E251 unexpected spaces around keyword / parameter equals
reviewboard/admin/tests.py (Diff revision 3) |
---|
E251 unexpected spaces around keyword / parameter equals
reviewboard/admin/tests.py (Diff revision 3) |
---|
Rather than the
reset()
above, can you use this pattern:register try: ... finally: unregister
reviewboard/admin/tests.py (Diff revision 3) |
---|
The "plain" version of a test should always go above the other ones. This should be first.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+68 -5) |
reviewboard/admin/tests.py (Diff revision 4) |
---|
E251 unexpected spaces around keyword / parameter equals
reviewboard/admin/tests.py (Diff revision 4) |
---|
E251 unexpected spaces around keyword / parameter equals
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 5 (+68 -5) |
Owner: |
|
||||
---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 6 (+74 -5) |