Don't overwrite modifications to ModificationTimestampField

Review Request #9816 — Created March 21, 2018 and submitted

brennie
Djblets
release-1.0.x
8800
a0aee27...
djblets

The ModificationTimestampField now tracks manual modifications to the
value so that if code manually sets a timestamp it will not be
overwritten during model save. This allows models to manage timestamps
manually in some cases without having to resort to mucking about with
save_base, etc.

Ran unit tests.

  • 0
  • 0
  • 17
  • 2
  • 19
Description From Last Updated
brennie
brennie
david
  1. 
      
  2. djblets/db/fields.py (Diff revision 2)
     
     
     
     
     

    This does exactly the same thing as django.utils.timezone.now()

  3. 
      
brennie
david
  1. 
      
  2. tests/settings.py (Diff revision 3)
     
     
     

    Can we add a blank line so this doesn't seem grouped with the comment about i18n?

  3. 
      
brennie
david
  1. 
      
  2. djblets/db/fields.py (Diff revision 4)
     
     

    typo: ustom

  3. 
      
brennie
chipx86
  1. 
      
  2. A bunch of work was done prior to this change on release-1.0.x of Djblets to clean up documentation and such. Rather than rewrite the docstrings again, can you pull in the exact text from that branch, to minimize conflicts?

  3. 
      
chipx86
  1. 
      
  2. There's also a bunch of unit tests in release-1.0.x that you're probably going to want to bring over.

    In fact, what I'd suggest is having a precursor change that ports those unit tests to release-0.9.x and ports the docstrings. This change can then be based on those. As it is, it's right now going to be a bit of a mess trying to merge the branches without that work.

  3. djblets/db/fields.py (Diff revision 5)
     
     
     
     

    No blank line.

  4. djblets/db/fields.py (Diff revision 5)
     
     

    This function isn't getting anything. It's returning something.

  5. djblets/db/fields.py (Diff revision 5)
     
     
     

    , optional

  6. djblets/db/fields.py (Diff revision 5)
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    This has a lot of duplicate code paths. This would clear those up:

    existing_value = getattr(model, self.attnmae)
    
    if ((not add and not state.modified) or
        (add and existing_value is None)):
        value = timezone.now()
        setattr(model, self.attname, value)
    elif ((not add and state.modified) or
          (add and existing_value is not None)):
        value = super(...).pre_save(model, add)
    
  7. This isn't the format we use for test class docstrings.

  8. 
      
brennie
chipx86
  1. 
      
  2. djblets/db/fields/modification_timestamp_field.py (Diff revision 6)
     
     
     
     
     

    Should be in alphabetical order.

  3. Can this be get_attr_name or maybe make_attr_name?

  4. Blank lines around this.

  5. This is in the wrong import group.

  6. You can just use timezone.utc.

    Actually, I think I pushed a change that already did this, so you'll just need to update.

  7. Does .objects.create() work for this, instead of doing a .save()?

  8. tests/settings.py (Diff revision 6)
     
     

    This was recently added as well, so you'll probably see this go away or conflict when you update.

  9. 
      
brennie
chipx86
  1. 
      
  2. .objects.create() here and below.

  3. 
      
brennie
david
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.0.x (c409735)
Loading...