Summary:

Update the Assembla tests to use the new hosting service test helpers.

Review Request #9780 — Created March 14, 2018 and submitted April 13, 2018, 12:43 a.m.

Information
Owner:	chipx86
Repository:	Review Board
Branch:	release-3.0.x
Bugs:
Depends On:
Commit:	60f60b7...
Reviewers
Groups:	reviewboard
People:

Description

This updates the Assembla test suite to use the new helpers for hosting

service unit tests, which provide better, more consistent checks with

simpler code and less private method usage. It also raises better

messages when skipping tests due to lack of Perforce support.

Testing Done

Unit tests pass.

flake8 passed.

JSHint passed.

Change Summary:

Rebuilt this change to use the new hosting service test architecture.

Summary:

-	Update the Assembla tests for better checks and to meet standards.
+	Update the Assembla tests to use the new hosting service test helpers.

Description:

~		This updates the Assembla test suite to use the modern docstring format
~		for test names, to split up the service tests from the `AssemblaForm`
~		tests, and to better inspect the calls being made to the SCMTool. Unlike
~		most hosting services, Assembla is a very thin wrapper, going through
	~	This updates the Assembla test suite to use the new helpers for hosting
	~	service unit tests, which provide better, more consistent checks with
	~	simpler code and less private method usage. It also raises better
	~	messages when skipping tests due to lack of Perforce support.
-		standard SVN/P4 protocols instead of an API, so it doesn't do any
-		URL-related checks like most of the recent unit test updates.