Summary

Update the Bitbucket tests to use the new hosting service test helpers.

Review Request #9778 — Created March 14, 2018 and submitted April 13, 2018, 12:41 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

134e233...

Reviewers

Groups

reviewboard

People

Description

This updates the Bitbucket test suite to use the new helpers for hosting
service unit tests, which provide better, more consistent checks with
simpler code. The results of all HTTP requests are checked, ensuring
we're calling what we expect and that behavior doesn't change in the
future.

Testing Done

Unit tests pass.

Issues

Description	From	Last Updated
E501 line too long (80 > 79 characters)	reviewbot	March 14, 2018, 2:34 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/tests/test_bitbucket.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```

Change Summary:

Fixed a line length issue.

Commit:

-	0da8261d790fdd35b390d07929a8ca667767a214
+	22a9007ce661b767ff8e2653796023e5be58683b

Diff:

Revision 2 (+488 -257)

Show changes

reviewboard/hostingsvcs/tests/test_bitbucket.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Rebuilt this change to use the new hosting service test architecture.

Summary:

-	Update the Bitbucket tests for better checks and to meet standards.
+	Update the Bitbucket tests to use the new hosting service test helpers.

Description:

~		This updates the Bitbucket test suite to check all the HTTP requests
~		performed, ensuring that we're calling each API we expect with the
~		correct data in the correct order, and to ensure that payloads are sent
~		as bytes and not Unicode strings.
~
	~	This updates the Bitbucket test suite to use the new helpers for hosting
	~	service unit tests, which provide better, more consistent checks with
	~	simpler code. The results of all HTTP requests are checked, ensuring
	~	we're calling what we expect and that behavior doesn't change in the
	~	future.
-		The main Bitbucket service tests have been split from the hook tests,
-		helping to keep things more manageable.
-
-		Docstrings for tests and utility functions have been added/updated to
-		better fit modern docstring formats.

Commit:

-	22a9007ce661b767ff8e2653796023e5be58683b
+	134e233aed5592893e4b32285e4787192da31e73

Diff:

Revision 3 (+257 -338)

Show changes

reviewboard/hostingsvcs/tests/test_bitbucket.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (66aa930)