Update the CodebaseHQ tests to use the new hosting service test helpers.

Review Request #9777 — Created March 14, 2018 and submitted April 13, 2018, 12:41 a.m.

Information
Owner:	chipx86
Repository:	Review Board
Branch:	release-3.0.x
Bugs:
Depends On:
Commit:	7427522...
Reviewers
Groups:	reviewboard
People:

Description

This updates the CodebaseHQ test suite to use the new helpers for
hosting service unit tests, which provide better, more consistent checks
with simpler code. The results of all HTTP requests are checked,
ensuring we're calling what we expect and that behavior doesn't change
in the future.

Testing Done

Unit tests pass.

flake8 passed.

JSHint passed.

Change Summary:

Rebuilt this change to use the new hosting service test architecture.

Summary:

-	Update CodebaseHQ tests for better checks and consistency.
+	Update the CodebaseHQ tests to use the new hosting service test helpers.

Description:

~		This updates the Gerrit test suite to check all the HTTP requests
~		performed, ensuring that we're calling each API we expect with the
~		correct data in the correct order, and to ensure that payloads are sent
~		as bytes and not Unicode strings.
~
	~	This updates the CodebaseHQ test suite to use the new helpers for
	~	hosting service unit tests, which provide better, more consistent checks
	~	with simpler code. The results of all HTTP requests are checked,
	~	ensuring we're calling what we expect and that behavior doesn't change
	~	in the future.
-		Small changes have also been made to help reduce calls needed during
-		testing.
-
-		Docstrings for tests and utility functions have been added/updated to
-		better fit modern docstring formats.

Commit:

-	6602167d25cdad20abddf364f51af964967fca84
+	7427522f4839e79dac2323ec4946b0f6b223d4b4

Diff:

Revision 2 (+143 -141)

Show changes

reviewboard/hostingsvcs/tests/test_codebasehq.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (e3f57bc)

You have a pending review.

Review Board 5.0.2 alpha 0 (dev)

Update the CodebaseHQ tests to use the new hosting service test helpers.

Change Summary:

Summary:

Description:

Commit:

Diff:

Checks run (2 succeeded)

Status: Closed (submitted)

Change Summary: