Summary

Update the CodebaseHQ tests to use the new hosting service test helpers.

Review Request #9777 — Created March 14, 2018 and submitted April 13, 2018, 12:41 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

7427522...

Reviewers

Groups

reviewboard

People

Description

This updates the CodebaseHQ test suite to use the new helpers for
hosting service unit tests, which provide better, more consistent checks
with simpler code. The results of all HTTP requests are checked,
ensuring we're calling what we expect and that behavior doesn't change
in the future.

Testing Done

Unit tests pass.

flake8 passed.

JSHint passed.

Change Summary:

Rebuilt this change to use the new hosting service test architecture.

Summary:

-	Update CodebaseHQ tests for better checks and consistency.
+	Update the CodebaseHQ tests to use the new hosting service test helpers.

Description:

~		This updates the Gerrit test suite to check all the HTTP requests
~		performed, ensuring that we're calling each API we expect with the
~		correct data in the correct order, and to ensure that payloads are sent
~		as bytes and not Unicode strings.
~
	~	This updates the CodebaseHQ test suite to use the new helpers for
	~	hosting service unit tests, which provide better, more consistent checks
	~	with simpler code. The results of all HTTP requests are checked,
	~	ensuring we're calling what we expect and that behavior doesn't change
	~	in the future.
-		Small changes have also been made to help reduce calls needed during
-		testing.
-
-		Docstrings for tests and utility functions have been added/updated to
-		better fit modern docstring formats.