Update the GitLab tests to use the new hosting service test helpers.
Review Request #9772 — Created March 13, 2018 and submitted
Information | |
---|---|
chipx86 | |
Review Board | |
release-3.0.x | |
06799a9... | |
Reviewers | |
reviewboard | |
This updates the GitLab test suite to use the new helpers for hosting
service unit tests, which provide better, more consistent checks with
simpler code. The results of all HTTP requests are checked, ensuring
we're calling what we expect and that behavior doesn't change in the
future.It also fleshes out the test suite, ensuring we have matching tests for
both GitLab API v3 and v4.
Unit tests pass.
Change Summary:
Updated some function names.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+567 -249) |
Checks run (2 succeeded)
Change Summary:
Changed the
self
argument of_http_request
functions toclient
.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+567 -249) |
Checks run (2 succeeded)
Change Summary:
- Made URL request checks more strict.
- Hard-coded the API version for a couple of checks to reduce the number of requests.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+573 -249) |
Checks run (2 succeeded)
Change Summary:
Rebuilt this change to use the new hosting service test architecture.
Summary: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Commit: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 5 (+690 -700) |