Summary

[WIP] Screen shot should be taken in the website

Review Request #9765 — Created March 10, 2018 and discarded March 17, 2018, 8:26 p.m.

Information

Owner

ridum

Repository

rb-screenshot

Branch

master

Bugs

Depends On

Reviewers

Groups

rb-extension-pack, students

People

Description

The screenshot cropping features are now implemented by first screen shooting the whole page than move it to a new tab then crop it.
The cropping features should occur at the targeting tab using script injection.

Testing Done

Issues

Description	From	Last Updated
Col: 32 Missing semicolon.	reviewbot	March 10, 2018, 10:35 p.m.
Col: 18 A leading decimal point can be confused with a dot: '.4'.	reviewbot	March 10, 2018, 10:35 p.m.

flake8 passed.

JSHint failed.

JSHint

crx/js/background.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 32
 Missing semicolon.
```
crx/js/capture.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 18
 A leading decimal point can be confused with a dot: '.4'.
```

Commit:

70696c92b7d6b91bb5608221d1c13538966f592a

563c94c70704df62f6f0f329d4a91439a05bae38

Diff:

Revision 2 (+93 -59)

Show changes

	README.md
	crx/manifest.json
	crx/js/background.js
	crx/js/capture.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status:: Discarded
Change Summary:: It is unlikely to achieve the in_tab scrren shot through javascript injection; Since different website has different DOM structure and the injection of elements may break it; futhurmore, some website does not allowed the script injections for security reasons.

crx/js/background.js (Diff revision 1)

crx/js/capture.js (Diff revision 1)