[WIP] Screen shot should be taken in the website

Review Request #9765 — Created March 10, 2018 and discarded

ridum
rb-screenshot
master
rb-extension-pack, students

The screenshot cropping features are now implemented by first screen shooting the whole page than move it to a new tab then crop it.
The cropping features should occur at the targeting tab using script injection.



Description From Last Updated

Col: 32 Missing semicolon.

reviewbotreviewbot

Col: 18 A leading decimal point can be confused with a dot: '.4'.

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

Review request changed

Status: Discarded

Change Summary:

It is unlikely to achieve the in_tab scrren shot through javascript injection; Since different website has different DOM structure and the injection of elements may break it; futhurmore, some website does not allowed the script injections for security reasons.

Loading...