Summary

Split up the djblets.db.fields module into submodules.

Review Request #9751 — Created March 6, 2018 and submitted March 12, 2018, 10:54 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-1.0.x

Bugs

Depends On

Commit

8fc1282...

Reviewers

Groups

djblets

People

Description

djblets.db.fields was getting far too large to easily maintain, and
some upcoming work on RelationCounterField was going to make that just
a bit harder. This change addresses this by splitting up the different
areas of responsibility into their own submodules.

None of the actual code has changed, and this means the older fields are
still poorly documented. An upcoming change will address this and other
cleanups.

Testing Done

Djblets and Review Board unit tests pass.

Built the docs and made sure that the djblets.db.fields docs properly
linked to the appropriate submodule docs, without serving up its own
copies of the docs.

Issues

Description	From	Last Updated
typo in summary, description, desting done: django.db instead of djblets.db.	brennie	March 8, 2018, 1:28 a.m.
Can you add module docstrings for each of these while you're adding the new files?	david	March 8, 2018, 1:27 a.m.
W391 blank line at end of file	reviewbot	March 8, 2018, 1:27 a.m.

flake8 failed.

JSHint passed.

flake8

djblets/db/fields/modification_timestamp_field.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W391 blank line at end of file
```

djblets/db/fields/base64_field.py (Diff revision 1)

The issue has been dropped. Show all issues

Can you add module docstrings for each of these while you're adding the new files?

chipx86 March 8, 2018, 1:27 a.m.

These are happening in separate changes.

The issue has been resolved. Show all issues

typo in summary, description, desting done: django.db instead of djblets.db.

Summary:

-	Split up the django.db.fields module into submodules.
+	Split up the djblets.db.fields module into submodules.

Description:

~		`django.db.fields` was getting far too large to easily maintain, and
	~	`djblets.db.fields` was getting far too large to easily maintain, and
		some upcoming work on `RelationCounterField` was going to make that just
		a bit harder. This change addresses this by splitting up the different
		areas of responsibility into their own submodules.

		None of the actual code has changed, and this means the older fields are
		still poorly documented. An upcoming change will address this and other
		cleanups.

Testing Done:

		Djblets and Review Board unit tests pass.

~		Built the docs and made sure that the `django.db.fields` docs properly
	~	Built the docs and made sure that the `djblets.db.fields` docs properly
		linked to the appropriate submodule docs, without serving up its own
		copies of the docs.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-1.0.x (a47cb9d)