• 
      

    Split up the djblets.db.fields module into submodules.

    Review Request #9751 — Created March 6, 2018 and submitted

    Information

    Djblets
    release-1.0.x
    8fc1282...

    Reviewers

    djblets.db.fields was getting far too large to easily maintain, and
    some upcoming work on RelationCounterField was going to make that just
    a bit harder. This change addresses this by splitting up the different
    areas of responsibility into their own submodules.

    None of the actual code has changed, and this means the older fields are
    still poorly documented. An upcoming change will address this and other
    cleanups.

    Djblets and Review Board unit tests pass.

    Built the docs and made sure that the djblets.db.fields docs properly
    linked to the appropriate submodule docs, without serving up its own
    copies of the docs.

    Description From Last Updated

    typo in summary, description, desting done: django.db instead of djblets.db.

    brenniebrennie

    Can you add module docstrings for each of these while you're adding the new files?

    daviddavid

    W391 blank line at end of file

    reviewbotreviewbot
    Checks run (1 failed, 1 succeeded)
    flake8 failed.
    JSHint passed.

    flake8

    david
    1. 
        
    2. djblets/db/fields/base64_field.py (Diff revision 1)
       
       
      Show all issues

      Can you add module docstrings for each of these while you're adding the new files?

      1. These are happening in separate changes.

    3. 
        
    brennie
    1. 
        
    2. Show all issues

      typo in summary, description, desting done: django.db instead of djblets.db.

    3. 
        
    chipx86
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-1.0.x (a47cb9d)