Redirect user to first page of datagrid when changing filters

Review Request #9745 — Created March 5, 2018 and updated

mandeep
Review Board
release-3.0.x
4653
9712
1a72039...
reviewboard
brennie

This patch updates all usages of {% querystring_with %} to
{% querystring %} from /r/9712/. This has the benefit
of allowing us to specify multiple query parameters and redirect users
to page 1 of a datagrid view when changing filters (such as "Show
Closed" changing to "Hide Closed").

Ran unit tests.

  • 0
  • 0
  • 11
  • 0
  • 11
Description From Last Updated
brennie
  1. 
      
  2. Your summary doesn't match what the patch is doing. It should read something like

    Update usage of querystring_with
    
  3. This should be marked as Depends on: 9712 in the Information box.

  4. You posted Markdown content, but RB defaults to no markdown for posted changes, so you will have to edit the description to remove all the backslashes it added.

  5. Can you update all the other usages of querystring_with ? you can find them via:

    git grep querystring_with
    
  6. Missing bug number in bugs field.

  7. Testing done should be sentence case (i.e., Ran unit tests.).

  8. 
      
mandeep
mandeep
mandeep
mandeep
mandeep
mandeep
brennie
  1. 
      
  2. You need to update your description, because this is the same one from the Djblets change. It also doesn't mention the bug being fixed. How about:

    Redirect user to first page of datagrid when changing filters
    
    This patch updates all usages of `{% querystring_with %}` to
    `{% querystring_with_fragments %}` from /r/9712/. This has the benefit
    of allowing us to specify multiple query parameters and redirect users
    to page 1 of a datagrid view when changing filters (such as "Show
    Closed" changing to "Hide Closed").
    
  3. Missing 'page=1'

  4. Missing 'page=1'

  5. 
      
mandeep
mandeep
mandeep
mandeep
mandeep
brennie
  1. 
      
  2. typo in "update"

  3. 
      
mandeep
Review request changed

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
brennie
  1. Im cool with this landing once the dependency lands.

  2. 
      
chipx86
  1. Ship It!
  2. 
      
Loading...