Summary

Redirect user to first page of datagrid when changing filters

Review Request #9745 — Created March 5, 2018 and submitted Feb. 6, 2019, 5:05 p.m.

Information

Owner

mandeep

Repository

Review Board

Branch

release-3.0.x

Bugs

4653

Depends On

~~9712~~

Commit

1a72039...

Reviewers

Groups

reviewboard

People

brennie

Description

This patch updates all usages of {% querystring_with %} to
{% querystring %} from /r/9712/. This has the benefit
of allowing us to specify multiple query parameters and redirect users
to page 1 of a datagrid view when changing filters (such as "Show
Closed" changing to "Hide Closed").

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
This should be marked as Depends on: 9712 in the Information box.	brennie	March 5, 2018, 4:34 p.m.
Testing done should be sentence case (i.e., Ran unit tests.).	brennie	March 5, 2018, 4:37 p.m.
Your summary doesn't match what the patch is doing. It should read something like Update usage of querystring_with	brennie	March 5, 2018, 4:43 p.m.
You posted Markdown content, but RB defaults to no markdown for posted changes, so you will have to edit the …	brennie	March 5, 2018, 4:44 p.m.
Missing bug number in bugs field.	brennie	March 5, 2018, 4:44 p.m.
Can you update all the other usages of querystring_with ? you can find them via: git grep querystring_with	brennie	March 5, 2018, 5:04 p.m.
You need to update your description, because this is the same one from the Djblets change. It also doesn't mention …	brennie	March 14, 2018, 12:17 p.m.
Revert this.	brennie	March 5, 2018, 4:37 p.m.
Missing 'page=1'	brennie	March 14, 2018, 12:15 p.m.
Missing 'page=1'	brennie	March 14, 2018, 12:15 p.m.
typo in "update"	brennie	March 25, 2018, 12:26 a.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

This should be marked as Depends on: 9712 in the Information box.

The issue has been resolved. Show all issues

Testing done should be sentence case (i.e., Ran unit tests.).

The issue has been resolved. Show all issues

Your summary doesn't match what the patch is doing. It should read something like

Update usage of querystring_with

The issue has been resolved. Show all issues

You posted Markdown content, but RB defaults to no markdown for posted changes, so you will have to edit the description to remove all the backslashes it added.

The issue has been resolved. Show all issues
```
Missing bug number in bugs field.
```

The issue has been resolved. Show all issues

Can you update all the other usages of querystring_with ? you can find them via:

git grep querystring_with

reviewboard/templates/datagrids/review_request_listview.html (Diff revision 1)
The issue has been resolved. Show all issues
```
Revert this.
```

Depends On:

+	~~9712 - Add {% querystring %} template tag to add, remove, and update querystring parameters~~

Testing Done:

~		ran unit tests
	~	Ran unit tests.

Summary:

-	Update querystring_with to take an arbitrary number of key-value pairs
+	Update usage of querystring_with

Description:

		Previously, it was only possible to update a single query parameter with
~		`{% querystring_with %}`. However, it is frequently the case that it
	~	`{% querystring_with %\}`. However, it is frequently the case that it
		would be handy to update the querystring from within the template rather
		than having to enumerate all possible cases in the view. Now
		`{% querystring_with %}` can take an arbitrary number of key-value pairs
		in the form of:

~		```html+django
~		{% querystring_with "key1=value1" "key2=value2" %}
~		```
	~
	~
	~	`\{% querystring_with "key1=value1" "key2=value2" %\}`
	+

Bugs:

+	4653

Description:

		Previously, it was only possible to update a single query parameter with
~		`{% querystring_with %\}`. However, it is frequently the case that it
	~	`{% querystring_with %}`. However, it is frequently the case that it
		would be handy to update the querystring from within the template rather
		than having to enumerate all possible cases in the view. Now
~		`{% querystring_with %}` can take an arbitrary number of key-value pairs
	~	`{% querystring_with %}` can take an arbitrary number of key-value pairs
		in the form of:



~		`\{% querystring_with "key1=value1" "key2=value2" %\}`
	~	`{% querystring_with "key1=value1" "key2=value2" %}`

Commit:

-	8a4d1d50916cebbf45c0df54e76b16219a7878df
+	5c19609892c169a50ad20cf6b184dd59b834183d

Diff:

Revision 2 (+6 -6)

Show changes

	reviewboard/templates/datagrids/hideable_listview.html
	reviewboard/templates/datagrids/review_request_listview.html
	reviewboard/templates/datagrids/user_listview.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Summary:

-	Update usage of querystring_with
+	Update usage of querystring_with to querystring_with_fragments

Commit:

-	5c19609892c169a50ad20cf6b184dd59b834183d
+	b475920613ce8c626b8ae8afb9326f4d45b62751

Diff:

Revision 3 (+6 -6)

Show changes

	reviewboard/templates/datagrids/hideable_listview.html
	reviewboard/templates/datagrids/review_request_listview.html
	reviewboard/templates/datagrids/user_listview.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

You need to update your description, because this is the same one from the Djblets change. It also doesn't mention the bug being fixed. How about:

Redirect user to first page of datagrid when changing filters

This patch updates all usages of `{% querystring_with %}` to
`{% querystring_with_fragments %}` from /r/9712/. This has the benefit
of allowing us to specify multiple query parameters and redirect users
to page 1 of a datagrid view when changing filters (such as "Show
Closed" changing to "Hide Closed").

reviewboard/templates/datagrids/hideable_listview.html (Diff revision 3)
The issue has been resolved. Show all issues
```
Missing 'page=1'
```
reviewboard/templates/datagrids/user_listview.html (Diff revision 3)
The issue has been resolved. Show all issues
```
Missing 'page=1'
```

Summary:

-	Update usage of querystring_with to querystring_with_fragments
+	Updated querystring_with_fragments to handle modes

Description:

		Previously, it was only possible to update a single query parameter with
		`{% querystring_with %}`. However, it is frequently the case that it
		would be handy to update the querystring from within the template rather
		than having to enumerate all possible cases in the view. Now
~		`{% querystring_with %}` can take an arbitrary number of key-value pairs
~		in the form of:
	~	{% querystring_with_fragments %} can take an arbitrary number of
	~	key-value pairs in the form of now with different modes:



~		`{% querystring_with "key1=value1" "key2=value2" %}`
~
	~	`{% querystring_with “mode” "key1=value1" "key2=value2" %}`
	~
	+	There are three different modes are:
	+	“remove” - Will remove keys from the query string.
	+	“append” - Will append values for its given key without overwriting.
	+	“update” - Will add to or replace part of a query string.

Commit:

-	b475920613ce8c626b8ae8afb9326f4d45b62751
+	1726a691c9cafc2d9927b91fed5437a7d4c31cda

Diff:

Revision 4 (+6 -6)

Show changes

	reviewboard/templates/datagrids/hideable_listview.html
	reviewboard/templates/datagrids/review_request_listview.html
	reviewboard/templates/datagrids/user_listview.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Summary:

-	Updated querystring_with_fragments to handle modes
+	Redirect user to first page of datagrid when changing filters

Description:

~		Previously, it was only possible to update a single query parameter with
~		`{% querystring_with %}`. However, it is frequently the case that it
~		would be handy to update the querystring from within the template rather
~		than having to enumerate all possible cases in the view. Now
~		{% querystring_with_fragments %} can take an arbitrary number of
	~	This patch updates all usages of `{% querystring_with %}` to
	~	`{% querystring_with_fragments %}` from /r/9712/. This has the benefit
	~	of allowing us to specify multiple query parameters and redirect users
	~	to page 1 of a datagrid view when changing filters (such as "Show
	~	Closed" changing to "Hide Closed").
-		key-value pairs in the form of now with different modes:
-
-
-
-		`{% querystring_with “mode” "key1=value1" "key2=value2" %}`
-
-		There are three different modes are:
-		“remove” - Will remove keys from the query string.
-		“append” - Will append values for its given key without overwriting.
-		“update” - Will add to or replace part of a query string.

Commit:

-	1726a691c9cafc2d9927b91fed5437a7d4c31cda
+	38dc86cf88da17565de3642200165b91a38674fd

Diff:

Revision 5 (+6 -6)

Show changes

	reviewboard/templates/datagrids/hideable_listview.html
	reviewboard/templates/datagrids/review_request_listview.html
	reviewboard/templates/datagrids/user_listview.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Description:

		This patch updates all usages of `{% querystring_with %}` to
~		`{% querystring_with_fragments %}` from /r/9712/. This has the benefit
	~	`{% querystring %}` from /r/9712/. This has the benefit
		of allowing us to specify multiple query parameters and redirect users
		to page 1 of a datagrid view when changing filters (such as "Show
		Closed" changing to "Hide Closed").

Commit:

-	38dc86cf88da17565de3642200165b91a38674fd
+	8e66da94fb3b51535616826b273c34e53934d202

Diff:

Revision 6 (+6 -6)

Show changes

	reviewboard/templates/datagrids/hideable_listview.html
	reviewboard/templates/datagrids/review_request_listview.html
	reviewboard/templates/datagrids/user_listview.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/templates/datagrids/user_listview.html (Diff revision 6)
The issue has been resolved. Show all issues
```
typo in "update"
```

Commit:

-	8e66da94fb3b51535616826b273c34e53934d202
+	1a72039d2bb638ca7dfc893c97a3864cbca4d380

Diff:

Revision 7 (+6 -6)

Show changes

	reviewboard/templates/datagrids/hideable_listview.html
	reviewboard/templates/datagrids/review_request_listview.html
	reviewboard/templates/datagrids/user_listview.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

Im cool with this landing once the dependency lands.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (e4028e5)