Redirect user to first page of datagrid when changing filters

Review Request #9745 — Created March 5, 2018 and submitted

Information

Review Board
release-3.0.x
1a72039...

Reviewers

This patch updates all usages of {% querystring_with %} to
{% querystring %} from /r/9712/. This has the benefit
of allowing us to specify multiple query parameters and redirect users
to page 1 of a datagrid view when changing filters (such as "Show
Closed" changing to "Hide Closed").

Ran unit tests.

Description From Last Updated

This should be marked as Depends on: 9712 in the Information box.

brenniebrennie

Testing done should be sentence case (i.e., Ran unit tests.).

brenniebrennie

Your summary doesn't match what the patch is doing. It should read something like Update usage of querystring_with

brenniebrennie

You posted Markdown content, but RB defaults to no markdown for posted changes, so you will have to edit the …

brenniebrennie

Missing bug number in bugs field.

brenniebrennie

Can you update all the other usages of querystring_with ? you can find them via: git grep querystring_with

brenniebrennie

You need to update your description, because this is the same one from the Djblets change. It also doesn't mention …

brenniebrennie

Revert this.

brenniebrennie

Missing 'page=1'

brenniebrennie

Missing 'page=1'

brenniebrennie

typo in "update"

brenniebrennie
brennie
  1. 
      
  2. This should be marked as Depends on: 9712 in the Information box.

  3. Testing done should be sentence case (i.e., Ran unit tests.).

  4. Your summary doesn't match what the patch is doing. It should read something like

    Update usage of querystring_with
    
  5. You posted Markdown content, but RB defaults to no markdown for posted changes, so you will have to edit the description to remove all the backslashes it added.

  6. Missing bug number in bugs field.

  7. Can you update all the other usages of querystring_with ? you can find them via:

    git grep querystring_with
    
  8. 
      
mandeep
mandeep
mandeep
mandeep
mandeep
mandeep
brennie
  1. 
      
  2. You need to update your description, because this is the same one from the Djblets change. It also doesn't mention the bug being fixed. How about:

    Redirect user to first page of datagrid when changing filters
    
    This patch updates all usages of `{% querystring_with %}` to
    `{% querystring_with_fragments %}` from /r/9712/. This has the benefit
    of allowing us to specify multiple query parameters and redirect users
    to page 1 of a datagrid view when changing filters (such as "Show
    Closed" changing to "Hide Closed").
    
  3. Missing 'page=1'

  4. Missing 'page=1'

  5. 
      
mandeep
mandeep
mandeep
mandeep
mandeep
brennie
  1. 
      
  2. typo in "update"

  3. 
      
mandeep
brennie
  1. Im cool with this landing once the dependency lands.

  2. 
      
chipx86
  1. Ship It!
  2. 
      
mandeep
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (e4028e5)
Loading...