Redirect user to first page of datagrid when changing filters
Review Request #9745 — Created March 5, 2018 and submitted
Information | |
---|---|
mandeep | |
Review Board | |
release-3.0.x | |
4653 | |
|
|
1a72039... | |
Reviewers | |
reviewboard | |
brennie |
This patch updates all usages of
{% querystring_with %}
to
{% querystring %}
from /r/9712/. This has the benefit
of allowing us to specify multiple query parameters and redirect users
to page 1 of a datagrid view when changing filters (such as "Show
Closed" changing to "Hide Closed").
Ran unit tests.
Description | From | Last Updated |
---|---|---|
This should be marked as Depends on: 9712 in the Information box. |
|
|
Testing done should be sentence case (i.e., Ran unit tests.). |
|
|
Your summary doesn't match what the patch is doing. It should read something like Update usage of querystring_with |
|
|
You posted Markdown content, but RB defaults to no markdown for posted changes, so you will have to edit the … |
|
|
Missing bug number in bugs field. |
|
|
Can you update all the other usages of querystring_with ? you can find them via: git grep querystring_with |
|
|
You need to update your description, because this is the same one from the Djblets change. It also doesn't mention … |
|
|
Revert this. |
|
|
Missing 'page=1' |
|
|
Missing 'page=1' |
|
|
typo in "update" |
|
-
-
-
-
Your summary doesn't match what the patch is doing. It should read something like
Update usage of querystring_with
-
You posted Markdown content, but RB defaults to no markdown for posted changes, so you will have to edit the description to remove all the backslashes it added.
-
-
Can you update all the other usages of
querystring_with
? you can find them via:git grep querystring_with
-
Summary: |
|
|||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||||||||||||||||||||||||||||||||||||||
Bugs: |
|
Description: |
|
---|
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+6 -6) |
Checks run (2 succeeded)
Summary: |
|
||||
---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 3 (+6 -6) |
Checks run (2 succeeded)
-
-
You need to update your description, because this is the same one from the Djblets change. It also doesn't mention the bug being fixed. How about:
Redirect user to first page of datagrid when changing filters This patch updates all usages of `{% querystring_with %}` to `{% querystring_with_fragments %}` from /r/9712/. This has the benefit of allowing us to specify multiple query parameters and redirect users to page 1 of a datagrid view when changing filters (such as "Show Closed" changing to "Hide Closed").
-
-
Summary: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Commit: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 4 (+6 -6) |
Checks run (2 succeeded)
Summary: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 5 (+6 -6) |
Checks run (2 succeeded)
Description: |
|
---|
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 6 (+6 -6) |
Checks run (2 succeeded)
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 7 (+6 -6) |