flake8
passed.
JSHint
passed.
Redirect user to first page of datagrid when changing filters
Review Request #9745 — Created March 5, 2018 and submitted
This patch updates all usages of
{% querystring_with %}to
{% querystring %}from /r/9712/. This has the benefit
of allowing us to specify multiple query parameters and redirect users
to page 1 of a datagrid view when changing filters (such as "Show
Closed" changing to "Hide Closed").
Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
This should be marked as Depends on: 9712 in the Information box. |
 brennie
|
|
|
Testing done should be sentence case (i.e., Ran unit tests.). |
brennie
|
|
|
Your summary doesn't match what the patch is doing. It should read something like Update usage of querystring_with |
brennie
|
|
|
You posted Markdown content, but RB defaults to no markdown for posted changes, so you will have to edit the … |
brennie
|
|
|
Missing bug number in bugs field. |
brennie
|
|
|
Can you update all the other usages of querystring_with ? you can find them via: git grep querystring_with |
brennie
|
|
|
You need to update your description, because this is the same one from the Djblets change. It also doesn't mention … |
brennie
|
|
|
Revert this. |
brennie
|
|
|
Missing 'page=1' |
brennie
|
|
|
Missing 'page=1' |
brennie
|
|
|
typo in "update" |
brennie
|
-
-
-
-
Your summary doesn't match what the patch is doing. It should read something like
Update usage of querystring_with -
You posted Markdown content, but RB defaults to no markdown for posted changes, so you will have to edit the description to remove all the backslashes it added.
-
-
Can you update all the other usages of
querystring_with? you can find them via:git grep querystring_with -
- Summary:
-
Update querystring_with to take an arbitrary number of key-value pairsUpdate usage of querystring_with
- Description:
-
Previously, it was only possible to update a single query parameter with
~ `{% querystring_with %}`. However, it is frequently the case that it ~ {% querystring_with %\}. However, it is frequently the case that itwould be handy to update the querystring from within the template rather than having to enumerate all possible cases in the view. Now `{% querystring_with %}` can take an arbitrary number of key-value pairs in the form of: ~ ```html+django
~ {% querystring_with "key1=value1" "key2=value2" %} ~ ``` ~ ~ ~ \{% querystring_with "key1=value1" "key2=value2" %\}+ - Bugs:
- Description:
-
Previously, it was only possible to update a single query parameter with
~ {% querystring_with %\}. However, it is frequently the case that it~ {% querystring_with %}. However, it is frequently the case that itwould be handy to update the querystring from within the template rather than having to enumerate all possible cases in the view. Now ~ `{% querystring_with %}` can take an arbitrary number of key-value pairs ~ {% querystring_with %}can take an arbitrary number of key-value pairsin the form of: ~ \{% querystring_with "key1=value1" "key2=value2" %\}~ {% querystring_with "key1=value1" "key2=value2" %}
- Commit:
-
8a4d1d50916cebbf45c0df54e76b16219a7878df5c19609892c169a50ad20cf6b184dd59b834183d
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Summary:
-
Update usage of querystring_withUpdate usage of querystring_with to querystring_with_fragments
- Commit:
-
5c19609892c169a50ad20cf6b184dd59b834183db475920613ce8c626b8ae8afb9326f4d45b62751
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
You need to update your description, because this is the same one from the Djblets change. It also doesn't mention the bug being fixed. How about:
Redirect user to first page of datagrid when changing filters This patch updates all usages of `{% querystring_with %}` to `{% querystring_with_fragments %}` from /r/9712/. This has the benefit of allowing us to specify multiple query parameters and redirect users to page 1 of a datagrid view when changing filters (such as "Show Closed" changing to "Hide Closed"). -
-
- Summary:
-
Update usage of querystring_with to querystring_with_fragmentsUpdated querystring_with_fragments to handle modes
- Description:
-
Previously, it was only possible to update a single query parameter with
{% querystring_with %}. However, it is frequently the case that itwould be handy to update the querystring from within the template rather than having to enumerate all possible cases in the view. Now ~ {% querystring_with %}can take an arbitrary number of key-value pairs~ in the form of: ~ {% querystring_with_fragments %} can take an arbitrary number of ~ key-value pairs in the form of now with different modes: ~ {% querystring_with "key1=value1" "key2=value2" %}~ ~ {% querystring_with “mode” "key1=value1" "key2=value2" %}~ + There are three different modes are:
+ “remove” - Will remove keys from the query string. + “append” - Will append values for its given key without overwriting. + “update” - Will add to or replace part of a query string. - Commit:
-
b475920613ce8c626b8ae8afb9326f4d45b627511726a691c9cafc2d9927b91fed5437a7d4c31cda
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Summary:
-
Updated querystring_with_fragments to handle modesRedirect user to first page of datagrid when changing filters
- Description:
-
~ Previously, it was only possible to update a single query parameter with
~ {% querystring_with %}. However, it is frequently the case that it~ would be handy to update the querystring from within the template rather ~ than having to enumerate all possible cases in the view. Now ~ {% querystring_with_fragments %} can take an arbitrary number of ~ This patch updates all usages of
{% querystring_with %}to~ {% querystring_with_fragments %}from /r/9712/. This has the benefit~ of allowing us to specify multiple query parameters and redirect users ~ to page 1 of a datagrid view when changing filters (such as "Show ~ Closed" changing to "Hide Closed"). - key-value pairs in the form of now with different modes: - - - - {% querystring_with “mode” "key1=value1" "key2=value2" %}- - There are three different modes are:
- “remove” - Will remove keys from the query string. - “append” - Will append values for its given key without overwriting. - “update” - Will add to or replace part of a query string.
- Commit:
-
1726a691c9cafc2d9927b91fed5437a7d4c31cda38dc86cf88da17565de3642200165b91a38674fd
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Description:
-
This patch updates all usages of
{% querystring_with %}to~ {% querystring_with_fragments %}from /r/9712/. This has the benefit~ {% querystring %}from /r/9712/. This has the benefitof allowing us to specify multiple query parameters and redirect users to page 1 of a datagrid view when changing filters (such as "Show Closed" changing to "Hide Closed").
- Commit:
-
38dc86cf88da17565de3642200165b91a38674fd8e66da94fb3b51535616826b273c34e53934d202
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
