flake8
-
rbtools/clients/mercurial.py (Diff revision 1) -
-
-
Review Request #9744 — Created March 5, 2018 and discarded
rbt land supports Git, this change adds support for Mercurial as well.
rbt land
works on bookmarks in mercurial.
Mercurial supports merging and deleting bookmarks but not pushing upstream because
bookmarks are usually not shared with the upstream, so it is left to the user to
decide what they push.
Ran all unit tests
Added unit tests for the new mercurial client functions.
Tested somerbt land
commands on a Mercurial repository including--local
,
not local,--squash
, and--no-squash
.
Description | From | Last Updated |
---|---|---|
F401 'rbtools.clients.errors.PushError' imported but unused |
reviewbot | |
E303 too many blank lines (2) |
reviewbot | |
E261 at least two spaces before inline comment |
reviewbot | |
W391 blank line at end of file |
reviewbot | |
F401 'rbtools.clients.errors.PushError' imported but unused |
reviewbot | |
E231 missing whitespace after ',' |
reviewbot | |
E501 line too long (80 > 79 characters) |
reviewbot | |
E501 line too long (88 > 79 characters) |
reviewbot | |
E501 line too long (91 > 79 characters) |
reviewbot | |
E231 missing whitespace after ',' |
reviewbot | |
E501 line too long (82 > 79 characters) |
reviewbot | |
W391 blank line at end of file |
reviewbot | |
F401 'rbtools.clients.errors.PushError' imported but unused |
reviewbot | |
F821 undefined name 'bookmark' |
reviewbot | |
E231 missing whitespace after ',' |
reviewbot | |
F821 undefined name 'branch' |
reviewbot | |
E501 line too long (81 > 79 characters) |
reviewbot | |
E303 too many blank lines (2) |
reviewbot | |
E231 missing whitespace after ',' |
reviewbot | |
E501 line too long (80 > 79 characters) |
reviewbot | |
E501 line too long (88 > 79 characters) |
reviewbot | |
E501 line too long (91 > 79 characters) |
reviewbot | |
E231 missing whitespace after ',' |
reviewbot | |
E501 line too long (82 > 79 characters) |
reviewbot | |
E265 block comment should start with '# ' |
reviewbot | |
W391 blank line at end of file |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E231 missing whitespace after ',' |
reviewbot | |
E303 too many blank lines (2) |
reviewbot | |
E231 missing whitespace after ',' |
reviewbot | |
E231 missing whitespace after ',' |
reviewbot | |
E501 line too long (80 > 79 characters) |
reviewbot | |
E501 line too long (86 > 79 characters) |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
W391 blank line at end of file |
reviewbot | |
E501 line too long (88 > 79 characters) |
reviewbot | |
E265 block comment should start with '# ' |
reviewbot | |
E501 line too long (85 > 79 characters) |
reviewbot | |
E501 line too long (86 > 79 characters) |
reviewbot | |
F401 'rbtools.commands.CommandError' imported but unused |
reviewbot | |
E303 too many blank lines (3) |
reviewbot | |
E231 missing whitespace after ',' |
reviewbot | |
E303 too many blank lines (2) |
reviewbot | |
F401 'rbtools.clients.errors.PushError' imported but unused |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E127 continuation line over-indented for visual indent |
reviewbot | |
E127 continuation line over-indented for visual indent |
reviewbot | |
E231 missing whitespace after ',' |
reviewbot | |
E231 missing whitespace after ',' |
reviewbot | |
E501 line too long (83 > 79 characters) |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E303 too many blank lines (2) |
reviewbot | |
E231 missing whitespace after ',' |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E231 missing whitespace after ',' |
reviewbot | |
E231 missing whitespace after ',' |
reviewbot | |
E303 too many blank lines (2) |
reviewbot | |
E303 too many blank lines (3) |
reviewbot | |
E501 line too long (88 > 79 characters) |
reviewbot | |
E265 block comment should start with '# ' |
reviewbot | |
W503 line break before binary operator |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
E501 line too long (80 > 79 characters) |
reviewbot | |
E501 line too long (81 > 79 characters) |
reviewbot | |
W503 line break before binary operator |
reviewbot |
Testing Done: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
|||||||||
Diff: |
Revision 2 (+64 -3) |
rbtools/clients/mercurial.py (Diff revision 2) |
---|
F401 'rbtools.clients.errors.PushError' imported but unused
Identifying fifferences between git and hg
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+75 -3) |
rbtools/clients/mercurial.py (Diff revision 3) |
---|
F401 'rbtools.clients.errors.PushError' imported but unused
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+173 -6) |
rbtools/clients/mercurial.py (Diff revision 4) |
---|
E128 continuation line under-indented for visual indent
rbtools/clients/mercurial.py (Diff revision 4) |
---|
E128 continuation line under-indented for visual indent
rbtools/clients/mercurial.py (Diff revision 4) |
---|
E128 continuation line under-indented for visual indent
rbtools/commands/tests/test_land.py (Diff revision 4) |
---|
F401 'rbtools.commands.CommandError' imported but unused
Description: |
|
||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
||||||||||||||||||
Diff: |
Revision 5 (+303 -20) |
Warning: Showing 30 of 32 failures.
rbtools/clients/mercurial.py (Diff revision 5) |
---|
F401 'rbtools.clients.errors.PushError' imported but unused
rbtools/clients/mercurial.py (Diff revision 5) |
---|
E128 continuation line under-indented for visual indent
rbtools/clients/mercurial.py (Diff revision 5) |
---|
E128 continuation line under-indented for visual indent
rbtools/clients/mercurial.py (Diff revision 5) |
---|
E128 continuation line under-indented for visual indent
rbtools/clients/mercurial.py (Diff revision 5) |
---|
E128 continuation line under-indented for visual indent
rbtools/clients/mercurial.py (Diff revision 5) |
---|
E127 continuation line over-indented for visual indent
rbtools/clients/mercurial.py (Diff revision 5) |
---|
E127 continuation line over-indented for visual indent
rbtools/clients/mercurial.py (Diff revision 5) |
---|
E128 continuation line under-indented for visual indent
rbtools/clients/tests/test_mercurial.py (Diff revision 5) |
---|
E128 continuation line under-indented for visual indent
rbtools/clients/tests/test_mercurial.py (Diff revision 5) |
---|
E128 continuation line under-indented for visual indent
rbtools/clients/tests/test_mercurial.py (Diff revision 5) |
---|
E128 continuation line under-indented for visual indent
rbtools/clients/tests/test_mercurial.py (Diff revision 5) |
---|
E128 continuation line under-indented for visual indent
rbtools/clients/tests/test_mercurial.py (Diff revision 5) |
---|
E128 continuation line under-indented for visual indent
rbtools/clients/tests/test_mercurial.py (Diff revision 5) |
---|
E128 continuation line under-indented for visual indent
rbtools/clients/tests/test_mercurial.py (Diff revision 5) |
---|
E128 continuation line under-indented for visual indent
rbtools/clients/tests/test_mercurial.py (Diff revision 5) |
---|
E128 continuation line under-indented for visual indent
rbtools/clients/tests/test_mercurial.py (Diff revision 5) |
---|
E128 continuation line under-indented for visual indent
rbtools/clients/tests/test_mercurial.py (Diff revision 5) |
---|
E128 continuation line under-indented for visual indent
rbtools/clients/tests/test_mercurial.py (Diff revision 5) |
---|
E128 continuation line under-indented for visual indent
Summary: |
|
||||
---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 6 (+312 -23) |
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 7 (+302 -22) |
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 8 (+302 -22) |
Testing Done: |
|
---|