Add Mercurial support to rbt land

Review Request #9744 — Created March 5, 2018 and discarded

Information

RBTools
release-0.7.x

Reviewers

rbt land supports Git, this change adds support for Mercurial as well.
rbt land works on bookmarks in mercurial.
Mercurial supports merging and deleting bookmarks but not pushing upstream because
bookmarks are usually not shared with the upstream, so it is left to the user to
decide what they push.

Ran all unit tests
Added unit tests for the new mercurial client functions.
Tested some rbt land commands on a Mercurial repository including --local,
not local, --squash, and --no-squash.

Description From Last Updated

F401 'rbtools.clients.errors.PushError' imported but unused

reviewbotreviewbot

E303 too many blank lines (2)

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W391 blank line at end of file

reviewbotreviewbot

F401 'rbtools.clients.errors.PushError' imported but unused

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E501 line too long (80 > 79 characters)

reviewbotreviewbot

E501 line too long (88 > 79 characters)

reviewbotreviewbot

E501 line too long (91 > 79 characters)

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E501 line too long (82 > 79 characters)

reviewbotreviewbot

W391 blank line at end of file

reviewbotreviewbot

F401 'rbtools.clients.errors.PushError' imported but unused

reviewbotreviewbot

F821 undefined name 'bookmark'

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

F821 undefined name 'branch'

reviewbotreviewbot

E501 line too long (81 > 79 characters)

reviewbotreviewbot

E303 too many blank lines (2)

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E501 line too long (80 > 79 characters)

reviewbotreviewbot

E501 line too long (88 > 79 characters)

reviewbotreviewbot

E501 line too long (91 > 79 characters)

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E501 line too long (82 > 79 characters)

reviewbotreviewbot

E265 block comment should start with '# '

reviewbotreviewbot

W391 blank line at end of file

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E303 too many blank lines (2)

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E501 line too long (80 > 79 characters)

reviewbotreviewbot

E501 line too long (86 > 79 characters)

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

W391 blank line at end of file

reviewbotreviewbot

E501 line too long (88 > 79 characters)

reviewbotreviewbot

E265 block comment should start with '# '

reviewbotreviewbot

E501 line too long (85 > 79 characters)

reviewbotreviewbot

E501 line too long (86 > 79 characters)

reviewbotreviewbot

F401 'rbtools.commands.CommandError' imported but unused

reviewbotreviewbot

E303 too many blank lines (3)

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E303 too many blank lines (2)

reviewbotreviewbot

F401 'rbtools.clients.errors.PushError' imported but unused

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E127 continuation line over-indented for visual indent

reviewbotreviewbot

E127 continuation line over-indented for visual indent

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E501 line too long (83 > 79 characters)

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E303 too many blank lines (2)

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E303 too many blank lines (2)

reviewbotreviewbot

E303 too many blank lines (3)

reviewbotreviewbot

E501 line too long (88 > 79 characters)

reviewbotreviewbot

E265 block comment should start with '# '

reviewbotreviewbot

W503 line break before binary operator

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E501 line too long (80 > 79 characters)

reviewbotreviewbot

E501 line too long (81 > 79 characters)

reviewbotreviewbot

W503 line break before binary operator

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

MA
MA
Review request changed
Testing Done:
   

Currently,the following commands work on a Mercurial repository:

~   rbt land -r ## --local --no-delete-branch

  ~ rbt land -r ## --local --no-delete-branch --no-squash

Commit:
c48cdf890d5668f1faad40d128feff4af30bd020
9ee1a21fe3b8ce731c35cb53a91be2b12c1fe75f

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

MA
Review request changed
Change Summary:

Identifying fifferences between git and hg

Commit:
9ee1a21fe3b8ce731c35cb53a91be2b12c1fe75f
e81164482e770ebe0a75c2c7d1ef26aa3b2dbecd

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

MA
Review request changed
Commit:
e81164482e770ebe0a75c2c7d1ef26aa3b2dbecd
49918777cca22250a5ec849de7f877eca783fbb3

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

MA
Review request changed
Description:
~  

rbt land supports Git, this change adds support for Mercurial as well.

  ~

rbt land supports Git, this change adds support for Mercurial as well.

  + rbt land works on bookmarks in mercurial.
  + Mercurial supports merging and deleting bookmarks but not pushing upstream because
  + bookmarks are usually not shared with the upstream, so it is left to the user to
  + decide what they push.

Testing Done:
~  

Currently,the following commands work on a Mercurial repository:

~   rbt land -r ## --local --no-delete-branch --no-squash

  ~

Ran all unit tests

  ~ Added unit tests for the new mercurial client functions.
  + Tested some rbt land commands on a Mercurial repository including --local, not local, --squash, --no-squash.

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

MA
Review request changed
Summary:
[WIP] Add Mercurial support to rbt land
Add Mercurial support to rbt land
Commit:
49918777cca22250a5ec849de7f877eca783fbb3
c05a2cb424c28127d86182b7c1754b100f7a7f1f

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

MA
Review request changed
Commit:
c05a2cb424c28127d86182b7c1754b100f7a7f1f
c2440931c9e902beccb2cc5c25cd709177dcb221

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

MA
MA
david
Review request changed
Status:
Discarded