Fix cleanup of temporary files.

Review Request #9718 — Created March 1, 2018 and submitted

david
ReviewBot
release-1.0.x
4640
86cb97e...
reviewbot

A typo was preventing the successful cleanup of temporary files after
each tool was run. This change fixes that up. A longer-term goal of mine
is to fix up the temporary file stuff to make things work via context
managers but for now this will at least stop people's temp directories
from filling up.

Ran some tools and saw that tempfiles weren't left over.

Description From Last Updated

Was this hitting a NameError sometimes and causing the following code not to run?

brenniebrennie
brennie
  1. 
      
  2. bot/reviewbot/utils/filesystem.py (Diff revision 1)
     
     

    Was this hitting a NameError sometimes and causing the following code not to run?

    1. s/sometimes/always/, but yes

  3. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.0.x (cbcfa94)
Loading...