Summary

Fix cleanup of temporary files.

Review Request #9718 — Created March 1, 2018 and submitted March 7, 2018, 1:23 p.m.

Information

Owner

david

Repository

ReviewBot

Branch

release-1.0.x

Bugs

4640

Depends On

Commit

86cb97e...

Reviewers

Groups

reviewbot

People

Description

A typo was preventing the successful cleanup of temporary files after
each tool was run. This change fixes that up. A longer-term goal of mine
is to fix up the temporary file stuff to make things work via context
managers but for now this will at least stop people's temp directories
from filling up.

Testing Done

Ran some tools and saw that tempfiles weren't left over.

Issues

Description	From	Last Updated
Was this hitting a NameError sometimes and causing the following code not to run?	brennie	March 5, 2018, 9:54 p.m.

flake8 passed.

JSHint passed.

bot/reviewbot/utils/filesystem.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Was this hitting a NameError sometimes and causing the following code not to run?
```
1. david March 5, 2018, 9:54 p.m.
  s/sometimes/always/, but yes

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.0.x (cbcfa94)