Summary

Add a JavaScript utility function for building URLs.

Review Request #9716 — Created March 1, 2018 and submitted March 12, 2018, 10:59 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-1.0.x

Bugs

Depends On

Commit

dcc628b...

Reviewers

Groups

djblets

People

Description

This adds a new Djblets.buildURL() function that can build a URL from

a base path, query string data, and an anchor. It takes care of encoding

query string data and ensuring the resulting URL is formatted just

right.

Testing Done

Unit tests pass.

Issues

Description	From	Last Updated
Col: 32 Expected '===' and instead saw '=='.	reviewbot	March 1, 2018, 7:43 p.m.
typo: "Build an" -> "Build and"	david	March 4, 2018, 10:33 p.m.

flake8 passed.

JSHint failed.

JSHint

djblets/static/djblets/js/utils/urls.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 32
 Expected '===' and instead saw '=='.
```

Change Summary:


Replaced a == with a ===.
Enhanced some documentation.

Commit:

-	13c8266a887b9cd116cfd9de2eff9ecb3f2ee090
+	309327252336de7f20ffb79588b1730d83cc96ea

Diff:

Revision 2 (+131)

Show changes

	djblets/static/djblets/js/utils/urls.es6.js
	djblets/static/djblets/js/utils/tests/urlsTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:


Added support for query strings already containing a leading ?.
A query string's ? is no longer added for empty objects or arrays.
Reordered some unit tests.

Commit:

-	309327252336de7f20ffb79588b1730d83cc96ea
+	2af6d5842f6d51d1619c39a557b0858c2c54553b

Diff:

Revision 3 (+182)

Show changes

	djblets/static/djblets/js/utils/urls.es6.js
	djblets/static/djblets/js/utils/tests/urlsTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Made the leading # for anchors optional as well.

Commit:

-	2af6d5842f6d51d1619c39a557b0858c2c54553b
+	dcc628b229f1966ef0b8ea2a0ef76ab0cb3491b4

Diff:

Revision 4 (+198)

Show changes

	djblets/static/djblets/js/utils/urls.es6.js
	djblets/static/djblets/js/utils/tests/urlsTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

djblets/static/djblets/js/utils/urls.es6.js (Diff revision 4)
The issue has been resolved. Show all issues
```
typo: "Build an" -> "Build and"
```

Status: Closed (submitted)

Change Summary:

Pushed to release-1.0.x (2f611e1)