flake8
passed.
JSHint
passed.
Review Request #9714 — Created March 1, 2018 and submitted
Information | |
---|---|
david | |
Review Board | |
release-4.0.x | |
42eba68... | |
Reviewers | |
reviewboard | |
This change moves us over to the latest versions of jQuery and
jquery.form. This was relatively painless, with only a few changes being
necessary:
$(func)
or $(document).ready(func)
now always invoke their callbacks$.browser
is gone.$.fn.load
used to do two things (one loaded stuff, the other$.fn.on
.$.fn.andSelf
has been removed, in favor of $.fn.addBack
(whichI excluded the following reviewboard/static/lib/js changes:
reviewboard/static/lib/js/ui.autocomplete.js (Diff revision 1) |
---|
Why the parens and concatenation here? Looks like this was legacy from when there was a conditional in here?
reviewboard/static/rb/js/pages/models/pageManagerModel.js (Diff revision 1) |
---|
Can you switch to multi-line comments?
Apparently we really do need jquery to be included at the top of the document.
Commit: |
|
||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+48 -47)
|