Update to the latest jQuery version.

Review Request #9714 — Created March 1, 2018 and submitted

David Trowbridge
Review Board

This change moves us over to the latest versions of jQuery and
jquery.form. This was relatively painless, with only a few changes being

  • $(func) or $(document).ready(func) now always invoke their callbacks
    asynchronously, even when the DOM is already loaded. This interfered
    with one of the PageManager unit tests.
  • Our autocomplete fork had some manual checks for old Opera browsers which
    are obsolete, and didn't work now that $.browser is gone.
  • $.fn.load used to do two things (one loaded stuff, the other
    attached to the load event) and now only does one. We had one place
    that was using the removed behavior (the event), which has been
    changed to $.fn.on.
  • The naming scheme for the widget in element data changed in jQuery UI, so
    that the old data name "rbautocomplete" is now "uiRbautocomplete".
  • $.fn.andSelf has been removed, in favor of $.fn.addBack (which
    always existed, and did exactly the same thing).

I excluded the following reviewboard/static/lib/js changes:

  • (deleted) reviewboard/static/lib/js/jquery-1.11.1.min.js
  • (deleted) reviewboard/static/lib/js/jquery-1.11.1.min.map
  • (deleted) reviewboard/static/lib/js/jquery-1.8.2.min.js
  • (added) reviewboard/static/lib/js/jquery-3.3.1.js
  • (added) reviewboard/static/lib/js/jquery-3.3.1.min.js
  • (added) reviewboard/static/lib/js/jquery-3.3.1.min.map
  • (deleted) reviewboard/static/lib/js/jquery-migrate-1.2.1.min.js
  • (added) reviewboard/static/lib/js/jquery-ui-1.12.1.js
  • (added) reviewboard/static/lib/js/jquery-ui-1.12.1.min.js
  • (deleted) reviewboard/static/lib/js/jquery-ui-1.8.24.custom.min.js
  • (added) reviewboard/static/lib/js/jquery.form-4.2.2.js
  • (added) reviewboard/static/lib/js/jquery.form-4.2.2.min.js
  • (added) reviewboard/static/lib/js/jquery.form-4.2.2.min.map
  • (deleted) reviewboard/static/lib/js/jquery.form.js
  • Audited the codebase for anything that would have been problematic with
    deprecations and removals.
  • Ran js-tests.
  • Smoke tested the UI.
  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Christian Hammond
  2. Why the parens and concatenation here? Looks like this was legacy from when there was a conditional in here?

  3. Can you switch to multi-line comments?

David Trowbridge
David Trowbridge
Christian Hammond
  1. Ship It!
David Trowbridge
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (8b0a3b4)