Summary

Fix copying function annotations and keyword-only defaults on Python 3.

Review Request #9707 — Created Feb. 27, 2018 and submitted March 4, 2018, 10:38 p.m.

Information

Owner

chipx86

Repository

kgb

Branch

master

Bugs

Depends On

Commit

cbd4ceb...

Reviewers

Groups

kgb

People

Description

On Python 3, FunctionType's constructor never gained the ability to
specify annotations or defaults for keyword-only arguments. Fortunately,
these are pretty easy to copy over.

This change introduces a new _clone_function() that does the copying
work, simplifying the copying code we had in two places and adding
support for these missing bits of data.

Testing Done

Unit tests pass for all supported Python versions.

Issues

Description	From	Last Updated
E231 missing whitespace after ':'	reviewbot	Feb. 27, 2018, 4:09 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Feb. 27, 2018, 4:09 p.m.
E231 missing whitespace after ':'	reviewbot	Feb. 27, 2018, 4:09 p.m.
E231 missing whitespace after ':'	reviewbot	Feb. 27, 2018, 4:09 p.m.
E231 missing whitespace after ':'	reviewbot	Feb. 27, 2018, 4:09 p.m.
E231 missing whitespace after ':'	reviewbot	Feb. 27, 2018, 4:09 p.m.
E231 missing whitespace after ':'	reviewbot	Feb. 27, 2018, 4:09 p.m.
E231 missing whitespace after ':'	reviewbot	Feb. 27, 2018, 4:09 p.m.
E231 missing whitespace after ':'	reviewbot	Feb. 27, 2018, 4:09 p.m.
E231 missing whitespace after ':'	reviewbot	Feb. 27, 2018, 4:09 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Feb. 27, 2018, 4:11 p.m.

flake8 failed.

JSHint passed.

flake8

kgb/tests/py3/test_function_spy.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ':'
```
kgb/tests/py3/test_function_spy.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E999 SyntaxError: invalid syntax
```
kgb/tests/py3/test_function_spy.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ':'
```
kgb/tests/py3/test_function_spy.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ':'
```
kgb/tests/py3/test_function_spy.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ':'
```
kgb/tests/py3/test_function_spy.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ':'
```
kgb/tests/py3/test_function_spy.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ':'
```
kgb/tests/py3/test_function_spy.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ':'
```
kgb/tests/py3/test_function_spy.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ':'
```
kgb/tests/py3/test_function_spy.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ':'
```

Change Summary:

Fixed styling around annotations for function arguments.

Commit:

-	1ba328cd147fecf5b9c8e53061f41d7f0e2e0044
+	cbd4cebb6706496e75e784aff1f28fbf22414c81

Diff:

Revision 2 (+111 -13)

Show changes

	kgb/spies.py
	kgb/tests/py3/test_function_spy.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

kgb/tests/py3/test_function_spy.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (a40d38e)