Summary

Improve logging in Active Directory failures.

Review Request #9704 — Created Feb. 26, 2018 and submitted March 7, 2018, 11:07 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-3.0.x

Bugs

4658

Depends On

Commit

194c49d...

Reviewers

Groups

reviewboard

People

Description

This change adds the domain controller to various log messages in Active
Directory. In the case where there are multiple domain controllers
configured, the log messages would fail to indicate which server is
being used, which made things hard to debug.

This also adds an additional check for a missing ldap dependency.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
by the way.... this isn't working for me. https://hellosplat.com/s/beanbag/tickets/4658/	misery	March 1, 2018, 9:56 a.m.
Can you put parens around the tuple value list?	chipx86	March 1, 2018, 9:54 a.m.
**kwargs	chipx86	March 7, 2018, 11:07 a.m.

flake8 passed.

JSHint passed.

Ship it!

reviewboard/accounts/backends.py (Diff revision 1)
Show all issues
```
Can you put parens around the tuple value list?
```

reviewboard/accounts/backends.py (Diff revision 1)

Show all issues

by the way.... this isn't working for me.

https://hellosplat.com/s/beanbag/tickets/4658/

Description:

		This change adds the domain controller to various log messages in Active
		Directory. In the case where there are multiple domain controllers
		configured, the log messages would fail to indicate which server is
		being used, which made things hard to debug.
	+
	+	This also adds an additional check for a missing ldap dependency.