Improve logging in Active Directory failures.

Review Request #9704 — Created Feb. 26, 2018 and submitted

Information

Review Board
release-3.0.x
194c49d...

Reviewers

This change adds the domain controller to various log messages in Active
Directory. In the case where there are multiple domain controllers
configured, the log messages would fail to indicate which server is
being used, which made things hard to debug.

This also adds an additional check for a missing ldap dependency.

Ran unit tests.

Description From Last Updated

by the way.... this isn't working for me. https://hellosplat.com/s/beanbag/tickets/4658/

miserymisery

Can you put parens around the tuple value list?

chipx86chipx86

**kwargs

chipx86chipx86
chipx86
  1. 
      
  2. reviewboard/accounts/backends.py (Diff revision 1)
     
     
    Show all issues

    Can you put parens around the tuple value list?

  3. 
      
misery
  1. 
      
  2. reviewboard/accounts/backends.py (Diff revision 1)
     
     
     
     
     
     
    Show all issues

    by the way.... this isn't working for me.

    https://hellosplat.com/s/beanbag/tickets/4658/

  3. 
      
david
chipx86
  1. 
      
  2. reviewboard/accounts/backends.py (Diff revisions 1 - 2)
     
     
    Show all issues

    **kwargs

    1. And after this, Ship It.

  3. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.0.x (aac2336)