Review Request #9700 — Created Feb. 24, 2018 and updated
Task 3 for Rb-Gateway Webhooks feature: Adding webhook receivers in Review Board to close review requests when commits are posted.
Added html template for adding webhooks. Pretty much a copy-pate of
github.pywith some tweaks for rb-gateway-specific headers.
Along with r/9585, the webhook successfully returns and closes the review request.
| Description | From | Last Updated |
|---|---|---|
|
E231 missing whitespace after ',' |
 reviewbot
|
|
|
E501 line too long (88 > 79 characters) |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E501 line too long (83 > 79 characters) |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
F841 local variable 'plan' is assigned to but never used |
reviewbot
|
|
|
E501 line too long (82 > 79 characters) |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
W391 blank line at end of file |
reviewbot
|
|
|
F401 'reviewboard.hostingsvcs.hook_utils.get_git_branch_name' imported but unused |
reviewbot
|
|
|
E501 line too long (81 > 79 characters) |
reviewbot
|
|
|
E501 line too long (81 > 79 characters) |
reviewbot
|
|
|
E225 missing whitespace around operator |
reviewbot
|
|
|
E501 line too long (83 > 79 characters) |
reviewbot
|
|
|
E303 too many blank lines (2) |
reviewbot
|
|
|
F401 'reviewboard.hostingsvcs.hook_utils.get_git_branch_name' imported but unused |
reviewbot
|
|
|
E501 line too long (81 > 79 characters) |
reviewbot
|
|
|
E501 line too long (83 > 79 characters) |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
These should be grouped with the other django imports |
 david
|
|
|
This should come after the hostingsvcs.forms imports (alphabetical order) |
david
|
|
|
Add a period at the end of the docstring. |
david
|
|
|
There's an extra space between the """ and the start of the docstring. This also needs a period at the … |
david
|
|
|
This blank line can be removed. |
david
|
|
|
You can make a bystring with b'ABC123'. But what is ABC123? |
david
|
|
|
This blank line can go away. |
david
|
|
|
Docstrings should be in the imperative mood instead of passive ("Return" instead of "Returns"). This also needs Args and Returns … |
david
|
|
|
There's an extra space character an the end of this line. |
david
|
|
|
Can you indent the HTML 1 space instead of 8? |
david
|
|
|
Please wrap to 80 columns and add a period at the end. |
david
|
|
|
Perhaps this value could be stored in a constant somewhere? |
 jshephard
|
| reviewboard/hostingsvcs/rbgateway.py (Diff revision 1) |
|---|
| reviewboard/hostingsvcs/rbgateway.py (Diff revision 1) |
|---|
F841 local variable 'plan' is assigned to but never used
Working version of get_hook_instructions, and have webhook close review request
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+233) |
| reviewboard/hostingsvcs/rbgateway.py (Diff revision 2) |
|---|
F401 'reviewboard.hostingsvcs.hook_utils.get_git_branch_name' imported but unused
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+197) |
| reviewboard/hostingsvcs/rbgateway.py (Diff revision 3) |
|---|
F401 'reviewboard.hostingsvcs.hook_utils.get_git_branch_name' imported but unused
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+196) |
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 5 (+196) |
| reviewboard/hostingsvcs/rbgateway.py (Diff revision 5) |
|---|
These should be grouped with the other django imports
| reviewboard/hostingsvcs/rbgateway.py (Diff revision 5) |
|---|
This should come after the
hostingsvcs.formsimports (alphabetical order)
| reviewboard/hostingsvcs/rbgateway.py (Diff revision 5) |
|---|
There's an extra space between the """ and the start of the docstring. This also needs a period at the end.
| reviewboard/hostingsvcs/rbgateway.py (Diff revision 5) |
|---|
You can make a bystring with
b'ABC123'. But what is ABC123?
| reviewboard/hostingsvcs/rbgateway.py (Diff revision 5) |
|---|
Docstrings should be in the imperative mood instead of passive ("Return" instead of "Returns"). This also needs Args and Returns sections.
| reviewboard/templates/hostingsvcs/rbgateway/repo_hook_instructions.html (Diff revision 5) |
|---|
There's an extra space character an the end of this line.
| reviewboard/templates/hostingsvcs/rbgateway/repo_hook_instructions.html (Diff revision 5) |
|---|
Can you indent the HTML 1 space instead of 8?
| reviewboard/templates/hostingsvcs/rbgateway/repo_hook_instructions.html (Diff revision 5) |
|---|
Please wrap to 80 columns and add a period at the end.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 6 (+195 -1) |
| reviewboard/hostingsvcs/rbgateway.py (Diff revision 6) |
|---|
Perhaps this value could be stored in a constant somewhere?