Summary

Adding rb-gateway webhook and template for registering webhooks

Review Request #9700 — Created Feb. 24, 2018 and updated April 1, 2018, 11:35 a.m.

Information

Owner

floriecai

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

7ee90ab...

Reviewers

Groups

reviewboard, students

People

Description

Task 3 for Rb-Gateway Webhooks feature: Adding webhook receivers in Review Board to close review requests when commits are posted.

Added html template for adding webhooks. Pretty much a copy-pate of github.py with some tweaks for rb-gateway-specific headers.

Testing Done

Along with r/9585, the webhook successfully returns and closes the review request.

Files

Issues

Description	From	Last Updated
E231 missing whitespace after ','	reviewbot	March 26, 2018, 10:38 p.m.
E501 line too long (88 > 79 characters)	reviewbot	March 26, 2018, 10:38 p.m.
W293 blank line contains whitespace	reviewbot	March 26, 2018, 10:38 p.m.
W293 blank line contains whitespace	reviewbot	March 26, 2018, 10:38 p.m.
W291 trailing whitespace	reviewbot	March 26, 2018, 10:38 p.m.
E501 line too long (83 > 79 characters)	reviewbot	March 26, 2018, 10:38 p.m.
W293 blank line contains whitespace	reviewbot	March 26, 2018, 10:38 p.m.
F841 local variable 'plan' is assigned to but never used	reviewbot	March 26, 2018, 10:38 p.m.
E501 line too long (82 > 79 characters)	reviewbot	March 26, 2018, 10:38 p.m.
W293 blank line contains whitespace	reviewbot	March 26, 2018, 10:38 p.m.
W391 blank line at end of file	reviewbot	March 26, 2018, 10:38 p.m.
F401 'reviewboard.hostingsvcs.hook_utils.get_git_branch_name' imported but unused	reviewbot	March 25, 2018, 1:12 a.m.
E501 line too long (81 > 79 characters)	reviewbot	March 25, 2018, 1:12 a.m.
E501 line too long (81 > 79 characters)	reviewbot	March 25, 2018, 1:13 a.m.
E225 missing whitespace around operator	reviewbot	March 25, 2018, 1:13 a.m.
E501 line too long (83 > 79 characters)	reviewbot	March 25, 2018, 1:13 a.m.
E303 too many blank lines (2)	reviewbot	March 25, 2018, 1:14 a.m.
F401 'reviewboard.hostingsvcs.hook_utils.get_git_branch_name' imported but unused	reviewbot	March 25, 2018, 1:14 a.m.
E501 line too long (81 > 79 characters)	reviewbot	March 25, 2018, 1:14 a.m.
E501 line too long (83 > 79 characters)	reviewbot	March 25, 2018, 1:15 a.m.
W293 blank line contains whitespace	reviewbot	March 25, 2018, 1:15 a.m.
W293 blank line contains whitespace	reviewbot	March 25, 2018, 1:18 a.m.
These should be grouped with the other django imports	david	March 29, 2018, 11:54 p.m.
This should come after the hostingsvcs.forms imports (alphabetical order)	david	March 29, 2018, 11:55 p.m.
Add a period at the end of the docstring.	david	March 29, 2018, 11:55 p.m.
There's an extra space between the """ and the start of the docstring. This also needs a period at the …	david	March 29, 2018, 11:55 p.m.
This blank line can be removed.	david	March 29, 2018, 11:56 p.m.
You can make a bystring with b'ABC123'. But what is ABC123?	david	March 29, 2018, 11:57 p.m.
This blank line can go away.	david	March 29, 2018, 11:58 p.m.
Docstrings should be in the imperative mood instead of passive ("Return" instead of "Returns"). This also needs Args and Returns …	david	March 29, 2018, 11:57 p.m.
There's an extra space character an the end of this line.	david	March 29, 2018, 11:58 p.m.
Can you indent the HTML 1 space instead of 8?	david	March 29, 2018, 11:59 p.m.
Please wrap to 80 columns and add a period at the end.	david	March 30, 2018, midnight
Perhaps this value could be stored in a constant somewhere?	jshephard	April 1, 2018, 11:35 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/rbgateway.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/hostingsvcs/rbgateway.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (88 > 79 characters)
```
reviewboard/hostingsvcs/rbgateway.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/hostingsvcs/rbgateway.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/hostingsvcs/rbgateway.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
reviewboard/hostingsvcs/rbgateway.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (83 > 79 characters)
```
reviewboard/hostingsvcs/rbgateway.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/hostingsvcs/rbgateway.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F841 local variable 'plan' is assigned to but never used
```
reviewboard/hostingsvcs/rbgateway.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (82 > 79 characters)
```
reviewboard/hostingsvcs/rbgateway.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/hostingsvcs/rbgateway.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W391 blank line at end of file
```

Change Summary:

Working version of get_hook_instructions, and have webhook close review request

Commit:

305167c5c50b3c429167e35b6f2963fbe86ba662

e54087e8b727cf83c3a12621cf3dd1ae96f6a785

Diff:

Revision 2 (+233)

Show changes

	reviewboard/hostingsvcs/rbgateway.py
	reviewboard/templates/hostingsvcs/rbgateway/repo_hook_instructions.html

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/rbgateway.py (Diff revision 2)
The issue has been resolved. Show all issues
```
F401 'reviewboard.hostingsvcs.hook_utils.get_git_branch_name' imported but unused
```
reviewboard/hostingsvcs/rbgateway.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E501 line too long (81 > 79 characters)
```
reviewboard/hostingsvcs/rbgateway.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E501 line too long (81 > 79 characters)
```
reviewboard/hostingsvcs/rbgateway.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E225 missing whitespace around operator
```
reviewboard/hostingsvcs/rbgateway.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E501 line too long (83 > 79 characters)
```
reviewboard/hostingsvcs/rbgateway.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E303 too many blank lines (2)
```

Commit:

e54087e8b727cf83c3a12621cf3dd1ae96f6a785

7287d53545cdb0cdf568d24b06171abc85a3c186

Diff:

Revision 3 (+197)

Show changes

	reviewboard/hostingsvcs/rbgateway.py
	reviewboard/templates/hostingsvcs/rbgateway/repo_hook_instructions.html

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/rbgateway.py (Diff revision 3)
The issue has been resolved. Show all issues
```
F401 'reviewboard.hostingsvcs.hook_utils.get_git_branch_name' imported but unused
```
reviewboard/hostingsvcs/rbgateway.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E501 line too long (81 > 79 characters)
```
reviewboard/hostingsvcs/rbgateway.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E501 line too long (83 > 79 characters)
```
reviewboard/hostingsvcs/rbgateway.py (Diff revision 3)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```

Commit:

7287d53545cdb0cdf568d24b06171abc85a3c186

120488d5af2e65affcd23c699ef1a6a8cd9b6e62

Diff:

Revision 4 (+196)

Show changes

	reviewboard/hostingsvcs/rbgateway.py
	reviewboard/templates/hostingsvcs/rbgateway/repo_hook_instructions.html

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/rbgateway.py (Diff revision 4)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```

Commit:

120488d5af2e65affcd23c699ef1a6a8cd9b6e62

1eccb2f0ca98f3251521a72d90d05ec9b60f9dea

Diff:

Revision 5 (+196)

Show changes

	reviewboard/hostingsvcs/rbgateway.py
	reviewboard/templates/hostingsvcs/rbgateway/repo_hook_instructions.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Summary:: [WIP] Adding rb-gateway webhook and template for registering webhooks
Adding rb-gateway webhook and template for registering webhooks
Testing Done:: ~
None yet.
~
Along with r/9585, the webhook successfully returns and closes the review request.
Added Files:

reviewboard/hostingsvcs/rbgateway.py (Diff revision 5)
The issue has been resolved. Show all issues
```
These should be grouped with the other django imports
```
reviewboard/hostingsvcs/rbgateway.py (Diff revision 5)
The issue has been resolved. Show all issues
```
This should come after the hostingsvcs.forms imports (alphabetical order)
```
reviewboard/hostingsvcs/rbgateway.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Add a period at the end of the docstring.
```

reviewboard/hostingsvcs/rbgateway.py (Diff revision 5)

The issue has been resolved. Show all issues

There's an extra space between the """ and the start of the docstring. This also needs a period at the end.

reviewboard/hostingsvcs/rbgateway.py (Diff revision 5)
The issue has been resolved. Show all issues
```
This blank line can be removed.
```
reviewboard/hostingsvcs/rbgateway.py (Diff revision 5)
The issue has been resolved. Show all issues
```
You can make a bystring with b'ABC123'. But what is ABC123?
```
1. FL
  
  floriecai March 30, 2018, 12:02 a.m.
  It just an example secret associated with rb-gateway.
reviewboard/hostingsvcs/rbgateway.py (Diff revision 5)
The issue has been resolved. Show all issues
```
This blank line can go away.
```

reviewboard/hostingsvcs/rbgateway.py (Diff revision 5)

The issue has been resolved. Show all issues

Docstrings should be in the imperative mood instead of passive ("Return" instead of "Returns"). This also needs Args and Returns sections.

reviewboard/templates/hostingsvcs/rbgateway/repo_hook_instructions.html (Diff revision 5)
The issue has been resolved. Show all issues
```
There's an extra space character an the end of this line.
```

reviewboard/templates/hostingsvcs/rbgateway/repo_hook_instructions.html (Diff revision 5)

The issue has been resolved. Show all issues

Can you indent the HTML 1 space instead of 8?

reviewboard/templates/hostingsvcs/rbgateway/repo_hook_instructions.html (Diff revision 5)
The issue has been resolved. Show all issues
```
Please wrap to 80 columns and add a period at the end.
```

Commit:

1eccb2f0ca98f3251521a72d90d05ec9b60f9dea

7ee90ab2137fb6f4428c049819e2a53e0ea36d01

Diff:

Revision 6 (+195 -1)

Show changes

	reviewboard/hostingsvcs/rbgateway.py
	reviewboard/templates/hostingsvcs/rbgateway/repo_hook_instructions.html

Checks run (2 timed out)

flake8 timed out.

JSHint timed out.

Fix it!

reviewboard/hostingsvcs/rbgateway.py (Diff revision 6)
An issue was opened. Show all issues
```
Perhaps this value could be stored in a constant somewhere?
```

~		None yet.
	~	Along with r/9585, the webhook successfully returns and closes the review request.