[WIP] Get refactoring of LegacyTool, Tool, and Repository to pass all tests (hostingsvcs, webapi etc)

Review Request #9699 — Created Feb. 24, 2018 and discarded

Information

Review Board
master

Reviewers

Getting SCM tests refactoring to pass tests in hostingsvcs,
webapi and so on.

The new Tool model works, and does not inherit from models.Model.
Renamed usages of tool to _legacy_tool


 
Description From Last Updated

E501 line too long (89 > 79 characters)

reviewbotreviewbot

E501 line too long (89 > 79 characters)

reviewbotreviewbot

E501 line too long (91 > 79 characters)

reviewbotreviewbot

E501 line too long (89 > 79 characters)

reviewbotreviewbot

E501 line too long (91 > 79 characters)

reviewbotreviewbot

F401 'reviewboard.scmtools.models.Tool' imported but unused

reviewbotreviewbot

E501 line too long (84 > 79 characters)

reviewbotreviewbot

E501 line too long (84 > 79 characters)

reviewbotreviewbot

E501 line too long (80 > 79 characters)

reviewbotreviewbot

E501 line too long (80 > 79 characters)

reviewbotreviewbot

E501 line too long (80 > 79 characters)

reviewbotreviewbot

E501 line too long (84 > 79 characters)

reviewbotreviewbot

E501 line too long (84 > 79 characters)

reviewbotreviewbot

E501 line too long (84 > 79 characters)

reviewbotreviewbot

E501 line too long (84 > 79 characters)

reviewbotreviewbot

E501 line too long (86 > 79 characters)

reviewbotreviewbot

E501 line too long (86 > 79 characters)

reviewbotreviewbot

E501 line too long (84 > 79 characters)

reviewbotreviewbot

E501 line too long (84 > 79 characters)

reviewbotreviewbot

F401 'reviewboard.scmtools.models.Tool' imported but unused

reviewbotreviewbot

E501 line too long (83 > 79 characters)

reviewbotreviewbot

F401 'reviewboard.scmtools.service.get_scm_tools' imported but unused

reviewbotreviewbot

F401 'logging' imported but unused

reviewbotreviewbot

F401 'reviewboard.scmtools.models.Tool' imported but unused

reviewbotreviewbot

E501 line too long (88 > 79 characters)

reviewbotreviewbot

F401 'reviewboard.scmtools.models.Tool' imported but unused

reviewbotreviewbot

E501 line too long (85 > 79 characters)

reviewbotreviewbot

F401 'reviewboard.scmtools.models.Tool' imported but unused

reviewbotreviewbot

F401 'reviewboard.scmtools.models.Tool' imported but unused

reviewbotreviewbot

E501 line too long (91 > 79 characters)

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

JT
Review request changed
Status:
Discarded