Summary

[WIP] Get refactoring of LegacyTool, Tool, and Repository to pass all tests (hostingsvcs, webapi etc)

Review Request #9699 — Created Feb. 24, 2018 and discarded Feb. 24, 2018, 11:38 p.m.

Information

Owner

jtrang

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard, students

People

Description

Getting SCM tests refactoring to pass tests in hostingsvcs,
webapi and so on.

The new Tool model works, and does not inherit from models.Model.
Renamed usages of tool to _legacy_tool

Testing Done

Issues

Description	From	Last Updated
E501 line too long (89 > 79 characters)	reviewbot	Feb. 24, 2018, 6:12 p.m.
E501 line too long (89 > 79 characters)	reviewbot	Feb. 24, 2018, 6:12 p.m.
E501 line too long (91 > 79 characters)	reviewbot	Feb. 24, 2018, 6:12 p.m.
E501 line too long (89 > 79 characters)	reviewbot	Feb. 24, 2018, 6:12 p.m.
E501 line too long (91 > 79 characters)	reviewbot	Feb. 24, 2018, 6:12 p.m.
F401 'reviewboard.scmtools.models.Tool' imported but unused	reviewbot	Feb. 24, 2018, 6:12 p.m.
E501 line too long (84 > 79 characters)	reviewbot	Feb. 24, 2018, 6:12 p.m.
E501 line too long (84 > 79 characters)	reviewbot	Feb. 24, 2018, 6:12 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Feb. 24, 2018, 6:12 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Feb. 24, 2018, 6:12 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Feb. 24, 2018, 6:12 p.m.
E501 line too long (84 > 79 characters)	reviewbot	Feb. 24, 2018, 6:12 p.m.
E501 line too long (84 > 79 characters)	reviewbot	Feb. 24, 2018, 6:12 p.m.
E501 line too long (84 > 79 characters)	reviewbot	Feb. 24, 2018, 6:12 p.m.
E501 line too long (84 > 79 characters)	reviewbot	Feb. 24, 2018, 6:12 p.m.
E501 line too long (86 > 79 characters)	reviewbot	Feb. 24, 2018, 6:12 p.m.
E501 line too long (86 > 79 characters)	reviewbot	Feb. 24, 2018, 6:12 p.m.
E501 line too long (84 > 79 characters)	reviewbot	Feb. 24, 2018, 6:12 p.m.
E501 line too long (84 > 79 characters)	reviewbot	Feb. 24, 2018, 6:12 p.m.
F401 'reviewboard.scmtools.models.Tool' imported but unused	reviewbot	Feb. 24, 2018, 6:12 p.m.
E501 line too long (83 > 79 characters)	reviewbot	Feb. 24, 2018, 6:12 p.m.
F401 'reviewboard.scmtools.service.get_scm_tools' imported but unused	reviewbot	Feb. 24, 2018, 6:12 p.m.
F401 'logging' imported but unused	reviewbot	Feb. 24, 2018, 6:12 p.m.
F401 'reviewboard.scmtools.models.Tool' imported but unused	reviewbot	Feb. 24, 2018, 6:12 p.m.
E501 line too long (88 > 79 characters)	reviewbot	Feb. 24, 2018, 6:12 p.m.
F401 'reviewboard.scmtools.models.Tool' imported but unused	reviewbot	Feb. 24, 2018, 6:12 p.m.
E501 line too long (85 > 79 characters)	reviewbot	Feb. 24, 2018, 6:12 p.m.
F401 'reviewboard.scmtools.models.Tool' imported but unused	reviewbot	Feb. 24, 2018, 6:12 p.m.
F401 'reviewboard.scmtools.models.Tool' imported but unused	reviewbot	Feb. 24, 2018, 6:12 p.m.
E501 line too long (91 > 79 characters)	reviewbot	Feb. 24, 2018, 6:12 p.m.

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 36 failures.
```
reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (89 > 79 characters)
```
reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (89 > 79 characters)
```
reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (91 > 79 characters)
```
reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (89 > 79 characters)
```
reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (91 > 79 characters)
```
reviewboard/hostingsvcs/tests/test_beanstalk.py (Diff revision 1)
An issue was opened. Show all issues
```
F401 'reviewboard.scmtools.models.Tool' imported but unused
```
reviewboard/hostingsvcs/tests/test_beanstalk.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (84 > 79 characters)
```
reviewboard/hostingsvcs/tests/test_beanstalk.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (84 > 79 characters)
```
reviewboard/hostingsvcs/tests/test_bitbucket.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/hostingsvcs/tests/test_bitbucket.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/hostingsvcs/tests/test_bitbucket.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/hostingsvcs/tests/test_bitbucket.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (84 > 79 characters)
```
reviewboard/hostingsvcs/tests/test_bitbucket.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (84 > 79 characters)
```
reviewboard/hostingsvcs/tests/test_codebasehq.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (84 > 79 characters)
```
reviewboard/hostingsvcs/tests/test_codebasehq.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (84 > 79 characters)
```
reviewboard/hostingsvcs/tests/test_kiln.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (86 > 79 characters)
```
reviewboard/hostingsvcs/tests/test_kiln.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (86 > 79 characters)
```
reviewboard/hostingsvcs/tests/test_unfuddle.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (84 > 79 characters)
```
reviewboard/hostingsvcs/tests/test_unfuddle.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (84 > 79 characters)
```
reviewboard/scmtools/forms.py (Diff revision 1)
An issue was opened. Show all issues
```
F401 'reviewboard.scmtools.models.Tool' imported but unused
```
reviewboard/scmtools/forms.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (83 > 79 characters)
```
reviewboard/scmtools/models.py (Diff revision 1)
An issue was opened. Show all issues
```
F401 'reviewboard.scmtools.service.get_scm_tools' imported but unused
```
reviewboard/scmtools/tests/test_bazaar.py (Diff revision 1)
An issue was opened. Show all issues
```
F401 'logging' imported but unused
```
reviewboard/scmtools/tests/test_bazaar.py (Diff revision 1)
An issue was opened. Show all issues
```
F401 'reviewboard.scmtools.models.Tool' imported but unused
```
reviewboard/scmtools/tests/test_bazaar.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (88 > 79 characters)
```
reviewboard/scmtools/tests/test_cvs.py (Diff revision 1)
An issue was opened. Show all issues
```
F401 'reviewboard.scmtools.models.Tool' imported but unused
```
reviewboard/scmtools/tests/test_cvs.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (85 > 79 characters)
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
An issue was opened. Show all issues
```
F401 'reviewboard.scmtools.models.Tool' imported but unused
```
reviewboard/scmtools/tests/test_hg.py (Diff revision 1)
An issue was opened. Show all issues
```
F401 'reviewboard.scmtools.models.Tool' imported but unused
```
reviewboard/scmtools/tests/test_hg.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (91 > 79 characters)
```

Status:: Discarded