flake8
passed.
JSHint
failed.
JSHint
-
lib/frontend/redux/modules/loggedIn.js (Diff revision 1) -
lib/frontend/redux/modules/userType.js (Diff revision 1) Col: 62 Regular parameters should not come after default parameters.
Move "loggedIn" and "userType" values into the Redux store.
Review Request #9692 — Created Feb. 25, 2018 and submitted
We have a couple values which are initialized from the session and are
initially added to the window namespace. These were then passed through
either the model or accessed directly. This change moves them into the
Redux store, where they can be accessed by container components.
Loaded things and verified that everything still looked correct.
| Description | From | Last Updated |
|---|---|---|
|
Shouldn't this be part of the preloadedState, technically speaking? |
 brennie
|
|
|
Col: 55 Regular parameters should not come after default parameters. |
 reviewbot
|
|
|
Col: 62 Regular parameters should not come after default parameters. |
reviewbot
|
|
|
Likewise this too? |
brennie
|
|
|
Col: 42 Regular parameters should not come after default parameters. |
reviewbot
|
-
-
lib/frontend/redux/modules/loggedIn.js (Diff revision 1) Shouldn't this be part of the preloadedState, technically speaking?
-
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+64 -36) |
Checks run (1 failed, 1 succeeded)
flake8
passed.
JSHint
failed.
JSHint
-
lib/frontend/redux/configure-store.js (Diff revision 2) Col: 42 Regular parameters should not come after default parameters.