Move "loggedIn" and "userType" values into the Redux store.

Review Request #9692 — Created Feb. 25, 2018 and submitted

david
student-sonar
master
0df2467...
student-sonar

We have a couple values which are initialized from the session and are
initially added to the window namespace. These were then passed through
either the model or accessed directly. This change moves them into the
Redux store, where they can be accessed by container components.

Loaded things and verified that everything still looked correct.

Description From Last Updated

Shouldn't this be part of the preloadedState, technically speaking?

brenniebrennie

Col: 55 Regular parameters should not come after default parameters.

reviewbotreviewbot

Col: 62 Regular parameters should not come after default parameters.

reviewbotreviewbot

Likewise this too?

brenniebrennie

Col: 42 Regular parameters should not come after default parameters.

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

brennie
  1. 
      
  2. lib/frontend/redux/modules/loggedIn.js (Diff revision 1)
     
     

    Shouldn't this be part of the preloadedState, technically speaking?

  3. lib/frontend/redux/modules/userType.js (Diff revision 1)
     
     

    Likewise this too?

  4. 
      
david
Review request changed

Checks run (1 failed, 1 succeeded)

flake8 passed.
JSHint failed.

JSHint

david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (6c39994)
Loading...