• 
      

    Move "loggedIn" and "userType" values into the Redux store.

    Review Request #9692 — Created Feb. 25, 2018 and submitted

    Information

    student-sonar
    master
    0df2467...

    Reviewers

    We have a couple values which are initialized from the session and are
    initially added to the window namespace. These were then passed through
    either the model or accessed directly. This change moves them into the
    Redux store, where they can be accessed by container components.

    Loaded things and verified that everything still looked correct.

    Description From Last Updated

    Shouldn't this be part of the preloadedState, technically speaking?

    brenniebrennie

    Col: 55 Regular parameters should not come after default parameters.

    reviewbotreviewbot

    Col: 62 Regular parameters should not come after default parameters.

    reviewbotreviewbot

    Likewise this too?

    brenniebrennie

    Col: 42 Regular parameters should not come after default parameters.

    reviewbotreviewbot
    Checks run (1 failed, 1 succeeded)
    flake8 passed.
    JSHint failed.

    JSHint

    brennie
    1. 
        
    2. lib/frontend/redux/modules/loggedIn.js (Diff revision 1)
       
       
      Show all issues

      Shouldn't this be part of the preloadedState, technically speaking?

    3. lib/frontend/redux/modules/userType.js (Diff revision 1)
       
       
      Show all issues

      Likewise this too?

    4. 
        
    david
    Review request changed
    Commit:
    152a12cca232fa5b33792a7656b85d64a91e9a45
    0df24673965d9bc02770c9d08fa9485d63acf762

    Checks run (1 failed, 1 succeeded)

    flake8 passed.
    JSHint failed.

    JSHint

    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (6c39994)