Summary

Fix some webapi-lint issues.

Review Request #9686 — Created Feb. 20, 2018 and submitted March 15, 2018, 4:19 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

1211950...

Reviewers

Groups

reviewboard

People

Description

This change fixes up a handful of errors detected by webapi-lint. The
bulk of the problems were misformatted docstrings and misnamed things,
but there were a few missing tests or decorators. None of these actually
present as security issues.

Testing Done


Ran webapi-lint.
Ran unit tests.

Issues

Description	From	Last Updated
Can you :py:func: this?	chipx86	Feb. 24, 2018, 9:37 a.m.
No indentation here.	chipx86	Feb. 24, 2018, 9:37 a.m.
Alphabetical order.	chipx86	Feb. 24, 2018, 9:38 a.m.
No indentation here.	chipx86	Feb. 24, 2018, 9:38 a.m.
No indentation here.	chipx86	Feb. 24, 2018, 9:38 a.m.
Should be reviewboard.extensions.base.Extension.	chipx86	March 15, 2018, 4:16 p.m.
This needs the full module path.	chipx86	March 15, 2018, 4:16 p.m.

flake8 passed.

JSHint passed.

Change Summary:

Fix one more issue (not caught by webapi-lint) that I juist happened to notice while the tests were running.

Commit:

43b517764e33101c12a547b728e45245c057d327

d042c39c4a0a332d0f610f1ab9ef9a59260cec48

Diff:

Revision 2 (+125 -14)

Show changes

	reviewboard/webapi/resources/diff_context.py
	reviewboard/webapi/resources/extension.py
	reviewboard/webapi/resources/review_request.py
	reviewboard/webapi/tests/mixins.py
	reviewboard/webapi/tests/test_diff_context.py
	reviewboard/webapi/tests/test_filediff.py
	reviewboard/webapi/tests/test_oauth_app.py
	reviewboard/webapi/tests/test_oauth_token.py
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/webapi/resources/extension.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can you :py:func: this?
```
reviewboard/webapi/tests/test_diff_context.py (Diff revision 2)
The issue has been resolved. Show all issues
```
No indentation here.
```
reviewboard/webapi/tests/test_filediff.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Alphabetical order.
```
reviewboard/webapi/tests/test_filediff.py (Diff revision 2)
The issue has been resolved. Show all issues
```
No indentation here.
```
reviewboard/webapi/tests/test_filediff.py (Diff revision 2)
The issue has been resolved. Show all issues
```
No indentation here.
```

Branch:

release-3.0.x

master

Commit:

d042c39c4a0a332d0f610f1ab9ef9a59260cec48

c7455a240504d81df40e1a38b7ee537fe310a7fe

Diff:

Revision 3 (+125 -14)

Show changes

	reviewboard/webapi/resources/diff_context.py
	reviewboard/webapi/resources/extension.py
	reviewboard/webapi/resources/review_request.py
	reviewboard/webapi/tests/mixins.py
	reviewboard/webapi/tests/test_diff_context.py
	reviewboard/webapi/tests/test_filediff.py
	reviewboard/webapi/tests/test_oauth_app.py
	reviewboard/webapi/tests/test_oauth_token.py
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/webapi/resources/extension.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Should be reviewboard.extensions.base.Extension.
```
reviewboard/webapi/resources/extension.py (Diff revision 3)
The issue has been resolved. Show all issues
```
This needs the full module path.
```

Branch:

master

release-3.0.x

Commit:

c7455a240504d81df40e1a38b7ee537fe310a7fe

1211950330053587be517d0fcddf253fbc27d9f1

Diff:

Revision 4 (+126 -14)

Show changes

	reviewboard/webapi/resources/diff_context.py
	reviewboard/webapi/resources/extension.py
	reviewboard/webapi/resources/review_request.py
	reviewboard/webapi/tests/mixins.py
	reviewboard/webapi/tests/test_diff_context.py
	reviewboard/webapi/tests/test_filediff.py
	reviewboard/webapi/tests/test_oauth_app.py
	reviewboard/webapi/tests/test_oauth_token.py
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (866fb19)