Fix some webapi-lint issues.

Review Request #9686 — Created Feb. 20, 2018 and submitted

Information

Review Board
release-3.0.x
1211950...

Reviewers

This change fixes up a handful of errors detected by webapi-lint. The
bulk of the problems were misformatted docstrings and misnamed things,
but there were a few missing tests or decorators. None of these actually
present as security issues.

  • Ran webapi-lint.
  • Ran unit tests.
Description From Last Updated

Can you :py:func: this?

chipx86chipx86

No indentation here.

chipx86chipx86

Alphabetical order.

chipx86chipx86

No indentation here.

chipx86chipx86

No indentation here.

chipx86chipx86

Should be reviewboard.extensions.base.Extension.

chipx86chipx86

This needs the full module path.

chipx86chipx86
david
chipx86
  1. 
      
  2. Can you :py:func: this?

  3. No indentation here.

  4. reviewboard/webapi/tests/test_filediff.py (Diff revision 2)
     
     
     
     

    Alphabetical order.

  5. reviewboard/webapi/tests/test_filediff.py (Diff revision 2)
     
     
     

    No indentation here.

  6. reviewboard/webapi/tests/test_filediff.py (Diff revision 2)
     
     
     

    No indentation here.

  7. 
      
david
chipx86
  1. 
      
  2. Should be reviewboard.extensions.base.Extension.

  3. This needs the full module path.

  4. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (866fb19)
Loading...