Add review bot tool for uncrustify formatting

Review Request #9664 — Created Feb. 17, 2018 and updated

misery
ReviewBot
release-1.0.x
c2ae8a2...
reviewbot
This review bot tool will check if all files are
correctly formatted. Otherwise it will print
a unified diff as an issue to show the formatting
problem.

Created a review request with incorrect formatting
and saw that the bot marks the correct lines.

  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

misery
  1. 
      
  2. Work in progress...

    How to use a "ChoiceField" for "uncrustify, astyle and clang-format" if only some tools are installed and checked by check_dependencies?

    Also... this works with "Comment on unmodified code" only. Looks like Review._is_modified needs to adjusted here. But how?

    1. Works with "Comment on unmodified code" now. But not on "whitespaces changes only" stuff as RB means that it is not "modified".

  3. 
      
misery
Review request changed

Commit:

-e492095c4a99fbef5991ccac46b2e3f7e0fa061b
+e71a21a9f62c294da603ba54489733df4fc900ac

Diff:

Revision 2 (+142)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

misery
misery
misery
misery
Review request changed

Commit:

-d76acb808d31ff591dbf9dc71c25b6937c27b39e
+c2ae8a263dcce0b3e772a4f240c3d49887622403

Diff:

Revision 5 (+165)

Show changes

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
david
  1. Instead of including the diffs as comments, how about making it show the "new" version only?

    Something like:


    Formatting is incorrect. Use:

    new code here
    

  2. 
      
Loading...