[WIP] Get refactoring of LegacyTool, Tool, and Repository to pass all tests

Review Request #9663 — Created Feb. 17, 2018 and discarded — Latest diff uploaded

Information

Review Board
master

Reviewers

The code from 2 weeks ago provided an outline of what needed to be
done to refactor the Tool, LegacyTool and the Repository models.
This week, I worked on getting the refactor to pass all test suites.

  • Renamed usages of tool to _legacy_tool
  • Rename entrypoint names to match the names in the tools themselves
  • Use scmtool_name instead of tool field in tests

Code is still WIP, for example how to handle renaming in
RepositoryForm.


 
setup.py
docs/manual/fixtures/initial_data.json
reviewboard/admin/fixtures/initial_evolution_schema.json
reviewboard/diffviewer/tests/test_forms.py
reviewboard/hostingsvcs/tests/test_assembla.py
reviewboard/hostingsvcs/tests/test_beanstalk.py
reviewboard/hostingsvcs/tests/test_bitbucket.py
reviewboard/hostingsvcs/tests/test_codebasehq.py
reviewboard/hostingsvcs/tests/test_hosting_service_auth_form.py
reviewboard/hostingsvcs/tests/test_kiln.py
reviewboard/hostingsvcs/tests/test_unfuddle.py
reviewboard/reviews/management/commands/fill-database.py
reviewboard/scmtools/admin.py
reviewboard/scmtools/conditions.py
reviewboard/scmtools/forms.py
reviewboard/scmtools/models.py
reviewboard/scmtools/service.py
reviewboard/scmtools/evolutions/__init__.py
reviewboard/scmtools/evolutions/repository_refactor_scm_tool_registration.py
reviewboard/scmtools/fixtures/test_scmtools.json
This diff has been split across 2 pages: 1 2 >
Loading...