Summary

[WIP] Get refactoring of LegacyTool, Tool, and Repository to pass all tests

Review Request #9663 — Created Feb. 17, 2018 and discarded March 3, 2018, 10:16 p.m.

Information

Owner

jtrang

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard, students

People

Description

The code from 2 weeks ago provided an outline of what needed to be
done to refactor the Tool, LegacyTool and the Repository models.
This week, I worked on getting the refactor to pass all test suites.

Renamed usages of tool to _legacy_tool
Rename entrypoint names to match the names in the tools themselves
Use scmtool_name instead of tool field in tests

Code is still WIP, for example how to handle renaming in
RepositoryForm.

Testing Done

Issues

Description	From	Last Updated
F401 'reviewboard.scmtools.service.get_scm_tools' imported but unused	reviewbot	Feb. 17, 2018, 3:37 p.m.
E501 line too long (85 > 79 characters)	reviewbot	Feb. 17, 2018, 3:37 p.m.
F401 'logging' imported but unused	reviewbot	Feb. 17, 2018, 3:37 p.m.
E501 line too long (82 > 79 characters)	reviewbot	Feb. 17, 2018, 3:37 p.m.
E501 line too long (85 > 79 characters)	reviewbot	Feb. 17, 2018, 3:37 p.m.
E501 line too long (84 > 79 characters)	reviewbot	Feb. 17, 2018, 3:37 p.m.
E501 line too long (84 > 79 characters)	reviewbot	Feb. 17, 2018, 3:37 p.m.
F401 'reviewboard.scmtools.models.LegacyTool' imported but unused	reviewbot	Feb. 17, 2018, 3:37 p.m.
E501 line too long (86 > 79 characters)	reviewbot	Feb. 17, 2018, 3:37 p.m.
F401 'reviewboard.scmtools.models.LegacyTool' imported but unused	reviewbot	Feb. 24, 2018, 11:36 p.m.
F401 'reviewboard.scmtools.models.LegacyTool' imported but unused	reviewbot	Feb. 24, 2018, 11:36 p.m.
F401 'reviewboard.scmtools.models.Tool' imported but unused	reviewbot	Feb. 24, 2018, 11:36 p.m.
F401 'reviewboard.scmtools.models.LegacyTool' imported but unused	reviewbot	Feb. 24, 2018, 11:36 p.m.
F401 'reviewboard.scmtools.models.LegacyTool' imported but unused	reviewbot	Feb. 24, 2018, 11:36 p.m.
F401 'reviewboard.scmtools.models.LegacyTool' imported but unused	reviewbot	Feb. 24, 2018, 11:36 p.m.
F401 'reviewboard.scmtools.models.LegacyTool' imported but unused	reviewbot	Feb. 24, 2018, 11:36 p.m.
F401 'reviewboard.scmtools.models.Tool' imported but unused	reviewbot	Feb. 24, 2018, 11:36 p.m.
E501 line too long (83 > 79 characters)	reviewbot	Feb. 24, 2018, 11:36 p.m.
F401 'reviewboard.scmtools.service.get_scm_tools' imported but unused	reviewbot	Feb. 24, 2018, 11:36 p.m.
F401 'logging' imported but unused	reviewbot	Feb. 24, 2018, 11:36 p.m.
F401 'reviewboard.scmtools.models.LegacyTool' imported but unused	reviewbot	Feb. 24, 2018, 11:36 p.m.
F401 'reviewboard.scmtools.models.Tool' imported but unused	reviewbot	Feb. 24, 2018, 11:36 p.m.
F401 'reviewboard.scmtools.models.LegacyTool' imported but unused	reviewbot	Feb. 24, 2018, 11:36 p.m.
F401 'reviewboard.scmtools.models.Tool' imported but unused	reviewbot	Feb. 24, 2018, 11:36 p.m.
F401 'reviewboard.scmtools.models.Tool' imported but unused	reviewbot	Feb. 24, 2018, 11:36 p.m.
F401 'reviewboard.scmtools.models.LegacyTool' imported but unused	reviewbot	Feb. 24, 2018, 11:36 p.m.
F401 'reviewboard.scmtools.models.LegacyTool' imported but unused	reviewbot	Feb. 24, 2018, 11:36 p.m.
F401 'reviewboard.scmtools.models.Tool' imported but unused	reviewbot	Feb. 24, 2018, 11:36 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/scmtools/models.py (Diff revision 1)
An issue was opened. Show all issues
```
F401 'reviewboard.scmtools.service.get_scm_tools' imported but unused
```
reviewboard/scmtools/models.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (85 > 79 characters)
```
reviewboard/scmtools/tests/test_bazaar.py (Diff revision 1)
An issue was opened. Show all issues
```
F401 'logging' imported but unused
```
reviewboard/scmtools/tests/test_bazaar.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (82 > 79 characters)
```
reviewboard/scmtools/tests/test_hg.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (85 > 79 characters)
```
reviewboard/scmtools/tests/test_perforce.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (84 > 79 characters)
```
reviewboard/scmtools/tests/test_perforce.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (84 > 79 characters)
```
reviewboard/scmtools/tests/test_svn.py (Diff revision 1)
An issue was opened. Show all issues
```
F401 'reviewboard.scmtools.models.LegacyTool' imported but unused
```
reviewboard/scmtools/tests/test_svn.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (86 > 79 characters)
```

Summary:

-	[WIP] Get refactoring of LegacyTool, Tool, and Repository to pass scmtools/tests
+	[WIP] Get refactoring of LegacyTool, Tool, and Repository to pass all tests

Description:

~		The code from last week provided an outline of what needed to be done to
~		refactor the Tool, LegacyTool and the Repository models. This week, I
~		worked on getting the refactor to pass the tests in `scmtools/tests`
	~	The code from 2 weeks ago provided an outline of what needed to be
	~	done to refactor the Tool, LegacyTool and the Repository models.
	~	This week, I worked on getting the refactor to pass all test suites.

		Renamed usages of `tool` to `_legacy_tool`
		Rename entrypoint names to match the names in the tools themselves
~		Use classmethod to create a Tool
	~	Use scmtool_name instead of tool field in tests

~		Code is still WIP, many tests from `RepositoryForm` are still failing
	~	Code is still WIP, for example how to handle renaming in
	+	RepositoryForm.

Testing Done:

Existing tests in scmtools/tests

Commit:

-	d39c72654af3916b7294e39a9cdfb1ce43ad38e9
+	f45fa5b01253dda89c9abe089a171948a0e73da5

Diff:

Revision 2 (+3013 -2739)

Show changes

	setup.py
	docs/manual/fixtures/initial_data.json
	reviewboard/admin/fixtures/initial_evolution_schema.json
	reviewboard/diffviewer/tests/test_forms.py
	reviewboard/hostingsvcs/tests/test_assembla.py
	reviewboard/hostingsvcs/tests/test_beanstalk.py
	reviewboard/hostingsvcs/tests/test_bitbucket.py
	reviewboard/hostingsvcs/tests/test_codebasehq.py
	26 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 2)
An issue was opened. Show all issues
```
F401 'reviewboard.scmtools.models.LegacyTool' imported but unused
```
reviewboard/hostingsvcs/tests/test_beanstalk.py (Diff revision 2)
An issue was opened. Show all issues
```
F401 'reviewboard.scmtools.models.LegacyTool' imported but unused
```
reviewboard/hostingsvcs/tests/test_beanstalk.py (Diff revision 2)
An issue was opened. Show all issues
```
F401 'reviewboard.scmtools.models.Tool' imported but unused
```
reviewboard/hostingsvcs/tests/test_bitbucket.py (Diff revision 2)
An issue was opened. Show all issues
```
F401 'reviewboard.scmtools.models.LegacyTool' imported but unused
```
reviewboard/hostingsvcs/tests/test_codebasehq.py (Diff revision 2)
An issue was opened. Show all issues
```
F401 'reviewboard.scmtools.models.LegacyTool' imported but unused
```
reviewboard/hostingsvcs/tests/test_kiln.py (Diff revision 2)
An issue was opened. Show all issues
```
F401 'reviewboard.scmtools.models.LegacyTool' imported but unused
```
reviewboard/hostingsvcs/tests/test_unfuddle.py (Diff revision 2)
An issue was opened. Show all issues
```
F401 'reviewboard.scmtools.models.LegacyTool' imported but unused
```
reviewboard/scmtools/forms.py (Diff revision 2)
An issue was opened. Show all issues
```
F401 'reviewboard.scmtools.models.Tool' imported but unused
```
reviewboard/scmtools/forms.py (Diff revision 2)
An issue was opened. Show all issues
```
E501 line too long (83 > 79 characters)
```
reviewboard/scmtools/models.py (Diff revision 2)
An issue was opened. Show all issues
```
F401 'reviewboard.scmtools.service.get_scm_tools' imported but unused
```
reviewboard/scmtools/tests/test_bazaar.py (Diff revision 2)
An issue was opened. Show all issues
```
F401 'logging' imported but unused
```
reviewboard/scmtools/tests/test_bazaar.py (Diff revision 2)
An issue was opened. Show all issues
```
F401 'reviewboard.scmtools.models.LegacyTool' imported but unused
```
reviewboard/scmtools/tests/test_bazaar.py (Diff revision 2)
An issue was opened. Show all issues
```
F401 'reviewboard.scmtools.models.Tool' imported but unused
```
reviewboard/scmtools/tests/test_cvs.py (Diff revision 2)
An issue was opened. Show all issues
```
F401 'reviewboard.scmtools.models.LegacyTool' imported but unused
```
reviewboard/scmtools/tests/test_cvs.py (Diff revision 2)
An issue was opened. Show all issues
```
F401 'reviewboard.scmtools.models.Tool' imported but unused
```
reviewboard/scmtools/tests/test_git.py (Diff revision 2)
An issue was opened. Show all issues
```
F401 'reviewboard.scmtools.models.Tool' imported but unused
```
reviewboard/scmtools/tests/test_git.py (Diff revision 2)
An issue was opened. Show all issues
```
F401 'reviewboard.scmtools.models.LegacyTool' imported but unused
```
reviewboard/scmtools/tests/test_hg.py (Diff revision 2)
An issue was opened. Show all issues
```
F401 'reviewboard.scmtools.models.LegacyTool' imported but unused
```
reviewboard/scmtools/tests/test_hg.py (Diff revision 2)
An issue was opened. Show all issues
```
F401 'reviewboard.scmtools.models.Tool' imported but unused
```

Review Board 7.0 alpha 0 (dev)

[WIP] Get refactoring of LegacyTool, Tool, and Repository to pass all tests

Information

Reviewers

flake8

Summary:

Description:

Testing Done:

Commit:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Status: Discarded