[WIP] Get refactoring of LegacyTool, Tool, and Repository to pass all tests
Review Request #9663 — Created Feb. 17, 2018 and discarded — Latest diff uploaded
The code from 2 weeks ago provided an outline of what needed to be
done to refactor the Tool, LegacyTool and the Repository models.
This week, I worked on getting the refactor to pass all test suites.
- Renamed usages of
toolto_legacy_tool - Rename entrypoint names to match the names in the tools themselves
- Use scmtool_name instead of tool field in tests
Code is still WIP, for example how to handle renaming in
RepositoryForm.
Changes between revision 1 and 2
orig
1
2
| docs/manual/fixtures/initial_data.json |
|---|
| reviewboard/admin/fixtures/initial_evolution_schema.json |
|---|
| reviewboard/diffviewer/tests/test_forms.py |
|---|
| reviewboard/hostingsvcs/tests/test_assembla.py |
|---|
| reviewboard/hostingsvcs/tests/test_beanstalk.py |
|---|
| reviewboard/hostingsvcs/tests/test_bitbucket.py |
|---|
| reviewboard/hostingsvcs/tests/test_codebasehq.py |
|---|
| reviewboard/hostingsvcs/tests/test_hosting_service_auth_form.py |
|---|
| reviewboard/hostingsvcs/tests/test_kiln.py |
|---|
| reviewboard/hostingsvcs/tests/test_unfuddle.py |
|---|
| reviewboard/reviews/management/commands/fill-database.py |
|---|
| reviewboard/scmtools/admin.py |
|---|
| reviewboard/scmtools/conditions.py |
|---|
| reviewboard/scmtools/forms.py |
|---|
| reviewboard/scmtools/models.py |
|---|
| reviewboard/scmtools/fixtures/test_scmtools.json |
|---|
| reviewboard/scmtools/fixtures/vmware.json |
|---|
| reviewboard/scmtools/management/commands/registerscmtools.py |
|---|
| reviewboard/scmtools/tests/test_bazaar.py |
|---|
| reviewboard/scmtools/tests/test_cvs.py |
|---|
| reviewboard/scmtools/tests/test_git.py |
|---|
| reviewboard/scmtools/tests/test_hg.py |
|---|
| reviewboard/scmtools/tests/test_perforce.py |
|---|
| reviewboard/scmtools/tests/test_policy.py |
|---|
| reviewboard/scmtools/tests/test_repository.py |
|---|
| reviewboard/scmtools/tests/test_repository_form.py |
|---|
| reviewboard/scmtools/tests/test_svn.py |
|---|
| reviewboard/testing/testcase.py |
|---|
| reviewboard/webapi/tests/test_repository.py |
|---|