[WIP] Get refactoring of LegacyTool, Tool, and Repository to pass all tests
Review Request #9663 — Created Feb. 17, 2018 and discarded — Latest diff uploaded
The code from 2 weeks ago provided an outline of what needed to be
done to refactor the Tool, LegacyTool and the Repository models.
This week, I worked on getting the refactor to pass all test suites.
- Renamed usages of
toolto_legacy_tool - Rename entrypoint names to match the names in the tools themselves
- Use scmtool_name instead of tool field in tests
Code is still WIP, for example how to handle renaming in
RepositoryForm.
Diff Revision 1
This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.
orig
1
2
| setup.py |
|---|
| reviewboard/scmtools/models.py |
|---|
| reviewboard/scmtools/service.py |
|---|
| reviewboard/scmtools/evolutions/__init__.py |
|---|
| reviewboard/scmtools/evolutions/repository_refactor_scm_tool_registration.py |
|---|
| reviewboard/scmtools/tests/test_bazaar.py |
|---|
| reviewboard/scmtools/tests/test_cvs.py |
|---|
| reviewboard/scmtools/tests/test_git.py |
|---|
| reviewboard/scmtools/tests/test_hg.py |
|---|
| reviewboard/scmtools/tests/test_perforce.py |
|---|
| reviewboard/scmtools/tests/test_registration.py |
|---|
| reviewboard/scmtools/tests/test_svn.py |
|---|
| reviewboard/testing/testcase.py |
|---|