flake8
failed.
JSHint
passed.
flake8
-
rbtools/clients/plastic.py (Diff revision 1)
Audit RBTools files for unicode correctness.
Review Request #9644 — Created Feb. 15, 2018 and submitted
This change is the result of going through the RBTools implementation
(especially the clients) and checking all string usage to make sure that
we keep filenames as unicode (encoding/decoding to the filesystem
encoding when necessary) and diffs as bytes.
- Ran unit tests on Python 2.7 and 3.6.
- Smoke tested basic functionality on a few of the more common tools.
| Description | From | Last Updated |
|---|---|---|
|
E501 line too long (81 > 79 characters) |
 reviewbot
|
|
|
Do we really want to be encoding using the filesystem encoding? Seems we'd want to keep things sane for Review … |
 chipx86
|
|
|
This needs to use %. Comma isn't appropriate here. ValueError() will end up with a message of ('%s" is a … |
chipx86
|
|
|
F401 'sys' imported but unused |
reviewbot
|
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+217 -147) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
rbtools/clients/perforce.py (Diff revision 2) Do we really want to be encoding using the filesystem encoding? Seems we'd want to keep things sane for Review Board and ensure we're using UTF-8 wherever possible.
On a Mac,
sys.getfilesystemencoding()isutf-8, so it'd appear to work for us, but if the encoding was something else entirely, I think we'd end up with some badly broken diffs.This applies to all diff building.
-
rbtools/clients/perforce.py (Diff revision 2) This needs to use
%. Comma isn't appropriate here.ValueError()will end up with a message of('%s" is a symlink, '<depot path here>')
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+207 -146) |
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+206 -146) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.