flake8
-
djblets/configforms/tests.py (Diff revision 1) Show all issues
Review Request #9618 — Created Feb. 10, 2018 and submitted
When config pages were moved from Review Board to Djblets, the
ConfigPageForm.profile
attribute remained. This was never used in
Djblets, and withUser.get_profile()
no longer being a thing in Django
itself, it doesn't make sense to have this here.This is now deprecated. Instead of setting it automatically in the
constructor, it's now a dynamic property that warns when accessed.
Subclasses are advised to fetch their own concept of a profile
themselves.A unit test was added to test the warning.
Unit tests pass.
Removed an unused import.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+59 -1) |
Split up the tests, now that we have more than one suite.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+79 -1) |