• 
      

    Deprecate ConfigPageForm.profile.

    Review Request #9618 — Created Feb. 10, 2018 and submitted

    Information

    Djblets
    master
    37c5e40...

    Reviewers

    When config pages were moved from Review Board to Djblets, the
    ConfigPageForm.profile attribute remained. This was never used in
    Djblets, and with User.get_profile() no longer being a thing in Django
    itself, it doesn't make sense to have this here.

    This is now deprecated. Instead of setting it automatically in the
    constructor, it's now a dynamic property that warns when accessed.
    Subclasses are advised to fetch their own concept of a profile
    themselves.

    A unit test was added to test the warning.

    Unit tests pass.

    Description From Last Updated

    F401 'django.forms' imported but unused

    reviewbotreviewbot

    File docstring?

    daviddavid
    Checks run (1 failed, 1 succeeded)
    flake8 failed.
    JSHint passed.

    flake8

    chipx86
    chipx86
    david
    1. 
        
    2. Show all issues

      File docstring?

    3. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (df1534b)