Summary

Support application/x-javascript for the text review UI

Review Request #9611 — Created Feb. 10, 2018 and submitted Feb. 15, 2018, 3:18 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Commit

e9a4ce9...

Reviewers

Groups

reviewboard

People

Description

JavaScript files seem to have mimetype application/x-javascript when
uploaded instead of the old text/javascript. This patch makes
JavaScript files uploaded as attachments viewable and reviewable again.

Testing Done

Uploaded a JavaScript attachment and saw it was detected as
application/x-javascript. With this patch I was able to review it

flake8 passed.

JSHint passed.

Testing Done:

~		Uploaded a JavaScript attachment and saw it was detected as `application/x-javascript`. With this patch I was able to review it
	~	Uploaded a JavaScript attachment and saw it was detected as
	+	`application/x-javascript`. With this patch I was able to review it

Commit:

f239147f0340d0baac15af2e386f727446ad58ab

e9a4ce92b2ba57f1c53764ba10b8df92a00960f8

Diff:

Revision 2 (+8 -2)

Show changes

	reviewboard/attachments/mimetypes.py
	reviewboard/reviews/ui/text.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (194413b)