Don't reserve space for review headers that don't exist.

Review Request #9610 - Created Feb. 9, 2018 and submitted

David Trowbridge
Review Board
release-3.0.x
1a74f50...
reviewboard

If a review is published without any header text, we still show a
"Comment" button there (where "Reply" would be if the header existed).
In this case, we had a bunch of extra padding around the empty header
element, which was creating a pretty ugly blank space. To fix this, I've
added an extra class in the case that the header text doesn't exist, and
removed the padding for that class.

Published a review with comments but no header text. Saw that the
"Comment" button was now positioned in a reasonable location, rather
than with a ton of whitespace above it.

Loading file attachments...

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Barret Rennie
  1. 
      
  2. Screenshots?

  3. 
      
David Trowbridge
Christian Hammond
  1. Ship It!
  2. 
      
David Trowbridge
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (48f6728)
Loading...