Summary

Split diffviewer models into multiple files

Review Request #9597 — Created Feb. 7, 2018 and submitted Feb. 7, 2018, 10:46 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Commit

776363f...

Reviewers

Groups

reviewboard

People

Description

The diffviewer/models.py file was getting quite large (~750 lines) and
is going to be growing due to some new model additions for DVCS support.
It was about time it got cleaned up.

This change also cleans up some documentation to bring it in line with
our current standards.

Testing Done

Ran unit tests

Issues

Description	From	Last Updated
I didn't review this change before it went in :( I was going to ask if you could rename diff_set.py …	chipx86	Feb. 23, 2018, 11:06 p.m.
W391 blank line at end of file	reviewbot	Feb. 7, 2018, 2:42 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/diffviewer/models/diff_set.py (Diff revision 1)
Show all issues
```
W391 blank line at end of file
```

Commit:

-	b7fc3c0cd5f8f4eb604dfb6efb8fbb4e50403eb0
+	776363fafca4bb532046ca40dc26db5f58eb8943

Diff:

Revision 2 (+419 -287)

Show changes

	reviewboard/diffviewer/models/__init__.py
	reviewboard/diffviewer/models/diff_set.py
	reviewboard/diffviewer/models/diff_set_history.py
	reviewboard/diffviewer/models.py
	reviewboard/diffviewer/models/legacy_file_diff_data.py
	reviewboard/diffviewer/models/raw_file_diff_data.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (0a42896)

Fix it!

Show all issues

I didn't review this change before it went in :( I was going to ask if you could rename diff_set.py to diffset.py, since the latter is the standard lowercase spelling for this.