Add review bot tool for regex
Review Request #9594 — Created Feb. 6, 2018 and discarded
Sometimes there are some things that are not allowed in source code. It is the simplest way to just match those strings by a regular expression. Like a forbidden or deprecated include in C++ or just a simple TODO in a comment.
Configured two lines with regex.
Added a file with matching strings and saw that
both regex are found.
Testing Done: |
|
|||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
|||||||||||||||
Diff: |
Revision 2 (+106) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+106) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+106) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 5 (+111) |
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
-
bot/reviewbot/tools/regex.py (Diff revision 5) Show all issues -
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 6 (+111) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 7 (+112) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 8 (+112) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.