• 
      

    Add review bot tool for regex

    Review Request #9594 — Created Feb. 6, 2018 and discarded

    Information

    ReviewBot
    release-1.0.x

    Reviewers

    Sometimes there are some things that are not
    allowed in source code. It is the simplest way
    to just match those strings by a regular expression.
    
    Like a forbidden or deprecated include in C++ or
    just a simple TODO in a comment.

    Configured two lines with regex.
    Added a file with matching strings and saw that
    both regex are found.

    Description From Last Updated

    E999 SyntaxError: EOL while scanning string literal

    reviewbotreviewbot

    E131 continuation line unaligned for hanging indent

    reviewbotreviewbot
    misery
    misery
    misery
    misery
    Review request changed
    Commit:
    b5aef39d8c7675003afd0e6ed1834c0dd6ecdcb7
    f8c042e8425431b7afbd22b95989c5e0aef31e9b

    Checks run (1 failed, 1 succeeded)

    flake8 failed.
    JSHint passed.

    flake8

    misery
    misery
    misery
    david
    1. After thinking it over, I don't think this is something we're going to include in Review Bot itself. However, because of the entry-points mechanism, you can ship your own package that registers this tool and then Review Bot will discover it and make it available.

      1. Ok, added my package: https://pypi.org/project/rbExtendedBots/ ... https://github.com/misery/ExtendedBots/

    2. 
        
    david
    Review request changed
    Status:
    Discarded