Summary

Adds additional conditions to provide more options for matching reviews

Review Request #9586 — Created Feb. 5, 2018 and submitted Sept. 25, 2018, 11:24 a.m.

Information

Owner

sholl

Repository

Review Board

Branch

master

Bugs

4641

Depends On

Commit

fd94cbd...

Reviewers

Groups

reviewboard

People

Description

This enhancement allows for more control of review request matching with Integrations.

Provides the ability to match against one or more assigned reviewers or participants.

Testing Done

Tested locally with Slack integration.

Added unit tests.

Issues

Description	From	Last Updated
Could you add some tests for these choices in reviewboard/reviews/tests/test_conditions.py?	david	July 2, 2018, 11:46 a.m.
E128 continuation line under-indented for visual indent	reviewbot	Feb. 5, 2018, 9:16 a.m.
E128 continuation line under-indented for visual indent	reviewbot	Feb. 5, 2018, 9:16 a.m.
E128 continuation line under-indented for visual indent	reviewbot	Feb. 5, 2018, 9:16 a.m.
E128 continuation line under-indented for visual indent	reviewbot	Feb. 5, 2018, 9:16 a.m.
You can do: **kwargs (dict, unused): Unused keyword arguments. and our doc processor will understand that.	david	July 2, 2018, 6:02 a.m.
This should be list of django.contrib.auth.models.User	david	July 2, 2018, 6:02 a.m.
You can do: **kwargs (dict, unused): Unused keyword arguments. and our doc processor will understand that.	david	July 2, 2018, 6:02 a.m.
This should be list of django.contrib.auth.models.User	david	July 2, 2018, 6:03 a.m.
E501 line too long (83 > 79 characters)	reviewbot	July 2, 2018, noon
E501 line too long (83 > 79 characters)	reviewbot	July 2, 2018, noon
E501 line too long (95 > 79 characters)	reviewbot	July 2, 2018, noon
E501 line too long (95 > 79 characters)	reviewbot	July 2, 2018, noon
E501 line too long (95 > 79 characters)	reviewbot	July 2, 2018, noon
E501 line too long (95 > 79 characters)	reviewbot	July 2, 2018, noon
E501 line too long (107 > 79 characters)	reviewbot	July 2, 2018, noon
E501 line too long (107 > 79 characters)	reviewbot	July 2, 2018, noon
E501 line too long (107 > 79 characters)	reviewbot	July 2, 2018, noon
E501 line too long (83 > 79 characters)	reviewbot	July 2, 2018, noon
E501 line too long (83 > 79 characters)	reviewbot	July 2, 2018, noon
E501 line too long (83 > 79 characters)	reviewbot	July 2, 2018, noon
E501 line too long (95 > 79 characters)	reviewbot	July 2, 2018, noon
E501 line too long (95 > 79 characters)	reviewbot	July 2, 2018, 12:01 p.m.
E501 line too long (107 > 79 characters)	reviewbot	July 2, 2018, 12:01 p.m.
E501 line too long (107 > 79 characters)	reviewbot	July 2, 2018, 12:01 p.m.
E501 line too long (107 > 79 characters)	reviewbot	July 2, 2018, 12:01 p.m.
E501 line too long (83 > 79 characters)	reviewbot	July 2, 2018, 12:01 p.m.
E501 line too long (80 > 79 characters)	reviewbot	July 2, 2018, 12:01 p.m.
E501 line too long (86 > 79 characters)	reviewbot	July 2, 2018, 12:01 p.m.
E501 line too long (86 > 79 characters)	reviewbot	July 2, 2018, 12:01 p.m.
E501 line too long (86 > 79 characters)	reviewbot	July 2, 2018, 12:01 p.m.
E501 line too long (86 > 79 characters)	reviewbot	July 2, 2018, 12:01 p.m.
E501 line too long (86 > 79 characters)	reviewbot	July 2, 2018, 12:01 p.m.
E501 line too long (86 > 79 characters)	reviewbot	July 2, 2018, 12:01 p.m.
W291 trailing whitespace	reviewbot	July 2, 2018, 12:01 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	July 2, 2018, 12:02 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	July 2, 2018, 12:02 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	July 2, 2018, 12:03 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	July 2, 2018, 12:03 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	July 2, 2018, 12:03 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	July 2, 2018, 12:03 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	July 2, 2018, 12:03 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	July 2, 2018, 12:03 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	July 2, 2018, 12:03 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	July 2, 2018, 12:03 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	July 2, 2018, 12:03 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	July 2, 2018, 12:03 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	July 2, 2018, 12:03 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	July 2, 2018, 12:03 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	July 2, 2018, 12:03 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	July 2, 2018, 12:03 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	July 2, 2018, 12:03 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	July 2, 2018, 12:03 p.m.
W291 trailing whitespace	reviewbot	July 2, 2018, 12:03 p.m.
W291 trailing whitespace	reviewbot	July 2, 2018, 12:03 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/conditions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/reviews/conditions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/reviews/conditions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/reviews/conditions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```

Change Summary:

Fix indentation style issues.

Diff:

Revision 2 (+64)

Show changes

reviewboard/reviews/conditions.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

What's the status of this? Last update was almost 5 months ago.

Our team wants to use the Review Bot extension, but not being able to choose "Reviewer" as a condition for when a bot runs is pretty painful.

sholl June 29, 2018, 8:58 a.m.

Joushua,
I am not sure why this is not getting merged in. As you mention, this was submitted a long time and it's a pretty simple change. Perhaps if some users comment on the associated ticket to show interest it will get taken care of.

In order to use this functionality, I just applied the patch to my installed version of ReviewBoard. It's easy to do since it's editable python code. Just find the reviews/conditions.py file and add the necessary lines. On CentOS/RH for example, the file is at /usr/lib64/python2.7/site-packages/reviewboard/reviews/conditions.py. Note that there are multiple conditions.py files, the one that needs to be patched is under reviews/

jcannon June 29, 2018, 9:04 a.m.

I patched it on my demo server where we're trying out bots and it works like a charm.

We'd feel much more comfortable with a local patch knowing at least that the change was accepted by Review Board.

david June 29, 2018, 3:19 p.m.
```
Sorry, we've just been very busy.
```

The issue has been resolved. Show all issues

Could you add some tests for these choices in reviewboard/reviews/tests/test_conditions.py?

sholl July 20, 2018, 7:35 a.m.

David,

I have added some unit tests and resolved all the issues here. Can we get this moved along now?

Thanks!

reviewboard/reviews/conditions.py (Diff revision 2)

The issue has been resolved. Show all issues

You can do:

**kwargs (dict, unused):
    Unused keyword arguments.

and our doc processor will understand that.

reviewboard/reviews/conditions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This should be list of django.contrib.auth.models.User
```

reviewboard/reviews/conditions.py (Diff revision 2)

The issue has been resolved. Show all issues

You can do:

**kwargs (dict, unused):
    Unused keyword arguments.

and our doc processor will understand that.

reviewboard/reviews/conditions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This should be list of django.contrib.auth.models.User
```

Change Summary:

Fix documentation issues.

Branch:

+	master

Commit:

+	4fcfe9503f0f2a9b081fb35251d78ce480ddf1e6

Diff:

Revision 3 (+64)

Show changes

reviewboard/reviews/conditions.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Add unit tests.

Testing Done:

		Tested locally with Slack integration.
	+
	+	Added unit tests.

Commit:

-	4fcfe9503f0f2a9b081fb35251d78ce480ddf1e6
+	73dde5093fbce134fef8402579be932a7f666603

Diff:

Revision 4 (+379 -1)

Show changes

	reviewboard/reviews/conditions.py
	reviewboard/reviews/tests/test_conditions.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/tests/test_conditions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (83 > 79 characters)
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (83 > 79 characters)
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (95 > 79 characters)
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (95 > 79 characters)
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (95 > 79 characters)
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (95 > 79 characters)
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (107 > 79 characters)
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (107 > 79 characters)
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (107 > 79 characters)
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (83 > 79 characters)
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (83 > 79 characters)
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (83 > 79 characters)
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (95 > 79 characters)
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (95 > 79 characters)
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (107 > 79 characters)
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (107 > 79 characters)
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (107 > 79 characters)
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (83 > 79 characters)
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (86 > 79 characters)
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (86 > 79 characters)
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (86 > 79 characters)
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (86 > 79 characters)
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (86 > 79 characters)
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (86 > 79 characters)
```

Change Summary:

Fix formatting issues.

Commit:

-	73dde5093fbce134fef8402579be932a7f666603
+	3b9ff249e595b0355ed800327b6bc0b08566640f

Diff:

Revision 5 (+429 -1)

Show changes

	reviewboard/reviews/conditions.py
	reviewboard/reviews/tests/test_conditions.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/tests/test_conditions.py (Diff revision 5)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 5)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
reviewboard/reviews/tests/test_conditions.py (Diff revision 5)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```

Change Summary:

Fix formatting issues.

Commit:

-	3b9ff249e595b0355ed800327b6bc0b08566640f
+	fd94cbd8d3b85d684a06c3c174892cb2d4d418d1

Diff:

Revision 6 (+429 -1)

Show changes

	reviewboard/reviews/conditions.py
	reviewboard/reviews/tests/test_conditions.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (3f16e77)