flake8
passed.
JSHint
passed.
[WIP] Add unit tests for registering and unregistering SCM tools using API in scmtools/service.py
Review Request #9573 — Created Feb. 2, 2018 and discarded
Basic unit tests for registering and unregistering SCM tools have been
added inscmtools/tests/test_registration.py. This tests the API
created last week inscmtools/service.py.Additionally, any code for adding/removing URL patterns (copied from
hosting services) has been removed fromscmtools/service.py, as it
does not seem to apply.
Unit tests in
scmtools/tests/test_registration.py:
- Testing SCMTool registration.
- Testing SCMTool unregistration.
- Testing SCMTool unregistration when the registry is empty.
- Testing SCMTool get a registered SCMTool.
JT
- Description:
-
Basic unit tests for registering and unregistering SCM tools have been
added in scmtools/tests/test_registration.py. This tests the APIcreated last week in scmtools/service.py.Additionally, any code for adding/removing URL patterns (copied from
~ hosting services)has been removed from scmtools/service.py, as it~ hosting services) has been removed from scmtools/service.py, as itdoes not seem to apply.
JT
- Description:
-
Basic unit tests for registering and unregistering SCM tools have been
added in scmtools/tests/test_registration.py. This tests the APIcreated last week in scmtools/service.py.Additionally, any code for adding/removing URL patterns (copied from
hosting services) has been removed from scmtools/service.py, as itdoes not seem to apply. + + Now, when running
./contrib/internal/prepare-dev.py, I am able to+ see the following output: + + + + Registering new SCM Tool Subversion+ (reviewboard.scmtools.svn.SVNTool) in database
+ Registering new SCM Tool Git (reviewboard.scmtools.git.GitTool)
+ in database
+ Registering new SCM Tool Bazaar (reviewboard.scmtools.bzr.BZRTool)
+ in database
+ Registering new SCM Tool CVS (reviewboard.scmtools.cvs.CVSTool)
+ in database
+ Registering new SCM Tool Perforce
+ (reviewboard.scmtools.perforce.PerforceTool) in database
+ Registering new SCM Tool Plastic SCM
+ (reviewboard.scmtools.plastic.PlasticTool) in database
+ Registering new SCM Tool ClearCase
+ (reviewboard.scmtools.clearcase.ClearCaseTool) in database
+ Registering new SCM Tool Mercurial (reviewboard.scmtools.hg.HgTool)
+ in database
+
JT
- Description:
-
Basic unit tests for registering and unregistering SCM tools have been
added in scmtools/tests/test_registration.py. This tests the APIcreated last week in scmtools/service.py.Additionally, any code for adding/removing URL patterns (copied from
hosting services) has been removed from scmtools/service.py, as itdoes not seem to apply. - - Now, when running
./contrib/internal/prepare-dev.py, I am able to- see the following output: - - - - Registering new SCM Tool Subversion- (reviewboard.scmtools.svn.SVNTool) in database
- Registering new SCM Tool Git (reviewboard.scmtools.git.GitTool)
- in database
- Registering new SCM Tool Bazaar (reviewboard.scmtools.bzr.BZRTool)
- in database
- Registering new SCM Tool CVS (reviewboard.scmtools.cvs.CVSTool)
- in database
- Registering new SCM Tool Perforce
- (reviewboard.scmtools.perforce.PerforceTool) in database
- Registering new SCM Tool Plastic SCM
- (reviewboard.scmtools.plastic.PlasticTool) in database
- Registering new SCM Tool ClearCase
- (reviewboard.scmtools.clearcase.ClearCaseTool) in database
- Registering new SCM Tool Mercurial (reviewboard.scmtools.hg.HgTool)
- in database
-