Summary:

Only look for AD group membership when actually needed

Review Request #956 — Created Aug. 8, 2009 and discarded

Information
Owner:	pronik
Repository:	Review Board SVN (deprecated)
Branch:	trunk
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

This patch changes the Active Directory functionality a bit: now the group membership is only checked when an actual restriction on groups is active. If not, not groups are retrieved.

This can also be considered a workaround for issue 1267

Testing Done

Patched and implemented at my workplace

Expand All
Collapse All

pronik Aug. 27, 2009, 3:11 a.m.

Hi Christian, if this patch is otherwise ok, could you please commit it with your changes below? I've upgraded my copy to git and can't produce any subversion diff anymore... :(

/trunk/reviewboard/accounts/backends.py (Diff revision 1)

Blank line before the conditional.

Also, should be:

if required_group not in group_names:

/trunk/reviewboard/accounts/backends.py (Diff revision 1)
```
Should keep this blank line.
```