Only look for AD group membership when actually needed

Review Request #956 — Created Aug. 8, 2009 and discarded

Information

Review Board SVN (deprecated)
trunk

Reviewers

This patch changes the Active Directory functionality a bit: now the group membership is only checked when an actual restriction on groups is active. If not, not groups are retrieved.

This can also be considered a workaround for issue 1267
Patched and implemented at my workplace
chipx86
  1. 
      
    1. Hi Christian, if this patch is otherwise ok, could you please commit it with your changes below? I've upgraded my copy to git and can't produce any subversion diff anymore... :(
  2. /trunk/reviewboard/accounts/backends.py (Diff revision 1)
     
     
     
    Blank line before the conditional.
    
    Also, should be:
    
    if required_group not in group_names:
  3. /trunk/reviewboard/accounts/backends.py (Diff revision 1)
     
     
     
     
    Should keep this blank line.
  4.