Summary

[WIP] Create Javascript extension resource

Review Request #9547 — Created Jan. 28, 2018 and discarded Oct. 26, 2021, 12:14 p.m.

Information

Owner

jque

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard, students

People

Description

Code drop for Jan 28th meeting:
* Notes and commented out code to allow users to manage Javascript extensions.

Code drop for Feb 4th meeting:
* Added account page for JavaScript extensions with place holder form
* Added stubs for JavaScript extensions resource

Code drop for Feb 11th meeting:
* JS extension form accepts URL and adds to user profile
* JS extension page lists user's extensions

Code drop for Feb 18th meeting:
* First take implementation for JS extension API resource

Code drop for Feb 25th meeting:
* Clean up of JS extension resource
* Created template for testing

Code drop for Mar 4th meeting:
* Finish implementation of GET and POST methods for JS extension list resource

Code drop for Mar 11th meeting:
* Finish implementation of JS extension view
* Attempt to implement GET and DELETE js extension

Code drop for Mar 18th meeting:
* Finish implementing GET and DELETE js extension item resource

Code drop for Mar 25th meeting:
* Testing for js extension list & item resource
* Adding permission checks

Code drop for April 1st:
* Passed all tests for js extension list & item resource
* Attempt to load JS extension information in front-end

Testing Done

Existing tests still working.

Tests for user JavaScript extension list & item resource passing.
- List: GET, POST
- Item: GET, PUT, DELETE

Issues

Description	From	Last Updated
E303 too many blank lines (3)	reviewbot	Jan. 28, 2018, 12:16 a.m.
E265 block comment should start with '# '	reviewbot	Jan. 28, 2018, 12:16 a.m.
E265 block comment should start with '# '	reviewbot	Feb. 3, 2018, 11:47 p.m.
E303 too many blank lines (2)	reviewbot	Feb. 3, 2018, 11:47 p.m.
F401 'djblets.extensions.manager.ExtensionManager as DjbletsExtensionManager' imported but unused	reviewbot	Feb. 3, 2018, 11:47 p.m.
E303 too many blank lines (2)	reviewbot	Feb. 3, 2018, 11:47 p.m.
E305 expected 2 blank lines after class or function definition, found 1	reviewbot	Feb. 3, 2018, 11:47 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Feb. 3, 2018, 11:47 p.m.
E265 block comment should start with '# '	reviewbot	Feb. 3, 2018, 11:47 p.m.
E265 block comment should start with '# '	reviewbot	Feb. 3, 2018, 11:47 p.m.
F401 'json' imported but unused	reviewbot	Feb. 10, 2018, 10:26 p.m.
E303 too many blank lines (3)	reviewbot	Feb. 10, 2018, 10:26 p.m.
E203 whitespace before ':'	reviewbot	Feb. 10, 2018, 10:26 p.m.
F401 'reviewboard.extensions.base.ExtensionManager' imported but unused	reviewbot	Feb. 10, 2018, 10:26 p.m.
F401 'djblets.extensions.manager.ExtensionManager as DjbletsExtensionManager' imported but unused	reviewbot	Feb. 10, 2018, 10:26 p.m.
E303 too many blank lines (2)	reviewbot	Feb. 10, 2018, 10:26 p.m.
E265 block comment should start with '# '	reviewbot	Feb. 10, 2018, 10:26 p.m.
E303 too many blank lines (3)	reviewbot	Feb. 18, 2018, 5:50 p.m.
E203 whitespace before ':'	reviewbot	Feb. 18, 2018, 5:50 p.m.
F401 'djblets.extensions.resources.ExtensionResource as DjbletsExtensionResource' imported but unused	reviewbot	Feb. 18, 2018, 5:50 p.m.
F401 'djblets.webapi.decorators.webapi_request_fields' imported but unused	reviewbot	Feb. 18, 2018, 5:50 p.m.
F401 'reviewboard.webapi.base.RBResourceMixin' imported but unused	reviewbot	Feb. 18, 2018, 5:50 p.m.
E265 block comment should start with '# '	reviewbot	Feb. 18, 2018, 5:50 p.m.
E303 too many blank lines (3)	reviewbot	Feb. 25, 2018, 10:30 a.m.
E203 whitespace before ':'	reviewbot	Feb. 25, 2018, 10:30 a.m.
E265 block comment should start with '# '	reviewbot	Feb. 25, 2018, 10:30 a.m.
F401 'djblets.extensions.resources.ExtensionResource as DjbletsExtensionResource' imported but unused	reviewbot	Feb. 25, 2018, 10:30 a.m.
F401 'reviewboard.webapi.base.RBResourceMixin' imported but unused	reviewbot	Feb. 25, 2018, 10:30 a.m.
E265 block comment should start with '# '	reviewbot	Feb. 25, 2018, 10:30 a.m.
E231 missing whitespace after ','	reviewbot	Feb. 25, 2018, 10:30 a.m.
E303 too many blank lines (2)	reviewbot	Feb. 25, 2018, 10:30 a.m.
E265 block comment should start with '# '	reviewbot	Feb. 25, 2018, 10:30 a.m.
E127 continuation line over-indented for visual indent	reviewbot	Feb. 25, 2018, 10:30 a.m.
W292 no newline at end of file	reviewbot	Feb. 25, 2018, 10:30 a.m.
E303 too many blank lines (3)	reviewbot	March 11, 2018, 11:09 a.m.
E203 whitespace before ':'	reviewbot	March 11, 2018, 11:09 a.m.
E265 block comment should start with '# '	reviewbot	March 11, 2018, 11:09 a.m.
F401 'djblets.extensions.resources.ExtensionResource as DjbletsExtensionResource' imported but unused	reviewbot	March 11, 2018, 11:09 a.m.
F401 'djblets.util.decorators.augment_method_from' imported but unused	reviewbot	March 11, 2018, 11:09 a.m.
E402 module level import not at top of file	reviewbot	March 11, 2018, 11:09 a.m.
E402 module level import not at top of file	reviewbot	March 11, 2018, 11:09 a.m.
E402 module level import not at top of file	reviewbot	March 11, 2018, 11:09 a.m.
E402 module level import not at top of file	reviewbot	March 11, 2018, 11:09 a.m.
E402 module level import not at top of file	reviewbot	March 11, 2018, 11:09 a.m.
F401 'reviewboard.webapi.base.RBResourceMixin' imported but unused	reviewbot	March 11, 2018, 11:09 a.m.
E402 module level import not at top of file	reviewbot	March 11, 2018, 11:09 a.m.
E402 module level import not at top of file	reviewbot	March 11, 2018, 11:09 a.m.
E302 expected 2 blank lines, found 1	reviewbot	March 11, 2018, 11:09 a.m.
E302 expected 2 blank lines, found 1	reviewbot	March 11, 2018, 11:09 a.m.
E265 block comment should start with '# '	reviewbot	March 11, 2018, 11:09 a.m.
E231 missing whitespace after ','	reviewbot	March 11, 2018, 11:09 a.m.
E303 too many blank lines (2)	reviewbot	March 11, 2018, 11:09 a.m.
E303 too many blank lines (2)	reviewbot	March 11, 2018, 11:09 a.m.
W391 blank line at end of file	reviewbot	March 11, 2018, 11:09 a.m.
F401 'reviewboard.site.models.LocalSite' imported but unused	reviewbot	March 11, 2018, 11:09 a.m.
F401 'reviewboard.webapi.tests.urls.get_user_js_extension_item_url' imported but unused	reviewbot	March 11, 2018, 11:09 a.m.
W291 trailing whitespace	reviewbot	March 11, 2018, 11:09 a.m.
W292 no newline at end of file	reviewbot	March 11, 2018, 11:09 a.m.
E127 continuation line over-indented for visual indent	reviewbot	March 11, 2018, 11:09 a.m.
W292 no newline at end of file	reviewbot	March 11, 2018, 11:09 a.m.
E303 too many blank lines (3)	reviewbot	March 12, 2018, 2:34 p.m.
E203 whitespace before ':'	reviewbot	March 12, 2018, 2:34 p.m.
E265 block comment should start with '# '	reviewbot	March 12, 2018, 2:34 p.m.
F401 'djblets.extensions.resources.ExtensionResource as DjbletsExtensionResource' imported but unused	reviewbot	March 12, 2018, 2:34 p.m.
F401 'djblets.util.decorators.augment_method_from' imported but unused	reviewbot	March 12, 2018, 2:34 p.m.
E402 module level import not at top of file	reviewbot	March 12, 2018, 2:34 p.m.
E402 module level import not at top of file	reviewbot	March 12, 2018, 2:34 p.m.
F401 'djblets.webapi.errors.DUPLICATE_ITEM' imported but unused	reviewbot	March 12, 2018, 2:34 p.m.
F401 'djblets.webapi.errors.INVALID_FORM_DATA' imported but unused	reviewbot	March 12, 2018, 2:34 p.m.
E402 module level import not at top of file	reviewbot	March 12, 2018, 2:34 p.m.
E402 module level import not at top of file	reviewbot	March 12, 2018, 2:34 p.m.
E402 module level import not at top of file	reviewbot	March 12, 2018, 2:34 p.m.
F401 'reviewboard.webapi.base.RBResourceMixin' imported but unused	reviewbot	March 12, 2018, 2:34 p.m.
E402 module level import not at top of file	reviewbot	March 12, 2018, 2:34 p.m.
E402 module level import not at top of file	reviewbot	March 12, 2018, 2:34 p.m.
E265 block comment should start with '# '	reviewbot	March 12, 2018, 2:34 p.m.
E302 expected 2 blank lines, found 1	reviewbot	March 12, 2018, 2:34 p.m.
E265 block comment should start with '# '	reviewbot	March 12, 2018, 2:34 p.m.
E231 missing whitespace after ','	reviewbot	March 12, 2018, 2:34 p.m.
E303 too many blank lines (2)	reviewbot	March 12, 2018, 2:34 p.m.
E265 block comment should start with '# '	reviewbot	March 12, 2018, 2:34 p.m.
E303 too many blank lines (2)	reviewbot	March 12, 2018, 2:34 p.m.
W391 blank line at end of file	reviewbot	March 12, 2018, 2:34 p.m.
F401 'reviewboard.site.models.LocalSite' imported but unused	reviewbot	March 12, 2018, 2:34 p.m.
F401 'reviewboard.webapi.tests.urls.get_user_js_extension_item_url' imported but unused	reviewbot	March 12, 2018, 2:34 p.m.
W291 trailing whitespace	reviewbot	March 12, 2018, 2:34 p.m.
W292 no newline at end of file	reviewbot	March 12, 2018, 2:34 p.m.
E127 continuation line over-indented for visual indent	reviewbot	March 12, 2018, 2:34 p.m.
W292 no newline at end of file	reviewbot	March 12, 2018, 2:34 p.m.
E303 too many blank lines (3)	reviewbot	March 18, 2018, 4:29 a.m.
E203 whitespace before ':'	reviewbot	March 18, 2018, 4:29 a.m.
E265 block comment should start with '# '	reviewbot	March 18, 2018, 4:29 a.m.
F401 'djblets.extensions.resources.ExtensionResource as DjbletsExtensionResource' imported but unused	reviewbot	March 18, 2018, 4:29 a.m.
F401 'djblets.util.decorators.augment_method_from' imported but unused	reviewbot	March 18, 2018, 4:29 a.m.
E402 module level import not at top of file	reviewbot	March 18, 2018, 4:29 a.m.
E402 module level import not at top of file	reviewbot	March 18, 2018, 4:29 a.m.
F401 'djblets.webapi.errors.DUPLICATE_ITEM' imported but unused	reviewbot	March 18, 2018, 4:29 a.m.
F401 'djblets.webapi.errors.INVALID_FORM_DATA' imported but unused	reviewbot	March 18, 2018, 4:29 a.m.
E402 module level import not at top of file	reviewbot	March 18, 2018, 4:29 a.m.
E402 module level import not at top of file	reviewbot	March 18, 2018, 4:29 a.m.
F401 'djblets.webapi.responses.WebAPIResponseError' imported but unused	reviewbot	March 18, 2018, 4:29 a.m.
E402 module level import not at top of file	reviewbot	March 18, 2018, 4:29 a.m.
F401 'reviewboard.webapi.base.RBResourceMixin' imported but unused	reviewbot	March 18, 2018, 4:29 a.m.
E402 module level import not at top of file	reviewbot	March 18, 2018, 4:29 a.m.
E402 module level import not at top of file	reviewbot	March 18, 2018, 4:29 a.m.
E302 expected 2 blank lines, found 1	reviewbot	March 18, 2018, 4:29 a.m.
E265 block comment should start with '# '	reviewbot	March 18, 2018, 4:29 a.m.
E231 missing whitespace after ','	reviewbot	March 18, 2018, 4:29 a.m.
E303 too many blank lines (2)	reviewbot	March 18, 2018, 4:29 a.m.
E265 block comment should start with '# '	reviewbot	March 18, 2018, 4:29 a.m.
E201 whitespace after '{'	reviewbot	March 18, 2018, 4:29 a.m.
E231 missing whitespace after ','	reviewbot	March 18, 2018, 4:29 a.m.
E501 line too long (81 > 79 characters)	reviewbot	March 18, 2018, 4:29 a.m.
E305 expected 2 blank lines after class or function definition, found 1	reviewbot	March 18, 2018, 4:29 a.m.
W391 blank line at end of file	reviewbot	March 18, 2018, 4:29 a.m.
F401 'reviewboard.site.models.LocalSite' imported but unused	reviewbot	March 18, 2018, 4:29 a.m.
F401 'reviewboard.webapi.tests.urls.get_user_js_extension_item_url' imported but unused	reviewbot	March 18, 2018, 4:29 a.m.
E303 too many blank lines (4)	reviewbot	March 18, 2018, 4:29 a.m.
F841 local variable 'application' is assigned to but never used	reviewbot	March 18, 2018, 4:29 a.m.
F401 'reviewboard.webapi.resources.js_extension.JSExtensionResource' imported but unused	reviewbot	March 25, 2018, 9:03 a.m.
E303 too many blank lines (3)	reviewbot	March 25, 2018, 9:03 a.m.
E231 missing whitespace after ','	reviewbot	March 25, 2018, 9:03 a.m.
E203 whitespace before ':'	reviewbot	March 25, 2018, 9:03 a.m.
E265 block comment should start with '# '	reviewbot	March 25, 2018, 9:03 a.m.
F401 'djblets.extensions.resources.ExtensionResource as DjbletsExtensionResource' imported but unused	reviewbot	March 25, 2018, 9:03 a.m.
F401 'djblets.util.decorators.augment_method_from' imported but unused	reviewbot	March 25, 2018, 9:03 a.m.
F401 'djblets.webapi.errors.DUPLICATE_ITEM' imported but unused	reviewbot	March 25, 2018, 9:03 a.m.
F401 'djblets.webapi.responses.WebAPIResponseError' imported but unused	reviewbot	March 25, 2018, 9:03 a.m.
F401 'djblets.webapi.responses.WebAPIResponsePaginated' imported but unused	reviewbot	March 25, 2018, 9:03 a.m.
F401 'reviewboard.webapi.base.RBResourceMixin' imported but unused	reviewbot	March 25, 2018, 9:03 a.m.
E265 block comment should start with '# '	reviewbot	March 25, 2018, 9:03 a.m.
E231 missing whitespace after ','	reviewbot	March 25, 2018, 9:03 a.m.
E501 line too long (80 > 79 characters)	reviewbot	March 25, 2018, 9:03 a.m.
E501 line too long (80 > 79 characters)	reviewbot	March 25, 2018, 9:03 a.m.
E501 line too long (80 > 79 characters)	reviewbot	March 25, 2018, 9:03 a.m.
E265 block comment should start with '# '	reviewbot	March 25, 2018, 9:03 a.m.
E303 too many blank lines (2)	reviewbot	March 25, 2018, 9:03 a.m.
E501 line too long (88 > 79 characters)	reviewbot	March 25, 2018, 9:03 a.m.
E501 line too long (92 > 79 characters)	reviewbot	March 25, 2018, 9:03 a.m.
E201 whitespace after '{'	reviewbot	March 25, 2018, 9:03 a.m.
E231 missing whitespace after ','	reviewbot	March 25, 2018, 9:03 a.m.
E501 line too long (88 > 79 characters)	reviewbot	March 25, 2018, 9:03 a.m.
E501 line too long (92 > 79 characters)	reviewbot	March 25, 2018, 9:03 a.m.
E265 block comment should start with '# '	reviewbot	March 25, 2018, 9:03 a.m.
E265 block comment should start with '# '	reviewbot	March 25, 2018, 9:03 a.m.
W391 blank line at end of file	reviewbot	March 25, 2018, 9:03 a.m.
W292 no newline at end of file	reviewbot	March 25, 2018, 9:03 a.m.
F401 'reviewboard.site.models.LocalSite' imported but unused	reviewbot	March 25, 2018, 9:03 a.m.
F401 'djblets.testing.decorators.add_fixtures' imported but unused	reviewbot	March 25, 2018, 9:03 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/resources/js_extension.py (Diff revision 1)
An issue was opened. Show all issues
```
E303 too many blank lines (3)
```
reviewboard/webapi/resources/user.py (Diff revision 1)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```

Description:

~		Code drop for Jan 28th meeting (sorry for the delay).
	~	Code drop for Jan 28th meeting:

~		Notes and commented out code to allow users to manage Javascript extensions.
	~	Notes and commented out code to allow users to manage Javascript extensions.
	+
	+	Code drop for Feb 3rd meeting:
	+
	+	Added account page for JavaScript extensions with place holder form
	+	Added stubs for JavaScript extensions resource

Commit:

-	15dcc7071e72233e78f1a50eab6a851a5364c2e4
+	7bdc6d9b2804709b6290f5acb1fccb025466b42b

Diff:

Revision 2 (+163 -3)

Show changes

	reviewboard/accounts/pages.py
	reviewboard/accounts/forms/pages.py
	reviewboard/webapi/resources/js_extension.py
	reviewboard/webapi/resources/user.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/accounts/forms/pages.py (Diff revision 2)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```
reviewboard/accounts/forms/pages.py (Diff revision 2)
An issue was opened. Show all issues
```
E303 too many blank lines (2)
```

reviewboard/webapi/resources/js_extension.py (Diff revision 2)

An issue was opened. Show all issues

F401 'djblets.extensions.manager.ExtensionManager as DjbletsExtensionManager' imported but unused

reviewboard/webapi/resources/js_extension.py (Diff revision 2)
An issue was opened. Show all issues
```
E303 too many blank lines (2)
```
reviewboard/webapi/resources/js_extension.py (Diff revision 2)
An issue was opened. Show all issues
```
E305 expected 2 blank lines after class or function definition, found 1
```
reviewboard/webapi/resources/js_extension.py (Diff revision 2)
An issue was opened. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/webapi/resources/js_extension.py (Diff revision 2)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```
reviewboard/webapi/resources/user.py (Diff revision 2)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```

Description:

~		Code drop for Jan 28th meeting:
	~	Code drop for Jan 28th meeting:
	+	* Notes and commented out code to allow users to manage Javascript extensions.

~		Notes and commented out code to allow users to manage Javascript extensions.
	~	Code drop for Feb 4th meeting:
	+	* Added account page for JavaScript extensions with place holder form
	+	* Added stubs for JavaScript extensions resource

~		Code drop for Feb 3rd meeting:
~
~		Added account page for JavaScript extensions with place holder form
	~	Code drop for Feb 11th meeting:
	~	* JS extension form accepts URL and adds to user profile
	~	* JS extension page lists user's extensions
-		Added stubs for JavaScript extensions resource

Testing Done:

~		None.
	~	None. Manual testing

Commit:

-	7bdc6d9b2804709b6290f5acb1fccb025466b42b
+	f1bb67e5b940a15558032d97b5bd4382d4b01ecd

Diff:

Revision 3 (+178 -3)

Show changes

	reviewboard/staticbundles.py
	reviewboard/accounts/pages.py
	reviewboard/accounts/forms/pages.py
	reviewboard/webapi/resources/js_extension.py
	reviewboard/webapi/resources/user.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/accounts/forms/pages.py (Diff revision 3)
An issue was opened. Show all issues
```
F401 'json' imported but unused
```
reviewboard/accounts/forms/pages.py (Diff revision 3)
An issue was opened. Show all issues
```
E303 too many blank lines (3)
```
reviewboard/accounts/forms/pages.py (Diff revision 3)
An issue was opened. Show all issues
```
E203 whitespace before ':'
```
reviewboard/webapi/resources/js_extension.py (Diff revision 3)
An issue was opened. Show all issues
```
F401 'reviewboard.extensions.base.ExtensionManager' imported but unused
```

reviewboard/webapi/resources/js_extension.py (Diff revision 3)

An issue was opened. Show all issues

F401 'djblets.extensions.manager.ExtensionManager as DjbletsExtensionManager' imported but unused

reviewboard/webapi/resources/js_extension.py (Diff revision 3)
An issue was opened. Show all issues
```
E303 too many blank lines (2)
```
reviewboard/webapi/resources/user.py (Diff revision 3)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```

Description:

		Code drop for Jan 28th meeting:
		* Notes and commented out code to allow users to manage Javascript extensions.

		Code drop for Feb 4th meeting:
		* Added account page for JavaScript extensions with place holder form
		* Added stubs for JavaScript extensions resource

		Code drop for Feb 11th meeting:
		* JS extension form accepts URL and adds to user profile
		* JS extension page lists user's extensions
	+
	+	Code drop for Feb 18th meeting:
	+	* First take implementation for JS extension API resource

Commit:

-	f1bb67e5b940a15558032d97b5bd4382d4b01ecd
+	389982bb051ea01f6500f9fe5dba936055eadad1

Diff:

Revision 4 (+207 -3)

Show changes

	reviewboard/staticbundles.py
	reviewboard/accounts/pages.py
	reviewboard/accounts/forms/pages.py
	reviewboard/webapi/resources/js_extension.py
	reviewboard/webapi/resources/user.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/accounts/forms/pages.py (Diff revision 4)
An issue was opened. Show all issues
```
E303 too many blank lines (3)
```
reviewboard/accounts/forms/pages.py (Diff revision 4)
An issue was opened. Show all issues
```
E203 whitespace before ':'
```

reviewboard/webapi/resources/js_extension.py (Diff revision 4)

An issue was opened. Show all issues

F401 'djblets.extensions.resources.ExtensionResource as DjbletsExtensionResource' imported but unused

reviewboard/webapi/resources/js_extension.py (Diff revision 4)
An issue was opened. Show all issues
```
F401 'djblets.webapi.decorators.webapi_request_fields' imported but unused
```
reviewboard/webapi/resources/js_extension.py (Diff revision 4)
An issue was opened. Show all issues
```
F401 'reviewboard.webapi.base.RBResourceMixin' imported but unused
```
reviewboard/webapi/resources/user.py (Diff revision 4)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```

Description:

		Code drop for Jan 28th meeting:
		* Notes and commented out code to allow users to manage Javascript extensions.

		Code drop for Feb 4th meeting:
		* Added account page for JavaScript extensions with place holder form
		* Added stubs for JavaScript extensions resource

		Code drop for Feb 11th meeting:
		* JS extension form accepts URL and adds to user profile
		* JS extension page lists user's extensions

		Code drop for Feb 18th meeting:
		* First take implementation for JS extension API resource
	+
	+	Code drop for Feb 25th meeting:
	+	* Clean up of JS extension resource
	+	* Created template for testing

Testing Done:

~		None. Manual testing
	~	Existing tests still working.
	+
	+	Tests for user JavaScript extensions not implemented or do not pass.

Commit:

-	389982bb051ea01f6500f9fe5dba936055eadad1
+	6e8c9876da5144f20dde900df410c3e047121a1d

Diff:

Revision 5 (+285 -3)

Show changes

	reviewboard/staticbundles.py
	reviewboard/accounts/pages.py
	reviewboard/accounts/forms/pages.py
	reviewboard/testing/testcase.py
	reviewboard/webapi/resources/js_extension.py
	reviewboard/webapi/resources/user.py
	reviewboard/webapi/tests/urls.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/accounts/forms/pages.py (Diff revision 5)
An issue was opened. Show all issues
```
E303 too many blank lines (3)
```
reviewboard/accounts/forms/pages.py (Diff revision 5)
An issue was opened. Show all issues
```
E203 whitespace before ':'
```
reviewboard/testing/testcase.py (Diff revision 5)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```

reviewboard/webapi/resources/js_extension.py (Diff revision 5)

An issue was opened. Show all issues

F401 'djblets.extensions.resources.ExtensionResource as DjbletsExtensionResource' imported but unused

reviewboard/webapi/resources/js_extension.py (Diff revision 5)
An issue was opened. Show all issues
```
F401 'reviewboard.webapi.base.RBResourceMixin' imported but unused
```
reviewboard/webapi/resources/js_extension.py (Diff revision 5)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```
reviewboard/webapi/resources/js_extension.py (Diff revision 5)
An issue was opened. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/webapi/resources/js_extension.py (Diff revision 5)
An issue was opened. Show all issues
```
E303 too many blank lines (2)
```
reviewboard/webapi/resources/user.py (Diff revision 5)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```
reviewboard/webapi/tests/urls.py (Diff revision 5)
An issue was opened. Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/webapi/tests/urls.py (Diff revision 5)
An issue was opened. Show all issues
```
W292 no newline at end of file
```

Description:

~		Code drop for Jan 28th meeting:
	~	Code drop for Jan 28th meeting:
		* Notes and commented out code to allow users to manage Javascript extensions.

~		Code drop for Feb 4th meeting:
~		* Added account page for JavaScript extensions with place holder form
	~	Code drop for Feb 4th meeting:
	~	* Added account page for JavaScript extensions with place holder form
		* Added stubs for JavaScript extensions resource

~		Code drop for Feb 11th meeting:
~		* JS extension form accepts URL and adds to user profile
	~	Code drop for Feb 11th meeting:
	~	* JS extension form accepts URL and adds to user profile
		* JS extension page lists user's extensions

~		Code drop for Feb 18th meeting:
	~	Code drop for Feb 18th meeting:
		* First take implementation for JS extension API resource

~		Code drop for Feb 25th meeting:
~		* Clean up of JS extension resource
	~	Code drop for Feb 25th meeting:
	~	* Clean up of JS extension resource
		* Created template for testing
	+
	+	Code drop for Feb 25th meeting:
	+	* Finish implementation of GET and POST methods for JS extension list resource

Commit:

-	6e8c9876da5144f20dde900df410c3e047121a1d
+	e08cc0745fd8ea0807d68719d511025aa92f7e96

Diff:

Revision 6 (+411 -3)

Show changes

	reviewboard/staticbundles.py
	reviewboard/accounts/pages.py
	reviewboard/accounts/forms/pages.py
	reviewboard/testing/testcase.py
	reviewboard/webapi/resources/js_extension.py
	reviewboard/webapi/resources/user.py
	reviewboard/webapi/tests/test_user_js_extension.py
	reviewboard/webapi/tests/urls.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/accounts/forms/pages.py (Diff revision 6)
An issue was opened. Show all issues
```
E303 too many blank lines (3)
```
reviewboard/accounts/forms/pages.py (Diff revision 6)
An issue was opened. Show all issues
```
E203 whitespace before ':'
```
reviewboard/testing/testcase.py (Diff revision 6)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```

reviewboard/webapi/resources/js_extension.py (Diff revision 6)

An issue was opened. Show all issues

F401 'djblets.extensions.resources.ExtensionResource as DjbletsExtensionResource' imported but unused

reviewboard/webapi/resources/js_extension.py (Diff revision 6)
An issue was opened. Show all issues
```
F401 'djblets.util.decorators.augment_method_from' imported but unused
```
reviewboard/webapi/resources/js_extension.py (Diff revision 6)
An issue was opened. Show all issues
```
E402 module level import not at top of file
```
reviewboard/webapi/resources/js_extension.py (Diff revision 6)
An issue was opened. Show all issues
```
E402 module level import not at top of file
```
reviewboard/webapi/resources/js_extension.py (Diff revision 6)
An issue was opened. Show all issues
```
E402 module level import not at top of file
```
reviewboard/webapi/resources/js_extension.py (Diff revision 6)
An issue was opened. Show all issues
```
E402 module level import not at top of file
```
reviewboard/webapi/resources/js_extension.py (Diff revision 6)
An issue was opened. Show all issues
```
E402 module level import not at top of file
```
reviewboard/webapi/resources/js_extension.py (Diff revision 6)
An issue was opened. Show all issues
```
F401 'reviewboard.webapi.base.RBResourceMixin' imported but unused
```
reviewboard/webapi/resources/js_extension.py (Diff revision 6)
An issue was opened. Show all issues
```
E402 module level import not at top of file
```
reviewboard/webapi/resources/js_extension.py (Diff revision 6)
An issue was opened. Show all issues
```
E402 module level import not at top of file
```
reviewboard/webapi/resources/js_extension.py (Diff revision 6)
An issue was opened. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/webapi/resources/js_extension.py (Diff revision 6)
An issue was opened. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/webapi/resources/js_extension.py (Diff revision 6)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```
reviewboard/webapi/resources/js_extension.py (Diff revision 6)
An issue was opened. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/webapi/resources/js_extension.py (Diff revision 6)
An issue was opened. Show all issues
```
E303 too many blank lines (2)
```
reviewboard/webapi/resources/js_extension.py (Diff revision 6)
An issue was opened. Show all issues
```
E303 too many blank lines (2)
```
reviewboard/webapi/resources/js_extension.py (Diff revision 6)
An issue was opened. Show all issues
```
W391 blank line at end of file
```
reviewboard/webapi/tests/test_user_js_extension.py (Diff revision 6)
An issue was opened. Show all issues
```
F401 'reviewboard.site.models.LocalSite' imported but unused
```
reviewboard/webapi/tests/test_user_js_extension.py (Diff revision 6)
An issue was opened. Show all issues
```
F401 'reviewboard.webapi.tests.urls.get_user_js_extension_item_url' imported but unused
```
reviewboard/webapi/tests/test_user_js_extension.py (Diff revision 6)
An issue was opened. Show all issues
```
W291 trailing whitespace
```
reviewboard/webapi/tests/test_user_js_extension.py (Diff revision 6)
An issue was opened. Show all issues
```
W292 no newline at end of file
```
reviewboard/webapi/tests/urls.py (Diff revision 6)
An issue was opened. Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/webapi/tests/urls.py (Diff revision 6)
An issue was opened. Show all issues
```
W292 no newline at end of file
```

Description:

		Code drop for Jan 28th meeting:
		* Notes and commented out code to allow users to manage Javascript extensions.

		Code drop for Feb 4th meeting:
		* Added account page for JavaScript extensions with place holder form
		* Added stubs for JavaScript extensions resource

		Code drop for Feb 11th meeting:
		* JS extension form accepts URL and adds to user profile
		* JS extension page lists user's extensions

		Code drop for Feb 18th meeting:
		* First take implementation for JS extension API resource

		Code drop for Feb 25th meeting:
		* Clean up of JS extension resource
		* Created template for testing

~		Code drop for Feb 25th meeting:
	~	Code drop for Mar 4th meeting:
		* Finish implementation of GET and POST methods for JS extension list resource
	+
	+	Code drop for Mar 11th meeting:
	+	* Finish implementation of JS extension view
	+	* Attempt to implement GET and DELETE js extension

Commit:

-	e08cc0745fd8ea0807d68719d511025aa92f7e96
+	07fffb81a73b769d7f9885456769f4cd217bcea3

Diff:

Revision 7 (+534 -3)

Show changes

	reviewboard/staticbundles.py
	reviewboard/accounts/pages.py
	reviewboard/accounts/forms/pages.py
	reviewboard/static/rb/js/accountPrefsPage/views/userExtensionsView.es6.js
	reviewboard/testing/testcase.py
	reviewboard/webapi/resources/js_extension.py
	reviewboard/webapi/resources/user.py
	reviewboard/webapi/tests/test_user_js_extension.py
	1 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/accounts/forms/pages.py (Diff revision 7)
An issue was opened. Show all issues
```
E303 too many blank lines (3)
```
reviewboard/accounts/forms/pages.py (Diff revision 7)
An issue was opened. Show all issues
```
E203 whitespace before ':'
```
reviewboard/testing/testcase.py (Diff revision 7)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```

reviewboard/webapi/resources/js_extension.py (Diff revision 7)

An issue was opened. Show all issues

F401 'djblets.extensions.resources.ExtensionResource as DjbletsExtensionResource' imported but unused

reviewboard/webapi/resources/js_extension.py (Diff revision 7)
An issue was opened. Show all issues
```
F401 'djblets.util.decorators.augment_method_from' imported but unused
```
reviewboard/webapi/resources/js_extension.py (Diff revision 7)
An issue was opened. Show all issues
```
E402 module level import not at top of file
```
reviewboard/webapi/resources/js_extension.py (Diff revision 7)
An issue was opened. Show all issues
```
E402 module level import not at top of file
```
reviewboard/webapi/resources/js_extension.py (Diff revision 7)
An issue was opened. Show all issues
```
F401 'djblets.webapi.errors.DUPLICATE_ITEM' imported but unused
```
reviewboard/webapi/resources/js_extension.py (Diff revision 7)
An issue was opened. Show all issues
```
F401 'djblets.webapi.errors.INVALID_FORM_DATA' imported but unused
```
reviewboard/webapi/resources/js_extension.py (Diff revision 7)
An issue was opened. Show all issues
```
E402 module level import not at top of file
```
reviewboard/webapi/resources/js_extension.py (Diff revision 7)
An issue was opened. Show all issues
```
E402 module level import not at top of file
```
reviewboard/webapi/resources/js_extension.py (Diff revision 7)
An issue was opened. Show all issues
```
E402 module level import not at top of file
```
reviewboard/webapi/resources/js_extension.py (Diff revision 7)
An issue was opened. Show all issues
```
F401 'reviewboard.webapi.base.RBResourceMixin' imported but unused
```
reviewboard/webapi/resources/js_extension.py (Diff revision 7)
An issue was opened. Show all issues
```
E402 module level import not at top of file
```
reviewboard/webapi/resources/js_extension.py (Diff revision 7)
An issue was opened. Show all issues
```
E402 module level import not at top of file
```
reviewboard/webapi/resources/js_extension.py (Diff revision 7)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```
reviewboard/webapi/resources/js_extension.py (Diff revision 7)
An issue was opened. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/webapi/resources/js_extension.py (Diff revision 7)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```
reviewboard/webapi/resources/js_extension.py (Diff revision 7)
An issue was opened. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/webapi/resources/js_extension.py (Diff revision 7)
An issue was opened. Show all issues
```
E303 too many blank lines (2)
```
reviewboard/webapi/resources/js_extension.py (Diff revision 7)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```
reviewboard/webapi/resources/js_extension.py (Diff revision 7)
An issue was opened. Show all issues
```
E303 too many blank lines (2)
```
reviewboard/webapi/resources/js_extension.py (Diff revision 7)
An issue was opened. Show all issues
```
W391 blank line at end of file
```
reviewboard/webapi/tests/test_user_js_extension.py (Diff revision 7)
An issue was opened. Show all issues
```
F401 'reviewboard.site.models.LocalSite' imported but unused
```
reviewboard/webapi/tests/test_user_js_extension.py (Diff revision 7)
An issue was opened. Show all issues
```
F401 'reviewboard.webapi.tests.urls.get_user_js_extension_item_url' imported but unused
```
reviewboard/webapi/tests/test_user_js_extension.py (Diff revision 7)
An issue was opened. Show all issues
```
W291 trailing whitespace
```
reviewboard/webapi/tests/test_user_js_extension.py (Diff revision 7)
An issue was opened. Show all issues
```
W292 no newline at end of file
```
reviewboard/webapi/tests/urls.py (Diff revision 7)
An issue was opened. Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/webapi/tests/urls.py (Diff revision 7)
An issue was opened. Show all issues
```
W292 no newline at end of file
```

Description:

		Code drop for Jan 28th meeting:
		* Notes and commented out code to allow users to manage Javascript extensions.

		Code drop for Feb 4th meeting:
		* Added account page for JavaScript extensions with place holder form
		* Added stubs for JavaScript extensions resource

		Code drop for Feb 11th meeting:
		* JS extension form accepts URL and adds to user profile
		* JS extension page lists user's extensions

		Code drop for Feb 18th meeting:
		* First take implementation for JS extension API resource

		Code drop for Feb 25th meeting:
		* Clean up of JS extension resource
		* Created template for testing

		Code drop for Mar 4th meeting:
		* Finish implementation of GET and POST methods for JS extension list resource

		Code drop for Mar 11th meeting:
		* Finish implementation of JS extension view
		* Attempt to implement GET and DELETE js extension
	+
	+	Code drop for Mar 18th meeting:
	+	* Finish implementing GET and DELETE js extension item resource

Commit:

-	07fffb81a73b769d7f9885456769f4cd217bcea3
+	2f267ef1bfabd6df16096ba57e89597af44cd50c

Diff:

Revision 8 (+530 -3)

Show changes

	reviewboard/staticbundles.py
	reviewboard/accounts/pages.py
	reviewboard/accounts/forms/pages.py
	reviewboard/static/rb/js/accountPrefsPage/views/userExtensionsView.es6.js
	reviewboard/testing/testcase.py
	reviewboard/webapi/resources/js_extension.py
	reviewboard/webapi/resources/user.py
	reviewboard/webapi/tests/test_user_js_extension.py
	1 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 33 failures.
```
reviewboard/accounts/forms/pages.py (Diff revision 8)
An issue was opened. Show all issues
```
E303 too many blank lines (3)
```
reviewboard/accounts/forms/pages.py (Diff revision 8)
An issue was opened. Show all issues
```
E203 whitespace before ':'
```
reviewboard/testing/testcase.py (Diff revision 8)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```

reviewboard/webapi/resources/js_extension.py (Diff revision 8)

An issue was opened. Show all issues

F401 'djblets.extensions.resources.ExtensionResource as DjbletsExtensionResource' imported but unused

reviewboard/webapi/resources/js_extension.py (Diff revision 8)
An issue was opened. Show all issues
```
F401 'djblets.util.decorators.augment_method_from' imported but unused
```
reviewboard/webapi/resources/js_extension.py (Diff revision 8)
An issue was opened. Show all issues
```
E402 module level import not at top of file
```
reviewboard/webapi/resources/js_extension.py (Diff revision 8)
An issue was opened. Show all issues
```
E402 module level import not at top of file
```
reviewboard/webapi/resources/js_extension.py (Diff revision 8)
An issue was opened. Show all issues
```
F401 'djblets.webapi.errors.DUPLICATE_ITEM' imported but unused
```
reviewboard/webapi/resources/js_extension.py (Diff revision 8)
An issue was opened. Show all issues
```
F401 'djblets.webapi.errors.INVALID_FORM_DATA' imported but unused
```
reviewboard/webapi/resources/js_extension.py (Diff revision 8)
An issue was opened. Show all issues
```
E402 module level import not at top of file
```
reviewboard/webapi/resources/js_extension.py (Diff revision 8)
An issue was opened. Show all issues
```
E402 module level import not at top of file
```
reviewboard/webapi/resources/js_extension.py (Diff revision 8)
An issue was opened. Show all issues
```
F401 'djblets.webapi.responses.WebAPIResponseError' imported but unused
```
reviewboard/webapi/resources/js_extension.py (Diff revision 8)
An issue was opened. Show all issues
```
E402 module level import not at top of file
```
reviewboard/webapi/resources/js_extension.py (Diff revision 8)
An issue was opened. Show all issues
```
F401 'reviewboard.webapi.base.RBResourceMixin' imported but unused
```
reviewboard/webapi/resources/js_extension.py (Diff revision 8)
An issue was opened. Show all issues
```
E402 module level import not at top of file
```
reviewboard/webapi/resources/js_extension.py (Diff revision 8)
An issue was opened. Show all issues
```
E402 module level import not at top of file
```
reviewboard/webapi/resources/js_extension.py (Diff revision 8)
An issue was opened. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/webapi/resources/js_extension.py (Diff revision 8)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```
reviewboard/webapi/resources/js_extension.py (Diff revision 8)
An issue was opened. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/webapi/resources/js_extension.py (Diff revision 8)
An issue was opened. Show all issues
```
E303 too many blank lines (2)
```
reviewboard/webapi/resources/js_extension.py (Diff revision 8)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```
reviewboard/webapi/resources/js_extension.py (Diff revision 8)
An issue was opened. Show all issues
```
E201 whitespace after '{'
```
reviewboard/webapi/resources/js_extension.py (Diff revision 8)
An issue was opened. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/webapi/resources/js_extension.py (Diff revision 8)
An issue was opened. Show all issues
```
E501 line too long (81 > 79 characters)
```
reviewboard/webapi/resources/js_extension.py (Diff revision 8)
An issue was opened. Show all issues
```
E305 expected 2 blank lines after class or function definition, found 1
```
reviewboard/webapi/resources/js_extension.py (Diff revision 8)
An issue was opened. Show all issues
```
W391 blank line at end of file
```
reviewboard/webapi/tests/test_user_js_extension.py (Diff revision 8)
An issue was opened. Show all issues
```
F401 'reviewboard.site.models.LocalSite' imported but unused
```
reviewboard/webapi/tests/test_user_js_extension.py (Diff revision 8)
An issue was opened. Show all issues
```
F401 'reviewboard.webapi.tests.urls.get_user_js_extension_item_url' imported but unused
```
reviewboard/webapi/tests/test_user_js_extension.py (Diff revision 8)
An issue was opened. Show all issues
```
E303 too many blank lines (4)
```
reviewboard/webapi/tests/test_user_js_extension.py (Diff revision 8)
An issue was opened. Show all issues
```
F841 local variable 'application' is assigned to but never used
```

Description:

		Code drop for Jan 28th meeting:
		* Notes and commented out code to allow users to manage Javascript extensions.

		Code drop for Feb 4th meeting:
		* Added account page for JavaScript extensions with place holder form
		* Added stubs for JavaScript extensions resource

		Code drop for Feb 11th meeting:
		* JS extension form accepts URL and adds to user profile
		* JS extension page lists user's extensions

		Code drop for Feb 18th meeting:
		* First take implementation for JS extension API resource

		Code drop for Feb 25th meeting:
		* Clean up of JS extension resource
		* Created template for testing

		Code drop for Mar 4th meeting:
		* Finish implementation of GET and POST methods for JS extension list resource

		Code drop for Mar 11th meeting:
		* Finish implementation of JS extension view
		* Attempt to implement GET and DELETE js extension

		Code drop for Mar 18th meeting:
		* Finish implementing GET and DELETE js extension item resource
	+
	+	Code drop for Mar 25th meeting:
	+	* Testing for js extension list & item resource
	+	* Adding permission checks

Testing Done:

		Existing tests still working.

~		Tests for user JavaScript extensions not implemented or do not pass.
	~	Tests for user JavaScript extension list resource passing
	+	Tests for user JavaScript extension item resource not all passing yet

Commit:

-	2f267ef1bfabd6df16096ba57e89597af44cd50c
+	aecefe52da92d8a5df3ce8996ba7c4c70cb363e5

Diff:

Revision 9 (+737 -3)

Show changes

	reviewboard/staticbundles.py
	reviewboard/accounts/pages.py
	reviewboard/accounts/forms/pages.py
	reviewboard/static/rb/js/accountPrefsPage/views/userExtensionsView.es6.js
	reviewboard/testing/testcase.py
	reviewboard/webapi/resources/js_extension.py
	reviewboard/webapi/resources/user.py
	reviewboard/webapi/tests/mimetypes.py
	2 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 35 failures.
```

reviewboard/accounts/forms/pages.py (Diff revision 9)

An issue was opened. Show all issues

F401 'reviewboard.webapi.resources.js_extension.JSExtensionResource' imported but unused

reviewboard/accounts/forms/pages.py (Diff revision 9)
An issue was opened. Show all issues
```
E303 too many blank lines (3)
```
reviewboard/accounts/forms/pages.py (Diff revision 9)
An issue was opened. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/accounts/forms/pages.py (Diff revision 9)
An issue was opened. Show all issues
```
E203 whitespace before ':'
```
reviewboard/testing/testcase.py (Diff revision 9)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```

reviewboard/webapi/resources/js_extension.py (Diff revision 9)

An issue was opened. Show all issues

F401 'djblets.extensions.resources.ExtensionResource as DjbletsExtensionResource' imported but unused

reviewboard/webapi/resources/js_extension.py (Diff revision 9)
An issue was opened. Show all issues
```
F401 'djblets.util.decorators.augment_method_from' imported but unused
```
reviewboard/webapi/resources/js_extension.py (Diff revision 9)
An issue was opened. Show all issues
```
F401 'djblets.webapi.errors.DUPLICATE_ITEM' imported but unused
```
reviewboard/webapi/resources/js_extension.py (Diff revision 9)
An issue was opened. Show all issues
```
F401 'djblets.webapi.responses.WebAPIResponseError' imported but unused
```
reviewboard/webapi/resources/js_extension.py (Diff revision 9)
An issue was opened. Show all issues
```
F401 'djblets.webapi.responses.WebAPIResponsePaginated' imported but unused
```
reviewboard/webapi/resources/js_extension.py (Diff revision 9)
An issue was opened. Show all issues
```
F401 'reviewboard.webapi.base.RBResourceMixin' imported but unused
```
reviewboard/webapi/resources/js_extension.py (Diff revision 9)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```
reviewboard/webapi/resources/js_extension.py (Diff revision 9)
An issue was opened. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/webapi/resources/js_extension.py (Diff revision 9)
An issue was opened. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/js_extension.py (Diff revision 9)
An issue was opened. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/js_extension.py (Diff revision 9)
An issue was opened. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/js_extension.py (Diff revision 9)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```
reviewboard/webapi/resources/js_extension.py (Diff revision 9)
An issue was opened. Show all issues
```
E303 too many blank lines (2)
```
reviewboard/webapi/resources/js_extension.py (Diff revision 9)
An issue was opened. Show all issues
```
E501 line too long (88 > 79 characters)
```
reviewboard/webapi/resources/js_extension.py (Diff revision 9)
An issue was opened. Show all issues
```
E501 line too long (92 > 79 characters)
```
reviewboard/webapi/resources/js_extension.py (Diff revision 9)
An issue was opened. Show all issues
```
E201 whitespace after '{'
```
reviewboard/webapi/resources/js_extension.py (Diff revision 9)
An issue was opened. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/webapi/resources/js_extension.py (Diff revision 9)
An issue was opened. Show all issues
```
E501 line too long (88 > 79 characters)
```
reviewboard/webapi/resources/js_extension.py (Diff revision 9)
An issue was opened. Show all issues
```
E501 line too long (92 > 79 characters)
```
reviewboard/webapi/resources/js_extension.py (Diff revision 9)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```
reviewboard/webapi/resources/js_extension.py (Diff revision 9)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```
reviewboard/webapi/resources/js_extension.py (Diff revision 9)
An issue was opened. Show all issues
```
W391 blank line at end of file
```
reviewboard/webapi/tests/mimetypes.py (Diff revision 9)
An issue was opened. Show all issues
```
W292 no newline at end of file
```
reviewboard/webapi/tests/test_user_js_extension.py (Diff revision 9)
An issue was opened. Show all issues
```
F401 'reviewboard.site.models.LocalSite' imported but unused
```
reviewboard/webapi/tests/test_user_js_extension.py (Diff revision 9)
An issue was opened. Show all issues
```
F401 'djblets.testing.decorators.add_fixtures' imported but unused
```

Description:

		Code drop for Jan 28th meeting:
		* Notes and commented out code to allow users to manage Javascript extensions.

		Code drop for Feb 4th meeting:
		* Added account page for JavaScript extensions with place holder form
		* Added stubs for JavaScript extensions resource

		Code drop for Feb 11th meeting:
		* JS extension form accepts URL and adds to user profile
		* JS extension page lists user's extensions

		Code drop for Feb 18th meeting:
		* First take implementation for JS extension API resource

		Code drop for Feb 25th meeting:
		* Clean up of JS extension resource
		* Created template for testing

		Code drop for Mar 4th meeting:
		* Finish implementation of GET and POST methods for JS extension list resource

		Code drop for Mar 11th meeting:
		* Finish implementation of JS extension view
		* Attempt to implement GET and DELETE js extension

		Code drop for Mar 18th meeting:
		* Finish implementing GET and DELETE js extension item resource

		Code drop for Mar 25th meeting:
		* Testing for js extension list & item resource
		* Adding permission checks
	+
	+	Code drop for April 1st:
	+	* Passed all tests for js extension list & item resource
	+	* Attempt to load JS extension information in front-end

Testing Done:

		Existing tests still working.

~		Tests for user JavaScript extension list resource passing
~		Tests for user JavaScript extension item resource not all passing yet
	~	Tests for user JavaScript extension list & item resource passing.
	~	- List: GET, POST
	+	- Item: GET, PUT, DELETE

Commit:

-	aecefe52da92d8a5df3ce8996ba7c4c70cb363e5
+	627011b4d2f1dcca6edc3ba935b823d724495772

Diff:

Revision 10 (+732 -5)

Show changes

	reviewboard/staticbundles.py
	reviewboard/accounts/pages.py
	reviewboard/accounts/forms/pages.py
	reviewboard/static/rb/js/accountPrefsPage/views/userExtensionsView.es6.js
	reviewboard/static/rb/js/models/userSessionModel.js
	reviewboard/templates/base.html
	reviewboard/testing/testcase.py
	reviewboard/webapi/resources/js_extension.py
	4 more

Checks run (2 timed out)

flake8 timed out.

JSHint timed out.

[WIP] Create Javascript extension resource

Information

Reviewers

flake8

Description:

Commit:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Description:

Testing Done:

Commit:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Description:

Commit:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Description:

Testing Done:

Commit:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Description:

Commit:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Description:

Commit:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Description:

Commit:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Description:

Testing Done:

Commit:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Description:

Testing Done:

Commit:

Diff:

Checks run (2 timed out)

Status: Discarded