[WIP] Create Javascript extension resource

Review Request #9547 - Created Jan. 28, 2018 and updated

Jessica Que
Review Board
master
389982b...
reviewboard, students

Code drop for Jan 28th meeting:
* Notes and commented out code to allow users to manage Javascript extensions.

Code drop for Feb 4th meeting:
Added account page for JavaScript extensions with place holder form
Added stubs for JavaScript extensions resource

Code drop for Feb 11th meeting:
JS extension form accepts URL and adds to user profile
JS extension page lists user's extensions

Code drop for Feb 18th meeting:
* First take implementation for JS extension API resource

None. Manual testing

  • 23
  • 0
  • 0
  • 0
  • 23
Description From Last Updated
E303 too many blank lines (3) Review Bot Review Bot
E265 block comment should start with '# ' Review Bot Review Bot
E265 block comment should start with '# ' Review Bot Review Bot
E303 too many blank lines (2) Review Bot Review Bot
F401 'djblets.extensions.manager.ExtensionManager as DjbletsExtensionManager' imported but unused Review Bot Review Bot
E303 too many blank lines (2) Review Bot Review Bot
E305 expected 2 blank lines after class or function definition, found 1 Review Bot Review Bot
E302 expected 2 blank lines, found 1 Review Bot Review Bot
E265 block comment should start with '# ' Review Bot Review Bot
E265 block comment should start with '# ' Review Bot Review Bot
F401 'json' imported but unused Review Bot Review Bot
E303 too many blank lines (3) Review Bot Review Bot
E203 whitespace before ':' Review Bot Review Bot
F401 'reviewboard.extensions.base.ExtensionManager' imported but unused Review Bot Review Bot
F401 'djblets.extensions.manager.ExtensionManager as DjbletsExtensionManager' imported but unused Review Bot Review Bot
E303 too many blank lines (2) Review Bot Review Bot
E265 block comment should start with '# ' Review Bot Review Bot
E303 too many blank lines (3) Review Bot Review Bot
E203 whitespace before ':' Review Bot Review Bot
F401 'djblets.extensions.resources.ExtensionResource as DjbletsExtensionResource' imported but unused Review Bot Review Bot
F401 'djblets.webapi.decorators.webapi_request_fields' imported but unused Review Bot Review Bot
F401 'reviewboard.webapi.base.RBResourceMixin' imported but unused Review Bot Review Bot
E265 block comment should start with '# ' Review Bot Review Bot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

Jessica Que
Review request changed

Description:

~  

Code drop for Jan 28th meeting (sorry for the delay).

  ~

Code drop for Jan 28th meeting:

   
~  

Notes and commented out code to allow users to manage Javascript extensions.

  ~
  • Notes and commented out code to allow users to manage Javascript extensions.
  +
  +

Code drop for Feb 3rd meeting:

  +
  +
  • Added account page for JavaScript extensions with place holder form
  +
  • Added stubs for JavaScript extensions resource

Commit:

-15dcc7071e72233e78f1a50eab6a851a5364c2e4
+7bdc6d9b2804709b6290f5acb1fccb025466b42b

Diff:

Revision 2 (+163 -3)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

Jessica Que
Review request changed

Description:

~  

Code drop for Jan 28th meeting:

  ~

Code drop for Jan 28th meeting:

  + * Notes and commented out code to allow users to manage Javascript extensions.

   
~  
  • Notes and commented out code to allow users to manage Javascript extensions.
  ~

Code drop for Feb 4th meeting:

  + Added account page for JavaScript extensions with place holder form
  + Added stubs for JavaScript extensions resource

   
~  

Code drop for Feb 3rd meeting:

~  
~  
  • Added account page for JavaScript extensions with place holder form
  ~

Code drop for Feb 11th meeting:

  ~ JS extension form accepts URL and adds to user profile
  ~ JS extension page lists user's extensions

-  
  • Added stubs for JavaScript extensions resource

Testing Done:

~  

None.

  ~

None. Manual testing

Commit:

-7bdc6d9b2804709b6290f5acb1fccb025466b42b
+f1bb67e5b940a15558032d97b5bd4382d4b01ecd

Diff:

Revision 3 (+178 -3)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

Jessica Que
Review request changed

Description:

   

Code drop for Jan 28th meeting:

    * Notes and commented out code to allow users to manage Javascript extensions.

   
   

Code drop for Feb 4th meeting:

    Added account page for JavaScript extensions with place holder form
    Added stubs for JavaScript extensions resource

   
   

Code drop for Feb 11th meeting:

    JS extension form accepts URL and adds to user profile
    JS extension page lists user's extensions

  +
  +

Code drop for Feb 18th meeting:

  + * First take implementation for JS extension API resource

Commit:

-f1bb67e5b940a15558032d97b5bd4382d4b01ecd
+389982bb051ea01f6500f9fe5dba936055eadad1

Diff:

Revision 4 (+207 -3)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

Loading...