Code Drop WIP: Default reviewers with conditions

Review Request #9545 — Created Jan. 27, 2018 and discarded

rodgerwa
Review Board
master
reviewboard

Code Drop WIP: Default reviewers with conditions

code drop for Saturday 27th. Little later than 24 hrs before the
meeting but its here.

I spent the time I had tracing my way to find how
admin/db/reviews/defaultreviewer/add is defined. Regex didn't help
much at first until I read up on Django project structure.

So far, this patch adds the conditions field to the
ADD DEFAULT REVIEWER page but there is no default values yet.
This means hitting plus doesn't do anything. I've got a few ideas but
if I can't find anything by tomorrow I'll ping someone in slack.

Next week my school schedule will be less irregular so I hope to get
something working by next code drop.



Description From Last Updated

I messed up my local version due to funky VM Host setup. This head is completely lost. I'm not discarding ...

RO rodgerwa

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

RO
Review request changed

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

RO
Review request changed

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

RO
  1. 
      
  2. I messed up my local version due to funky VM Host setup. This head is completely lost. I'm not discarding it because its a shard for tracking progress for ucosp.

  3. 
      
RO
Review request changed

Status: Discarded

Loading...