flake8
-
reviewboard/hostingsvcs/github.py (Diff revision 1)
Review Request #9544 — Created Jan. 27, 2018 and discarded
Added options to the Github repository form to enable posting
to a Github issue when a bug is first mentioned or when a
review request referencing a bug is updated and closing a
Github issue when a Review Request is closed.
Added properties to Repository for the new bug tracker
integration options.
Added new methods to HostingService that are called when the
review request is closed or updated to take care of these
deeper bug tracking options.
Added the ability to post to bug on first reference.
Added a bug tracker form to HostingService.
Updated RepositoryForm to use the new bug tracker form in the
bug tracker section if it exists.
Created unit tests in reviewboard.hostingsvcs.tests.test_github.py
Tested everything with a private GitHub repo and a local reviewboard instance.
Description | From | Last Updated |
---|---|---|
E501 line too long (81 > 79 characters) |
reviewbot | |
"Enable ..." is a little bit passive. How about: "Post an update to the bug tracker when review requests or … |
david | |
How is this different from the posting/closing bits? Can we just use those and skip this one? |
david | |
Same sort of comment here: "Close related bugs when the review request is closed." |
david | |
Missing a docstring (I know the others don't have them--that's older code) |
david | |
Missing a docstring (I know the others don't have them--that's older code) |
david | |
Missing a docstring. |
david | |
Missing a docstring. |
david | |
E501 line too long (80 > 79 characters) |
reviewbot | |
This should refer to commenting on the issue, not editing |
david | |
Should "enables" be "enable"? On second thought, is this used at all? |
david | |
Needs a docstring. |
david | |
E722 do not use bare except' |
reviewbot | |
Needs a docstring. |
david | |
"Review Board" should always have a space. We also tend to prefer wrapping the whole thing in parens instead of … |
david | |
E501 line too long (106 > 79 characters) |
reviewbot | |
E722 do not use bare except' |
reviewbot | |
Docstring should explain what the args/returns are. |
david | |
E722 do not use bare except' |
reviewbot | |
In addition to Review Bot's complaint about line length, r comes before s. |
david | |
E501 line too long (87 > 79 characters) |
reviewbot | |
Missing a docstring. |
david | |
Add a blank line between these two. |
david | |
We should probably create a property in the hosting service that wraps this extra_data access. |
david | |
Add another blank line here. |
david | |
E302 expected 2 blank lines, found 1 |
reviewbot | |
Missing a docstring. |
david | |
Add a blank line between these two. |
david | |
We should probably create a property in the hosting service that wraps this extra_data access. |
david | |
E722 do not use bare except' |
reviewbot | |
W503 line break before binary operator |
reviewbot | |
E722 do not use bare except' |
reviewbot | |
E722 do not use bare except' |
reviewbot | |
F401 'reviewboard.reviews.models.ReviewRequest' imported but unused |
reviewbot | |
E722 do not use bare except' |
reviewbot | |
E722 do not use bare except' |
reviewbot | |
E722 do not use bare except' |
reviewbot | |
E501 line too long (81 > 79 characters) |
reviewbot | |
W503 line break before binary operator |
reviewbot | |
E501 line too long (81 > 79 characters) |
reviewbot | |
E722 do not use bare except' |
reviewbot | |
E722 do not use bare except' |
reviewbot | |
E722 do not use bare except' |
reviewbot | |
E501 line too long (81 > 79 characters) |
reviewbot | |
E722 do not use bare except' |
reviewbot | |
E722 do not use bare except' |
reviewbot | |
E722 do not use bare except' |
reviewbot | |
E501 line too long (87 > 79 characters) |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E501 line too long (81 > 79 characters) |
reviewbot | |
E722 do not use bare except' |
reviewbot | |
E722 do not use bare except' |
reviewbot | |
E722 do not use bare except' |
reviewbot | |
E501 line too long (87 > 79 characters) |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E501 line too long (80 > 79 characters) |
reviewbot | |
E501 line too long (80 > 79 characters) |
reviewbot | |
E501 line too long (82 > 79 characters) |
reviewbot | |
E501 line too long (80 > 79 characters) |
reviewbot | |
Just an empty line in the function docstring. |
JT jtrang | |
E722 do not use bare except' |
reviewbot | |
E722 do not use bare except' |
reviewbot | |
E722 do not use bare except' |
reviewbot | |
For someone who is unfamiliar with the project, I think it would be useful to add a comment about why … |
JT jtrang | |
Same comment as above to add a comment or TODO note. |
JT jtrang | |
I see that after the first and, there is a check for (<expr> and <expr>) or (<expr> and <expr>). For … |
JT jtrang | |
E722 do not use bare except' |
reviewbot | |
E722 do not use bare except' |
reviewbot | |
E722 do not use bare except' |
reviewbot | |
E127 continuation line over-indented for visual indent |
reviewbot |
Description: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 2 (+239) |
reviewboard/hostingsvcs/github.py (Diff revision 2) |
---|
"Enable ..." is a little bit passive. How about:
"Post an update to the bug tracker when review requests or reviews are published."
reviewboard/hostingsvcs/github.py (Diff revision 2) |
---|
How is this different from the posting/closing bits? Can we just use those and skip this one?
reviewboard/hostingsvcs/github.py (Diff revision 2) |
---|
Same sort of comment here:
"Close related bugs when the review request is closed."
reviewboard/hostingsvcs/github.py (Diff revision 2) |
---|
Missing a docstring (I know the others don't have them--that's older code)
reviewboard/hostingsvcs/github.py (Diff revision 2) |
---|
Missing a docstring (I know the others don't have them--that's older code)
reviewboard/hostingsvcs/github.py (Diff revision 2) |
---|
This should refer to commenting on the issue, not editing
reviewboard/hostingsvcs/github.py (Diff revision 2) |
---|
Should "enables" be "enable"?
On second thought, is this used at all?
reviewboard/hostingsvcs/github.py (Diff revision 2) |
---|
"Review Board" should always have a space. We also tend to prefer wrapping the whole thing in parens instead of using the continuation character.
reviewboard/hostingsvcs/github.py (Diff revision 2) |
---|
Docstring should explain what the args/returns are.
reviewboard/hostingsvcs/service.py (Diff revision 2) |
---|
In addition to Review Bot's complaint about line length, r comes before s.
reviewboard/hostingsvcs/service.py (Diff revision 2) |
---|
We should probably create a property in the hosting service that wraps this
extra_data
access.
reviewboard/hostingsvcs/service.py (Diff revision 2) |
---|
We should probably create a property in the hosting service that wraps this
extra_data
access.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+240) |
Summary: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Commit: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 4 (+391) |
reviewboard/hostingsvcs/github.py (Diff revision 4) |
---|
F401 'reviewboard.reviews.models.ReviewRequest' imported but unused
Description: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 5 (+438 -4) |
Description: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 6 (+498 -4) |
reviewboard/hostingsvcs/service.py (Diff revision 6) |
---|
E128 continuation line under-indented for visual indent
reviewboard/hostingsvcs/service.py (Diff revision 6) |
---|
E128 continuation line under-indented for visual indent
Summary: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Commit: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 7 (+501 -4) |
reviewboard/hostingsvcs/service.py (Diff revision 7) |
---|
E128 continuation line under-indented for visual indent
reviewboard/hostingsvcs/service.py (Diff revision 7) |
---|
E128 continuation line under-indented for visual indent
Description: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 8 (+505 -4) |
reviewboard/hostingsvcs/service.py (Diff revision 8) |
---|
For someone who is unfamiliar with the project, I think it would be useful to add a comment about why the function is not implemented, or a TODO comment if the implementation is expected down the line (or in a separate project).
reviewboard/hostingsvcs/service.py (Diff revision 8) |
---|
Same comment as above to add a comment or TODO note.
reviewboard/hostingsvcs/service.py (Diff revision 8) |
---|
I see that after the first
and
, there is a check for(<expr> and <expr>) or (<expr> and <expr>)
. For readability, I think it might be useful to extract these booleans into separate variables with meaningful names.
Summary: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Commit: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 9 (+512 -4) |
reviewboard/hostingsvcs/service.py (Diff revision 9) |
---|
E127 continuation line over-indented for visual indent
Summary: |
|
||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||||||||||||||||||||||||||
Testing Done: |
|
||||||||||||||||||||||||||||||||||||||||||
Commit: |
|
||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 10 (+821 -4) |