Summary

Deeper Bug Tracker Integrations

Review Request #9544 — Created Jan. 27, 2018 and discarded Sept. 14, 2021, 11:17 p.m.

Information

Owner

jcorrive

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard, students

People

Description

Added options to the Github repository form to enable posting
to a Github issue when a bug is first mentioned or when a
review request referencing a bug is updated and closing a
Github issue when a Review Request is closed.
Added properties to Repository for the new bug tracker
integration options.
Added new methods to HostingService that are called when the
review request is closed or updated to take care of these
deeper bug tracking options.
Added the ability to post to bug on first reference.
Added a bug tracker form to HostingService.
Updated RepositoryForm to use the new bug tracker form in the
bug tracker section if it exists.

Testing Done

Created unit tests in reviewboard.hostingsvcs.tests.test_github.py

Tested everything with a private GitHub repo and a local reviewboard instance.

Issues

Description	From	Last Updated
E501 line too long (81 > 79 characters)	reviewbot	Feb. 21, 2018, 6:47 p.m.
"Enable ..." is a little bit passive. How about: "Post an update to the bug tracker when review requests or …	david	Feb. 21, 2018, 6:46 p.m.
How is this different from the posting/closing bits? Can we just use those and skip this one?	david	Feb. 21, 2018, 6:46 p.m.
Same sort of comment here: "Close related bugs when the review request is closed."	david	Feb. 21, 2018, 6:46 p.m.
Missing a docstring (I know the others don't have them--that's older code)	david	Feb. 28, 2018, 2:14 p.m.
Missing a docstring (I know the others don't have them--that's older code)	david	Feb. 28, 2018, 2:20 p.m.
Missing a docstring.	david	Feb. 28, 2018, 2:38 p.m.
Missing a docstring.	david	Feb. 28, 2018, 2:38 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Feb. 21, 2018, 6:46 p.m.
This should refer to commenting on the issue, not editing	david	Feb. 21, 2018, 6:45 p.m.
Should "enables" be "enable"? On second thought, is this used at all?	david	Feb. 21, 2018, 6:45 p.m.
Needs a docstring.	david	Feb. 28, 2018, 5:21 p.m.
E722 do not use bare except'	reviewbot	Feb. 21, 2018, 6:49 p.m.
Needs a docstring.	david	Feb. 28, 2018, 5:21 p.m.
"Review Board" should always have a space. We also tend to prefer wrapping the whole thing in parens instead of …	david	Feb. 21, 2018, 6:45 p.m.
E501 line too long (106 > 79 characters)	reviewbot	Feb. 21, 2018, 6:46 p.m.
E722 do not use bare except'	reviewbot	Feb. 21, 2018, 6:49 p.m.
Docstring should explain what the args/returns are.	david	Feb. 28, 2018, 5:21 p.m.
E722 do not use bare except'	reviewbot	Feb. 21, 2018, 6:49 p.m.
In addition to Review Bot's complaint about line length, r comes before s.	david	Feb. 21, 2018, 6:45 p.m.
E501 line too long (87 > 79 characters)	reviewbot	Feb. 21, 2018, 6:46 p.m.
Missing a docstring.	david	Feb. 28, 2018, 5:40 p.m.
Add a blank line between these two.	david	Feb. 21, 2018, 6:44 p.m.
We should probably create a property in the hosting service that wraps this extra_data access.	david	March 17, 2018, 8:25 p.m.
Add another blank line here.	david	Feb. 21, 2018, 6:44 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Feb. 21, 2018, 6:46 p.m.
Missing a docstring.	david	Feb. 28, 2018, 5:40 p.m.
Add a blank line between these two.	david	Feb. 21, 2018, 6:44 p.m.
We should probably create a property in the hosting service that wraps this extra_data access.	david	March 17, 2018, 8:25 p.m.
E722 do not use bare except'	reviewbot	March 10, 2018, 7:57 a.m.
W503 line break before binary operator	reviewbot	Feb. 21, 2018, 6:44 p.m.
E722 do not use bare except'	reviewbot	March 10, 2018, 7:57 a.m.
E722 do not use bare except'	reviewbot	March 10, 2018, 7:57 a.m.
F401 'reviewboard.reviews.models.ReviewRequest' imported but unused	reviewbot	March 10, 2018, 6:59 a.m.
E722 do not use bare except'	reviewbot	March 24, 2018, 9:32 p.m.
E722 do not use bare except'	reviewbot	March 24, 2018, 9:32 p.m.
E722 do not use bare except'	reviewbot	March 24, 2018, 9:32 p.m.
E501 line too long (81 > 79 characters)	reviewbot	March 10, 2018, 7 a.m.
W503 line break before binary operator	reviewbot	March 10, 2018, 7:01 a.m.
E501 line too long (81 > 79 characters)	reviewbot	March 24, 2018, 9:34 p.m.
E722 do not use bare except'	reviewbot	March 24, 2018, 9:32 p.m.
E722 do not use bare except'	reviewbot	March 24, 2018, 9:32 p.m.
E722 do not use bare except'	reviewbot	March 24, 2018, 9:32 p.m.
E501 line too long (81 > 79 characters)	reviewbot	March 24, 2018, 9:34 p.m.
E722 do not use bare except'	reviewbot	March 24, 2018, 9:32 p.m.
E722 do not use bare except'	reviewbot	March 24, 2018, 9:32 p.m.
E722 do not use bare except'	reviewbot	March 24, 2018, 9:32 p.m.
E501 line too long (87 > 79 characters)	reviewbot	March 24, 2018, 9:35 p.m.
E128 continuation line under-indented for visual indent	reviewbot	March 24, 2018, 9:37 p.m.
E128 continuation line under-indented for visual indent	reviewbot	March 24, 2018, 9:37 p.m.
E501 line too long (81 > 79 characters)	reviewbot	March 24, 2018, 9:37 p.m.
E722 do not use bare except'	reviewbot	March 24, 2018, 9:44 p.m.
E722 do not use bare except'	reviewbot	March 24, 2018, 9:44 p.m.
E722 do not use bare except'	reviewbot	March 24, 2018, 9:44 p.m.
E501 line too long (87 > 79 characters)	reviewbot	March 24, 2018, 9:36 p.m.
E128 continuation line under-indented for visual indent	reviewbot	March 24, 2018, 9:43 p.m.
E128 continuation line under-indented for visual indent	reviewbot	March 24, 2018, 9:43 p.m.
E501 line too long (80 > 79 characters)	reviewbot	March 24, 2018, 9:37 p.m.
E501 line too long (80 > 79 characters)	reviewbot	March 24, 2018, 9:37 p.m.
E501 line too long (82 > 79 characters)	reviewbot	March 24, 2018, 9:38 p.m.
E501 line too long (80 > 79 characters)	reviewbot	March 24, 2018, 9:39 p.m.
Just an empty line in the function docstring.	JT jtrang	March 26, 2018, 4:09 p.m.
E722 do not use bare except'	reviewbot	March 26, 2018, 4:40 p.m.
E722 do not use bare except'	reviewbot	March 26, 2018, 4:40 p.m.
E722 do not use bare except'	reviewbot	March 26, 2018, 4:40 p.m.
For someone who is unfamiliar with the project, I think it would be useful to add a comment about why …	JT jtrang	March 26, 2018, 4:13 p.m.
Same comment as above to add a comment or TODO note.	JT jtrang	March 26, 2018, 4:13 p.m.
I see that after the first and, there is a check for (<expr> and <expr>) or (<expr> and <expr>). For …	JT jtrang	March 26, 2018, 4:20 p.m.
E722 do not use bare except'	reviewbot	March 26, 2018, 4:39 p.m.
E722 do not use bare except'	reviewbot	March 26, 2018, 4:39 p.m.
E722 do not use bare except'	reviewbot	March 26, 2018, 4:39 p.m.
E127 continuation line over-indented for visual indent	reviewbot	March 26, 2018, 4:40 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/github.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (81 > 79 characters)
```

Description:

		Added boolean flags to HostingServices to see whether the repository
		supports posting to a bug tracker when a change is posted, closing a bug
		when a reviw request is closed, or notifying a bug tracker when there's
		new reviews or review requests for the bug.

		Added a couple extra checkboxes to the Github repository form to enable
		these options.
	+
	+
	+
	+	Added a new method to HostingService that is called when the
	+	review_request_closed signal is sent.
	+
	+
	+
	+	Added a field to the Private Github repository fields to get the value
	+	from an extra checkbox to enable the new options for configuring a bug
	+	tracker.
	+
	+
	+
	+	Modified review_request_closed method to close the bug when the Review
	+	Request is closed if enable_closing_remote_bug is set to True.
	+
	+
	+
	+	Added methods to github.py and hostingservices.py to enable sending an
	+	HTTP Patch request in order to allow closing a Github Issue.
	+
	+
	+
	+	Added a method to post to a github issue when a ReviewRequest is
	+	updated.

Commit:

98c280f00197e0c99a751a5fcb70e226f002f4e6

d34e02768cbc4cd2dfc9e5e6c077563b115e5f23

Diff:

Revision 2 (+239)

Show changes

	reviewboard/hostingsvcs/bugtracker.py
	reviewboard/hostingsvcs/bugzilla.py
	reviewboard/hostingsvcs/github.py
	reviewboard/hostingsvcs/service.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E722 do not use bare except'
```
reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E501 line too long (106 > 79 characters)
```
reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E722 do not use bare except'
```
reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E722 do not use bare except'
```
reviewboard/hostingsvcs/service.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E501 line too long (87 > 79 characters)
```
reviewboard/hostingsvcs/service.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E302 expected 2 blank lines, found 1
```

Summary:: [WIP] Added some flags for more bug tracker functionality to HostingService
[WIP] Added a method to post to a Github issue when a ReviewRequest is updated

reviewboard/hostingsvcs/github.py (Diff revision 2)

The issue has been resolved. Show all issues

"Enable ..." is a little bit passive. How about:

"Post an update to the bug tracker when review requests or reviews are published."

reviewboard/hostingsvcs/github.py (Diff revision 2)

The issue has been resolved. Show all issues

How is this different from the posting/closing bits? Can we just use those and skip this one?

reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Same sort of comment here:
"Close related bugs when the review request is closed."
```
reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing a docstring (I know the others don't have them--that's older code)
```
reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing a docstring (I know the others don't have them--that's older code)
```
reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing a docstring.
```
reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing a docstring.
```
reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This should refer to commenting on the issue, not editing
```

reviewboard/hostingsvcs/github.py (Diff revision 2)

The issue has been resolved. Show all issues

Should "enables" be "enable"?

On second thought, is this used at all?

jcorrive Feb. 21, 2018, 6:22 p.m.

No it isn't. It was one of my first attemps to access the values of the new fields. I'll remove it.

reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Needs a docstring.
```
reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Needs a docstring.
```

reviewboard/hostingsvcs/github.py (Diff revision 2)

The issue has been resolved. Show all issues

"Review Board" should always have a space. We also tend to prefer wrapping the whole thing in parens instead of using the continuation character.

reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Docstring should explain what the args/returns are.
```
reviewboard/hostingsvcs/service.py (Diff revision 2)
The issue has been resolved. Show all issues
```
In addition to Review Bot's complaint about line length, r comes before s.
```
reviewboard/hostingsvcs/service.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing a docstring.
```
reviewboard/hostingsvcs/service.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Add a blank line between these two.
```

reviewboard/hostingsvcs/service.py (Diff revision 2)

The issue has been resolved. Show all issues

We should probably create a property in the hosting service that wraps this extra_data access.

reviewboard/hostingsvcs/service.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Add another blank line here.
```
reviewboard/hostingsvcs/service.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing a docstring.
```
reviewboard/hostingsvcs/service.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Add a blank line between these two.
```

reviewboard/hostingsvcs/service.py (Diff revision 2)

The issue has been resolved. Show all issues

We should probably create a property in the hosting service that wraps this extra_data access.

Commit:

d34e02768cbc4cd2dfc9e5e6c077563b115e5f23

a7c49e4a20c12bd22a4d13acace19c86b7b75eb6

Diff:

Revision 3 (+240)

Show changes

	reviewboard/hostingsvcs/bugtracker.py
	reviewboard/hostingsvcs/bugzilla.py
	reviewboard/hostingsvcs/github.py
	reviewboard/hostingsvcs/service.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/github.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E722 do not use bare except'
```
reviewboard/hostingsvcs/github.py (Diff revision 3)
The issue has been resolved. Show all issues
```
W503 line break before binary operator
```
reviewboard/hostingsvcs/github.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E722 do not use bare except'
```
reviewboard/hostingsvcs/github.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E722 do not use bare except'
```

Summary:

[WIP] Added a method to post to a Github issue when a ReviewRequest is updated

[WIP] Added docstrings and post to bug on first reference

Description:

		Added boolean flags to HostingServices to see whether the repository
		supports posting to a bug tracker when a change is posted, closing a bug
		when a reviw request is closed, or notifying a bug tracker when there's
		new reviews or review requests for the bug.

		Added a couple extra checkboxes to the Github repository form to enable
		these options.



		Added a new method to HostingService that is called when the
		review_request_closed signal is sent.



		Added a field to the Private Github repository fields to get the value
		from an extra checkbox to enable the new options for configuring a bug
		tracker.



		Modified review_request_closed method to close the bug when the Review
		Request is closed if enable_closing_remote_bug is set to True.



		Added methods to github.py and hostingservices.py to enable sending an
		HTTP Patch request in order to allow closing a Github Issue.



		Added a method to post to a github issue when a ReviewRequest is
		updated.
	+
	+
	+
	+	Added docstrings and post to bug on first reference

Commit:

a7c49e4a20c12bd22a4d13acace19c86b7b75eb6

f1f4d66339a505b6dec4dc90e14ec7901a84aa47

Diff:

Revision 4 (+391)

Show changes

	reviewboard/hostingsvcs/bugtracker.py
	reviewboard/hostingsvcs/github.py
	reviewboard/hostingsvcs/service.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/github.py (Diff revision 4)
The issue has been resolved. Show all issues
```
F401 'reviewboard.reviews.models.ReviewRequest' imported but unused
```
reviewboard/hostingsvcs/github.py (Diff revision 4)
The issue has been dropped. Show all issues
```
E722 do not use bare except'
```
reviewboard/hostingsvcs/github.py (Diff revision 4)
The issue has been dropped. Show all issues
```
E722 do not use bare except'
```
reviewboard/hostingsvcs/github.py (Diff revision 4)
The issue has been dropped. Show all issues
```
E722 do not use bare except'
```
reviewboard/hostingsvcs/service.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (81 > 79 characters)
```
reviewboard/hostingsvcs/service.py (Diff revision 4)
The issue has been resolved. Show all issues
```
W503 line break before binary operator
```

Description:

		Added boolean flags to HostingServices to see whether the repository
		supports posting to a bug tracker when a change is posted, closing a bug
		when a reviw request is closed, or notifying a bug tracker when there's
		new reviews or review requests for the bug.

		Added a couple extra checkboxes to the Github repository form to enable
		these options.



		Added a new method to HostingService that is called when the
		review_request_closed signal is sent.



		Added a field to the Private Github repository fields to get the value
		from an extra checkbox to enable the new options for configuring a bug
		tracker.



		Modified review_request_closed method to close the bug when the Review
		Request is closed if enable_closing_remote_bug is set to True.



		Added methods to github.py and hostingservices.py to enable sending an
		HTTP Patch request in order to allow closing a Github Issue.



		Added a method to post to a github issue when a ReviewRequest is
		updated.



~		Added docstrings and post to bug on first reference
	~	Added docstrings and post to bug on first reference.
	+
	+
	+
	+
	+
	+	Added a bug tracker form to HostingService.
	+	Updated RepositoryForm to use the new Bug tracker form in the Bug tracker section if it exists.

Commit:

f1f4d66339a505b6dec4dc90e14ec7901a84aa47

9576897c151d96d8078044e3032f635cc1898dfd

Diff:

Revision 5 (+438 -4)

Show changes

	reviewboard/hostingsvcs/bugtracker.py
	reviewboard/hostingsvcs/github.py
	reviewboard/hostingsvcs/service.py
	reviewboard/scmtools/forms.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/github.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E501 line too long (81 > 79 characters)
```
reviewboard/hostingsvcs/github.py (Diff revision 5)
The issue has been dropped. Show all issues
```
E722 do not use bare except'
```
reviewboard/hostingsvcs/github.py (Diff revision 5)
The issue has been dropped. Show all issues
```
E722 do not use bare except'
```
reviewboard/hostingsvcs/github.py (Diff revision 5)
The issue has been dropped. Show all issues
```
E722 do not use bare except'
```

Description:

		Added boolean flags to HostingServices to see whether the repository
		supports posting to a bug tracker when a change is posted, closing a bug
		when a reviw request is closed, or notifying a bug tracker when there's
		new reviews or review requests for the bug.

		Added a couple extra checkboxes to the Github repository form to enable
		these options.



		Added a new method to HostingService that is called when the
		review_request_closed signal is sent.



		Added a field to the Private Github repository fields to get the value
		from an extra checkbox to enable the new options for configuring a bug
		tracker.



		Modified review_request_closed method to close the bug when the Review
		Request is closed if enable_closing_remote_bug is set to True.



		Added methods to github.py and hostingservices.py to enable sending an
		HTTP Patch request in order to allow closing a Github Issue.



		Added a method to post to a github issue when a ReviewRequest is
		updated.



		Added docstrings and post to bug on first reference.





		Added a bug tracker form to HostingService.
		Updated RepositoryForm to use the new Bug tracker form in the Bug tracker section if it exists.
	+
	+
	+
	+	Added properties to Repository, and fixed any issues I found.

Commit:

9576897c151d96d8078044e3032f635cc1898dfd

d7d59b077cba78e09e60c4ed789fdcdc6d87711e

Diff:

Revision 6 (+498 -4)

Show changes

	reviewboard/hostingsvcs/bugtracker.py
	reviewboard/hostingsvcs/github.py
	reviewboard/hostingsvcs/service.py
	reviewboard/scmtools/forms.py
	reviewboard/scmtools/models.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/github.py (Diff revision 6)
The issue has been resolved. Show all issues
```
E501 line too long (81 > 79 characters)
```
reviewboard/hostingsvcs/github.py (Diff revision 6)
The issue has been dropped. Show all issues
```
E722 do not use bare except'
```
reviewboard/hostingsvcs/github.py (Diff revision 6)
The issue has been dropped. Show all issues
```
E722 do not use bare except'
```
reviewboard/hostingsvcs/github.py (Diff revision 6)
The issue has been dropped. Show all issues
```
E722 do not use bare except'
```
reviewboard/hostingsvcs/service.py (Diff revision 6)
The issue has been resolved. Show all issues
```
E501 line too long (87 > 79 characters)
```
reviewboard/hostingsvcs/service.py (Diff revision 6)
The issue has been dropped. Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/hostingsvcs/service.py (Diff revision 6)
The issue has been dropped. Show all issues
```
E128 continuation line under-indented for visual indent
```

Summary:

[WIP] Added docstrings and post to bug on first reference

[WIP] Fixed a bunch of test failures caused by changes made

Description:

		Added boolean flags to HostingServices to see whether the repository
		supports posting to a bug tracker when a change is posted, closing a bug
		when a reviw request is closed, or notifying a bug tracker when there's
		new reviews or review requests for the bug.

		Added a couple extra checkboxes to the Github repository form to enable
		these options.



		Added a new method to HostingService that is called when the
		review_request_closed signal is sent.



		Added a field to the Private Github repository fields to get the value
		from an extra checkbox to enable the new options for configuring a bug
		tracker.



		Modified review_request_closed method to close the bug when the Review
		Request is closed if enable_closing_remote_bug is set to True.



		Added methods to github.py and hostingservices.py to enable sending an
		HTTP Patch request in order to allow closing a Github Issue.



		Added a method to post to a github issue when a ReviewRequest is
		updated.



		Added docstrings and post to bug on first reference.





		Added a bug tracker form to HostingService.
		Updated RepositoryForm to use the new Bug tracker form in the Bug tracker section if it exists.



		Added properties to Repository, and fixed any issues I found.
	+
	+
	+
	+	Fixed a bunch of test failures caused by changes made.

Commit:

d7d59b077cba78e09e60c4ed789fdcdc6d87711e

9e396e93938f978372ac480678f427c6015b0e30

Diff:

Revision 7 (+501 -4)

Show changes

	reviewboard/hostingsvcs/bugtracker.py
	reviewboard/hostingsvcs/github.py
	reviewboard/hostingsvcs/service.py
	reviewboard/scmtools/forms.py
	reviewboard/scmtools/models.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/github.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E501 line too long (81 > 79 characters)
```
reviewboard/hostingsvcs/github.py (Diff revision 7)
The issue has been dropped. Show all issues
```
E722 do not use bare except'
```
reviewboard/hostingsvcs/github.py (Diff revision 7)
The issue has been dropped. Show all issues
```
E722 do not use bare except'
```
reviewboard/hostingsvcs/github.py (Diff revision 7)
The issue has been dropped. Show all issues
```
E722 do not use bare except'
```
reviewboard/hostingsvcs/service.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E501 line too long (87 > 79 characters)
```
reviewboard/hostingsvcs/service.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/hostingsvcs/service.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/hostingsvcs/service.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/hostingsvcs/service.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/hostingsvcs/service.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E501 line too long (82 > 79 characters)
```
reviewboard/hostingsvcs/service.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```

Description:

		Added boolean flags to HostingServices to see whether the repository
		supports posting to a bug tracker when a change is posted, closing a bug
		when a reviw request is closed, or notifying a bug tracker when there's
		new reviews or review requests for the bug.

		Added a couple extra checkboxes to the Github repository form to enable
		these options.



		Added a new method to HostingService that is called when the
		review_request_closed signal is sent.



		Added a field to the Private Github repository fields to get the value
		from an extra checkbox to enable the new options for configuring a bug
		tracker.



		Modified review_request_closed method to close the bug when the Review
		Request is closed if enable_closing_remote_bug is set to True.



		Added methods to github.py and hostingservices.py to enable sending an
		HTTP Patch request in order to allow closing a Github Issue.



		Added a method to post to a github issue when a ReviewRequest is
		updated.



		Added docstrings and post to bug on first reference.





		Added a bug tracker form to HostingService.
		Updated RepositoryForm to use the new Bug tracker form in the Bug tracker section if it exists.



		Added properties to Repository, and fixed any issues I found.



~		Fixed a bunch of test failures caused by changes made.
	~	Fixed a bunch of test failures caused by changes made.
	+	Fixed Review Bot issues.

Commit:

9e396e93938f978372ac480678f427c6015b0e30

02f519019115a982677a661bb9b9d8c8daad30d4

Diff:

Revision 8 (+505 -4)

Show changes

	reviewboard/hostingsvcs/bugtracker.py
	reviewboard/hostingsvcs/github.py
	reviewboard/hostingsvcs/service.py
	reviewboard/scmtools/forms.py
	reviewboard/scmtools/models.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/github.py (Diff revision 8)
The issue has been dropped. Show all issues
```
E722 do not use bare except'
```
reviewboard/hostingsvcs/github.py (Diff revision 8)
The issue has been dropped. Show all issues
```
E722 do not use bare except'
```
reviewboard/hostingsvcs/github.py (Diff revision 8)
The issue has been dropped. Show all issues
```
E722 do not use bare except'
```

reviewboard/hostingsvcs/github.py (Diff revision 8)
The issue has been resolved. Show all issues
```
Just an empty line in the function docstring.
```

reviewboard/hostingsvcs/service.py (Diff revision 8)

The issue has been resolved. Show all issues

For someone who is unfamiliar with the project, I think it would be useful to add a comment about why the function is not implemented, or a TODO comment if the implementation is expected down the line (or in a separate project).

reviewboard/hostingsvcs/service.py (Diff revision 8)
The issue has been resolved. Show all issues
```
Same comment as above to add a comment or TODO note.
```

reviewboard/hostingsvcs/service.py (Diff revision 8)

The issue has been resolved. Show all issues

I see that after the first and, there is a check for (<expr> and <expr>) or (<expr> and <expr>). For readability, I think it might be useful to extract these booleans into separate variables with meaningful names.

Summary:

[WIP] Fixed a bunch of test failures caused by changes made

[WIP] Deeper Bug Tracker Integrations

Description:

~		Added boolean flags to HostingServices to see whether the repository
~		supports posting to a bug tracker when a change is posted, closing a bug
~		when a reviw request is closed, or notifying a bug tracker when there's
~		new reviews or review requests for the bug.
~
~		Added a couple extra checkboxes to the Github repository form to enable
~		these options.
~
~
~
~		Added a new method to HostingService that is called when the
~		review_request_closed signal is sent.
~
	~	Added options to the Github repository form to enable posting
	~	to a Github issue when a bug is first mentioned or when a
	~	review request referencing a bug is updated and closing a
	~	Github issue when a Review Reques is closed.
	~	Added properties to Repository for the new bug tracker
	~	integration options.
	~	Added new methods to HostingService that are called when the
	~	review request is closed or updated to take care of these
	~	deeper bug tracking options.
	~	Added the ability to post to bug on first reference.
	~	Added a bug tracker form to HostingService.
	~	Updated RepositoryForm to use the new bug tracker form in the
	~	bug tracker section if it exists.
-
-
-		Added a field to the Private Github repository fields to get the value
-		from an extra checkbox to enable the new options for configuring a bug
-		tracker.
-
-
-
-		Modified review_request_closed method to close the bug when the Review
-		Request is closed if enable_closing_remote_bug is set to True.
-
-
-
-		Added methods to github.py and hostingservices.py to enable sending an
-		HTTP Patch request in order to allow closing a Github Issue.
-
-
-
-		Added a method to post to a github issue when a ReviewRequest is
-		updated.
-
-
-
-		Added docstrings and post to bug on first reference.
-
-
-
-
-
-		Added a bug tracker form to HostingService.
-		Updated RepositoryForm to use the new Bug tracker form in the Bug tracker section if it exists.
-
-
-
-		Added properties to Repository, and fixed any issues I found.
-
-
-
-		Fixed a bunch of test failures caused by changes made.
-		Fixed Review Bot issues.

Commit:

02f519019115a982677a661bb9b9d8c8daad30d4

419968a97078679c63077231efb5cf48ceb2601a

Diff:

Revision 9 (+512 -4)

Show changes

	reviewboard/hostingsvcs/bugtracker.py
	reviewboard/hostingsvcs/github.py
	reviewboard/hostingsvcs/service.py
	reviewboard/scmtools/forms.py
	reviewboard/scmtools/models.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/github.py (Diff revision 9)
An issue was opened. Show all issues
```
E722 do not use bare except'
```
reviewboard/hostingsvcs/github.py (Diff revision 9)
An issue was opened. Show all issues
```
E722 do not use bare except'
```
reviewboard/hostingsvcs/github.py (Diff revision 9)
An issue was opened. Show all issues
```
E722 do not use bare except'
```
reviewboard/hostingsvcs/service.py (Diff revision 9)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```

Summary:

[WIP] Deeper Bug Tracker Integrations

Deeper Bug Tracker Integrations

Description:

		Added options to the Github repository form to enable posting
		to a Github issue when a bug is first mentioned or when a
		review request referencing a bug is updated and closing a
~		Github issue when a Review Reques is closed.
	~	Github issue when a Review Request is closed.
		Added properties to Repository for the new bug tracker
		integration options.
		Added new methods to HostingService that are called when the
		review request is closed or updated to take care of these
		deeper bug tracking options.
		Added the ability to post to bug on first reference.
		Added a bug tracker form to HostingService.
		Updated RepositoryForm to use the new bug tracker form in the
		bug tracker section if it exists.

Testing Done:

	+	Created unit tests in reviewboard.hostingsvcs.tests.test_github.py
	+	Tested everything with a private GitHub repo and a local reviewboard instance.

Commit:

419968a97078679c63077231efb5cf48ceb2601a

e59c33417f4825a697f4ddb3da41184a5994c9c9

Diff:

Revision 10 (+821 -4)

Show changes

	reviewboard/hostingsvcs/bugtracker.py
	reviewboard/hostingsvcs/github.py
	reviewboard/hostingsvcs/service.py
	reviewboard/hostingsvcs/tests/test_github.py
	reviewboard/scmtools/forms.py
	reviewboard/scmtools/models.py

Checks run (2 timed out)

flake8 timed out.

JSHint timed out.

Status:: Discarded