[WIP] Add `scmtools/service.py` with functions to register and unregister SCM tools

Review Request #9542 — Created Jan. 26, 2018 and discarded

jtrang
Review Board
master
reviewboard, students

In order to refactor SCM tool registration, the first step is to add functions for managing registration and un-registration of SCMTool classes.

Current work in progress is to add a service.py file in the scmtools directory. This file follows the same format as the one for hosting services.

TODO notes and comments have been made throughout the file.

No testing has been done.

Description From Last Updated

E302 expected 2 blank lines, found 1

reviewbotreviewbot

F821 undefined name 'EntryPointRegistry'

reviewbotreviewbot

F821 undefined name 'ALREADY_REGISTERED'

reviewbotreviewbot

F821 undefined name '_'

reviewbotreviewbot

F821 undefined name 'LOAD_ENTRY_POINT'

reviewbotreviewbot

F821 undefined name '_'

reviewbotreviewbot

F821 undefined name 'NOT_REGISTERED'

reviewbotreviewbot

F821 undefined name '_'

reviewbotreviewbot

F841 local variable 'cls_urlpatterns' is assigned to but never used

reviewbotreviewbot

E303 too many blank lines (2)

reviewbotreviewbot

F821 undefined name 'SCMTool'

reviewbotreviewbot

F821 undefined name 'service'

reviewbotreviewbot

E305 expected 2 blank lines after class or function definition, found 1

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

F821 undefined name 'ItemLookupError'

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

F821 undefined name 'ItemLookupError'

reviewbotreviewbot

F821 undefined name 'logging'

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

F821 undefined name 'receiver'

reviewbotreviewbot

F821 undefined name 'initializing'

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

MA
  1. 
      
  2. reviewboard/scmtools/service.py (Diff revision 1)
     
     

    Question:
    How does an entrypoint relate to an SCMtool? Is an entrypoint an overarching way to access any SCMTool?

  3. reviewboard/scmtools/service.py (Diff revision 1)
     
     

    Question: How do we register SCM tools currently? Actually, what's the relation between an SCMtool and a repository?

  4. 
      
JT
Review request changed

Status: Discarded

Loading...