Summary

[WIP] Add `scmtools/service.py` with functions to register and unregister SCM tools

Review Request #9542 — Created Jan. 26, 2018 and discarded Feb. 19, 2018, 7:04 p.m.

Information

Owner

jtrang

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard, students

People

Description

In order to refactor SCM tool registration, the first step is to add functions for managing registration and un-registration of SCMTool classes.

Current work in progress is to add a service.py file in the scmtools directory. This file follows the same format as the one for hosting services.

TODO notes and comments have been made throughout the file.

Testing Done

No testing has been done.

Issues

Description	From	Last Updated
F821 undefined name 'EntryPointRegistry'	reviewbot	Jan. 26, 2018, 10:26 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Jan. 26, 2018, 10:26 p.m.
F821 undefined name 'ALREADY_REGISTERED'	reviewbot	Jan. 26, 2018, 10:26 p.m.
F821 undefined name '_'	reviewbot	Jan. 26, 2018, 10:26 p.m.
F821 undefined name 'LOAD_ENTRY_POINT'	reviewbot	Jan. 26, 2018, 10:26 p.m.
F821 undefined name '_'	reviewbot	Jan. 26, 2018, 10:26 p.m.
F821 undefined name 'NOT_REGISTERED'	reviewbot	Jan. 26, 2018, 10:26 p.m.
F821 undefined name '_'	reviewbot	Jan. 26, 2018, 10:26 p.m.
F841 local variable 'cls_urlpatterns' is assigned to but never used	reviewbot	Jan. 26, 2018, 10:26 p.m.
E303 too many blank lines (2)	reviewbot	Jan. 26, 2018, 10:26 p.m.
F821 undefined name 'SCMTool'	reviewbot	Jan. 26, 2018, 10:26 p.m.
F821 undefined name 'service'	reviewbot	Jan. 26, 2018, 10:26 p.m.
E305 expected 2 blank lines after class or function definition, found 1	reviewbot	Jan. 26, 2018, 10:26 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Jan. 26, 2018, 10:26 p.m.
F821 undefined name 'ItemLookupError'	reviewbot	Jan. 26, 2018, 10:26 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Jan. 26, 2018, 10:26 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Jan. 26, 2018, 10:26 p.m.
F821 undefined name 'ItemLookupError'	reviewbot	Jan. 26, 2018, 10:26 p.m.
F821 undefined name 'logging'	reviewbot	Jan. 26, 2018, 10:26 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Jan. 26, 2018, 10:26 p.m.
F821 undefined name 'receiver'	reviewbot	Jan. 26, 2018, 10:26 p.m.
F821 undefined name 'initializing'	reviewbot	Jan. 26, 2018, 10:26 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/scmtools/service.py (Diff revision 1)
An issue was opened. Show all issues
```
F821 undefined name 'EntryPointRegistry'
```
reviewboard/scmtools/service.py (Diff revision 1)
An issue was opened. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/scmtools/service.py (Diff revision 1)
An issue was opened. Show all issues
```
F821 undefined name 'ALREADY_REGISTERED'
```
reviewboard/scmtools/service.py (Diff revision 1)
An issue was opened. Show all issues
```
F821 undefined name '_'
```
reviewboard/scmtools/service.py (Diff revision 1)
An issue was opened. Show all issues
```
F821 undefined name 'LOAD_ENTRY_POINT'
```
reviewboard/scmtools/service.py (Diff revision 1)
An issue was opened. Show all issues
```
F821 undefined name '_'
```
reviewboard/scmtools/service.py (Diff revision 1)
An issue was opened. Show all issues
```
F821 undefined name 'NOT_REGISTERED'
```
reviewboard/scmtools/service.py (Diff revision 1)
An issue was opened. Show all issues
```
F821 undefined name '_'
```
reviewboard/scmtools/service.py (Diff revision 1)
An issue was opened. Show all issues
```
F841 local variable 'cls_urlpatterns' is assigned to but never used
```
reviewboard/scmtools/service.py (Diff revision 1)
An issue was opened. Show all issues
```
E303 too many blank lines (2)
```
reviewboard/scmtools/service.py (Diff revision 1)
An issue was opened. Show all issues
```
F821 undefined name 'SCMTool'
```
reviewboard/scmtools/service.py (Diff revision 1)
An issue was opened. Show all issues
```
F821 undefined name 'service'
```
reviewboard/scmtools/service.py (Diff revision 1)
An issue was opened. Show all issues
```
E305 expected 2 blank lines after class or function definition, found 1
```
reviewboard/scmtools/service.py (Diff revision 1)
An issue was opened. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/scmtools/service.py (Diff revision 1)
An issue was opened. Show all issues
```
F821 undefined name 'ItemLookupError'
```
reviewboard/scmtools/service.py (Diff revision 1)
An issue was opened. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/scmtools/service.py (Diff revision 1)
An issue was opened. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/scmtools/service.py (Diff revision 1)
An issue was opened. Show all issues
```
F821 undefined name 'ItemLookupError'
```
reviewboard/scmtools/service.py (Diff revision 1)
An issue was opened. Show all issues
```
F821 undefined name 'logging'
```
reviewboard/scmtools/service.py (Diff revision 1)
An issue was opened. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/scmtools/service.py (Diff revision 1)
An issue was opened. Show all issues
```
F821 undefined name 'receiver'
```
reviewboard/scmtools/service.py (Diff revision 1)
An issue was opened. Show all issues
```
F821 undefined name 'initializing'
```

reviewboard/scmtools/service.py (Diff revision 1)

Question:
How does an entrypoint relate to an SCMtool? Is an entrypoint an overarching way to access any SCMTool?

reviewboard/scmtools/service.py (Diff revision 1)

Question: How do we register SCM tools currently? Actually, what's the relation between an SCMtool and a repository?

Status:: Discarded