Add review bot tool for chardet

Review Request #9531 — Created Jan. 25, 2018 and discarded

Information

ReviewBot
master

Reviewers

Sometimes it is a rule to use ascii or utf-8
for your java or c++ files only. As it is really
easy to miss some weird characters this checker
allows to detect forbidden encodings for you.

Added ascii check, uploaded patch with utf-8
character and saw that it finds the correct line.

Description From Last Updated

README.rst files in each of /, /bot/, and /extension/ also need to list the new tool.

daviddavid

Should use PEP-8 groupings: from os.path import splitext from reviewbot.tools import Tool import chardet

daviddavid

When joining strings across lines, we put the space and the end of the line instead of the start of …

daviddavid

When joining strings across lines, we put the space and the end of the line instead of the start of …

daviddavid

I think it probably makes more sense to do this at a file level rather than per-line.

daviddavid

Can you rebase onto master and change this to use the new optional depedencies structure we have there?

daviddavid

This should probably use "ASCII" and "UTF-8" instead of lower-cased.

daviddavid

When updating to master, this will need to change too.

daviddavid

F401 'chardet' imported but unused

reviewbotreviewbot
misery
misery
misery
misery
misery
misery
  1. 
      
  2. Ping! Will this be merged or discarded? Otherwise I will add it to my bots.

    https://github.com/misery/ExtendedBots

  3. 
      
david
  1. 
      
  2. Show all issues

    README.rst files in each of /, /bot/, and /extension/ also need to list the new tool.

  3. bot/reviewbot/tools/chardetector.py (Diff revision 6)
     
     
     
     
     
    Show all issues

    Should use PEP-8 groupings:

    from os.path import splitext
    
    from reviewbot.tools import Tool
    
    import chardet
    
  4. bot/reviewbot/tools/chardetector.py (Diff revision 6)
     
     
     
    Show all issues

    When joining strings across lines, we put the space and the end of the line instead of the start of the next.

  5. bot/reviewbot/tools/chardetector.py (Diff revision 6)
     
     
     
    Show all issues

    When joining strings across lines, we put the space and the end of the line instead of the start of the next.

  6. bot/reviewbot/tools/chardetector.py (Diff revision 6)
     
     
     
     
    Show all issues

    I think it probably makes more sense to do this at a file level rather than per-line.

    1. It is very helpful if the bot shows the line with the special symbol. Otherwise the user needs to investigate here.

  7. bot/setup.py (Diff revision 6)
     
     
    Show all issues

    Can you rebase onto master and change this to use the new optional depedencies structure we have there?

  8. docs/reviewbot/tools/chardetector.rst (Diff revision 6)
     
     
    Show all issues

    This should probably use "ASCII" and "UTF-8" instead of lower-cased.

  9. docs/reviewbot/tools/chardetector.rst (Diff revision 6)
     
     
     
    Show all issues

    When updating to master, this will need to change too.

  10. 
      
misery
Review request changed
Branch:
release-1.0.x
master
Commit:
eaa47138ea1f08572ef7bd7123d91b85a626cde4
313e0092505faa1923d4a938af4c829325e546ea

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

misery
Review request changed
Status:
Discarded
Change Summary:

https://github.com/misery/ExtendedBots