flake8
passed.
JSHint
passed.
Add review bot tool for chardet
Review Request #9531 — Created Jan. 25, 2018 and discarded
Sometimes it is a rule to use ascii or utf-8 for your java or c++ files only. As it is really easy to miss some weird characters this checker allows to detect forbidden encodings for you.
Added ascii check, uploaded patch with utf-8
character and saw that it finds the correct line.
| Description | From | Last Updated |
|---|---|---|
|
README.rst files in each of /, /bot/, and /extension/ also need to list the new tool. |
 david
|
|
|
Should use PEP-8 groupings: from os.path import splitext from reviewbot.tools import Tool import chardet |
david
|
|
|
When joining strings across lines, we put the space and the end of the line instead of the start of … |
david
|
|
|
When joining strings across lines, we put the space and the end of the line instead of the start of … |
david
|
|
|
I think it probably makes more sense to do this at a file level rather than per-line. |
david
|
|
|
Can you rebase onto master and change this to use the new optional depedencies structure we have there? |
david
|
|
|
This should probably use "ASCII" and "UTF-8" instead of lower-cased. |
david
|
|
|
When updating to master, this will need to change too. |
david
|
|
|
F401 'chardet' imported but unused |
 reviewbot
|
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+92) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+92) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+92) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Testing Done: |
|
||||||
|---|---|---|---|---|---|---|---|
Commit: |
|
||||||
Diff: |
Revision 5 (+95) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Change Summary:
rebase
Branch: |
|
||||
|---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 6 (+95) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
-
bot/reviewbot/tools/chardetector.py (Diff revision 6) Should use PEP-8 groupings:
from os.path import splitext from reviewbot.tools import Tool import chardet -
bot/reviewbot/tools/chardetector.py (Diff revision 6) When joining strings across lines, we put the space and the end of the line instead of the start of the next.
-
bot/reviewbot/tools/chardetector.py (Diff revision 6) When joining strings across lines, we put the space and the end of the line instead of the start of the next.
-
bot/reviewbot/tools/chardetector.py (Diff revision 6) I think it probably makes more sense to do this at a file level rather than per-line.
-
bot/setup.py (Diff revision 6) Can you rebase onto master and change this to use the new optional depedencies structure we have there?
-
docs/reviewbot/tools/chardetector.rst (Diff revision 6) This should probably use "ASCII" and "UTF-8" instead of lower-cased.
-
docs/reviewbot/tools/chardetector.rst (Diff revision 6) When updating to master, this will need to change too.
Branch: |
|
||||
|---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 7 (+125) |
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.